Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021885Openbravo ERP09. Financial managementpublic2012-10-09 01:592012-10-30 12:58
pjuvara 
ioritzCia 
normalmajorhave not tried
closedfixed 
5
main 
 
xabiermerino
OBPS
Core
No
0021885: Wrong action taken when payment is added to invoice
Consider this scenario (with reference to F&B demo data):
- Bank account "Bank account 1" has two payment methods: Check and Wire Transfer
- Check is configured with Automatic Deposit = N
- Wire Transfer is configured with Automatic Deposit = Y

Consider a sales invoice that has payment method Wire Transfer.

If the customer instead of wire transfer pays with check, you can record that by pressing the Add Payment button and in the popup window change the payment method.

When you click process, since the payment method does not have automatic deposit, you should be able to choose between the two actions:
   - Process Received Payment(s) (default option)
   - Process Received Payment(s) and Deposit

However, only the second option "Process Received Payment(s) and Deposit" is available.

This means that the set of available actions is not derived from the payment method that the user has chosen but the payment method of the invoice.
This issue can be reproduced in main using the live build environment.
Login as Openbravo.
Navigate to the sales invoice window
Select an invoice with Wire Transfer as payment method, for example invoice 1000027.
Click on Add Payment
Change payment method to Check
Click Process

You should see Process Received Payment(s) as an option.
Coworking
Issue History
2012-10-09 01:59pjuvaraNew Issue
2012-10-09 01:59pjuvaraAssigned To => dmiguelez
2012-10-09 01:59pjuvaraModules => Core
2012-10-09 01:59pjuvaraOBNetwork customer => Yes
2012-10-09 02:00pjuvaraTag Attached: Coworking
2012-10-09 11:14dmiguelezAssigned Todmiguelez => jonalegriaesarte
2012-10-09 13:27ioritzCiaAssigned Tojonalegriaesarte => ioritzCia
2012-10-15 09:43ioritzCiaStatusnew => scheduled
2012-10-15 09:43ioritzCiafix_in_branch => pi
2012-10-16 09:14hgbotCheckin
2012-10-16 09:14hgbotNote Added: 0053364
2012-10-16 09:14hgbotStatusscheduled => resolved
2012-10-16 09:14hgbotResolutionopen => fixed
2012-10-16 09:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4b56827a346b5a34e3f294ef9a953b6e7440bf3d [^]
2012-10-16 18:54hudsonbotCheckin
2012-10-16 18:54hudsonbotNote Added: 0053403
2012-10-30 12:58xabiermerinoReview Assigned To => xabiermerino
2012-10-30 12:58xabiermerinoNote Added: 0053814
2012-10-30 12:58xabiermerinoStatusresolved => closed

Notes
(0053364)
hgbot   
2012-10-16 09:14   
Repository: erp/devel/pi
Changeset: 4b56827a346b5a34e3f294ef9a953b6e7440bf3d
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Mon Oct 15 09:41:26 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4b56827a346b5a34e3f294ef9a953b6e7440bf3d [^]

Fixes issue 21885: Wrong action taken when payment is added to invoice.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0053403)
hudsonbot   
2012-10-16 18:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0381663eaf40 [^]

Maturity status: Test
(0053814)
xabiermerino   
2012-10-30 12:58   
verified