Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021776Openbravo ERPA. Platformpublic2012-09-27 16:412012-11-27 11:21
Reporterjecharri 
Assigned Todbaz 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP18Fixed in Version3.0MP18 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021776: Sales order tab is closed when you delete the business partner name
DescriptionSales order tab is closed when you delete the business partner name.

I have to add that this problem only happens in Windows
Steps To ReproduceGo to windows PC.
-Login in live as "Admin" and go to window sales order.
-start writing a name for a "BP" selector but before the end delete all that you have written
-not every time but 70-80% of the time the window sales order is closed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-09-27 16:41jecharriNew Issue
2012-09-27 16:41jecharriAssigned To => AugustoMauch
2012-09-27 16:41jecharriWeb browser => Google Chrome
2012-09-27 16:41jecharriModules => Core
2012-09-27 16:41jecharriResolution time => 1355180400
2012-10-09 15:43AugustoMauchAssigned ToAugustoMauch => shankarb
2012-10-09 16:12AugustoMauchAssigned Toshankarb => AugustoMauch
2012-10-09 16:28AugustoMauchAssigned ToAugustoMauch => dbaz
2012-10-09 16:32AugustoMauchNote Added: 0053179
2012-10-10 01:03hgbotCheckin
2012-10-10 01:03hgbotNote Added: 0053182
2012-10-11 07:51hudsonbotCheckin
2012-10-11 07:51hudsonbotNote Added: 0053282
2012-11-02 14:56jecharriWeb browserGoogle Chrome => Google Chrome
2012-11-02 14:56jecharriTarget Version3.0MP17 => 3.0MP18
2012-11-20 13:33dbazReview Assigned To => AugustoMauch
2012-11-20 13:33dbazWeb browserGoogle Chrome => Google Chrome
2012-11-20 13:33dbazIssue Monitored: AugustoMauch
2012-11-20 13:36dbazNote Added: 0054342
2012-11-20 13:38dbazNote Added: 0054343
2012-11-20 13:38hgbotCheckin
2012-11-20 13:38hgbotNote Added: 0054344
2012-11-20 13:38hgbotCheckin
2012-11-20 13:38hgbotNote Added: 0054345
2012-11-20 13:38hgbotStatusnew => resolved
2012-11-20 13:38hgbotResolutionopen => fixed
2012-11-20 13:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/120e4b62fcd6bd126e6f2d8c70e2bd6eba4e1219 [^]
2012-11-21 06:07hudsonbotCheckin
2012-11-21 06:07hudsonbotNote Added: 0054404
2012-11-21 06:07hudsonbotCheckin
2012-11-21 06:07hudsonbotNote Added: 0054405
2012-11-27 11:21AugustoMauchNote Added: 0054519
2012-11-27 11:21AugustoMauchStatusresolved => closed
2012-11-27 11:21AugustoMauchFixed in Version => 3.0MP18

Notes
(0053179)
AugustoMauch   
2012-10-09 16:32   
Right after deleting the last character in a selector, the selector loses the focus. A moment later, it recovers it.

The problem is that if the Backspace tab is pressed when the focus is not in the selector, the window will navigate to the previous page in the browsing history [1].

[1] http://support.google.com/chrome/bin/answer.py?hl=en&answer=157179 [^]
(0053182)
hgbot   
2012-10-10 01:03   
Repository: erp/devel/pi
Changeset: 8a7218c16d56fba22feff61ea917d034d0be8873
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Oct 10 01:02:35 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8a7218c16d56fba22feff61ea917d034d0be8873 [^]

Related to issue 21776: Prevent 'Backspace' key propagation in DIVs
to avoid 'Go to previous page' default browser behavior

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/classic/ob-classic-compatibility.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-keyboard-manager.js
---
(0053282)
hudsonbot   
2012-10-11 07:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63dfc135f2a1 [^]

Maturity status: Test
(0054342)
dbaz   
2012-11-20 13:36   
In the few ms that the selector blurs to execute the FIC, the focus is too high to be captured by Canvas onkeydown handlers

The solution passes for a temporary "window.onkeydown" set (which is able to capture events at this level) when the pressed key is the "Backspace"

P.S: Also added some logic to prevent 'Backspace' too in classic windows.
(0054343)
dbaz   
2012-11-20 13:38   
The fix is low-medium risk.
(0054344)
hgbot   
2012-11-20 13:38   
Repository: erp/devel/pi
Changeset: 058f482a9f015f8a9b85f7919ad5c9d6d045aded
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Nov 20 12:48:26 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/058f482a9f015f8a9b85f7919ad5c9d6d045aded [^]

Related to issue 21776: Reverted previous changeset

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/classic/ob-classic-compatibility.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-keyboard-manager.js
---
(0054345)
hgbot   
2012-11-20 13:38   
Repository: erp/devel/pi
Changeset: 120e4b62fcd6bd126e6f2d8c70e2bd6eba4e1219
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Nov 20 13:32:36 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/120e4b62fcd6bd126e6f2d8c70e2bd6eba4e1219 [^]

Fixed issue 21776: Prevent 'Backspace' key propagation
(as a browser 'go back' shortcut) in all cases

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-keyboard-manager.js
M web/js/utils.js
---
(0054404)
hudsonbot   
2012-11-21 06:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^]

Maturity status: Test
(0054405)
hudsonbot   
2012-11-21 06:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^]

Maturity status: Test
(0054519)
AugustoMauch   
2012-11-27 11:21   
Code reviewed and verified in pi@b43e48d603a9