Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021760Openbravo ERPA. Platformpublic2012-09-26 12:272012-10-23 13:41
Reporterjecharri 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP17Fixed in Version3.0MP17 
Merge Request Status
Review Assigned Todbaz
OBNetwork customerOBPS
Web browserGoogle Chrome
ModulesCore
Support ticket17151
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021760: First Focused Field is not working in tab Customer
DescriptionFirst Focused Field is not working in tab Customer
Steps To ReproduceAs "System" go to "Windows, tabs and fields":
-select window "Business Partner" and go to tab "Customer"
-go to "Fields" and put the field "Price List" as "First Focused Field"
-Uncheck the previous field as first focused.

Execute ant compile.complete.deploy // restart tomcat // verify that it does not work.
Proposed SolutionUse the first focused field property not only when a new row is created but also when the tab gets the focus (now the focus goes to the first field which does not always makes sense because it can be read only)
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-09-26 12:27jecharriNew Issue
2012-09-26 12:27jecharriAssigned To => AugustoMauch
2012-09-26 12:27jecharriWeb browser => Google Chrome
2012-09-26 12:27jecharriModules => Core
2012-09-26 12:27jecharriOBNetwork customer => Yes
2012-09-26 12:27jecharriSupport ticket => 17151
2012-09-26 12:27jecharriResolution time => 1355180400
2012-09-26 16:08AugustoMauchWeb browserGoogle Chrome => Google Chrome
2012-09-26 16:08AugustoMauchNote Added: 0052633
2012-09-26 16:08AugustoMauchTypedefect => design defect
2012-09-26 16:08AugustoMauchProposed Solution updated
2012-09-26 16:08AugustoMauchWeb browserGoogle Chrome => Google Chrome
2012-09-26 16:08AugustoMauchNote Added: 0052634
2012-09-26 16:08AugustoMauchStatusnew => scheduled
2012-10-09 16:17AugustoMauchAssigned ToAugustoMauch => shankarb
2012-10-16 16:08shankarbNote Added: 0053374
2012-10-17 10:10hgbotCheckin
2012-10-17 10:10hgbotNote Added: 0053409
2012-10-17 10:10hgbotStatusscheduled => resolved
2012-10-17 10:10hgbotResolutionopen => fixed
2012-10-17 10:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/20bb7c237b8afba8f9e21b46798c6d0042cac6b9 [^]
2012-10-17 10:12shankarbIssue Monitored: dbaz
2012-10-17 10:14shankarbNote Added: 0053410
2012-10-17 10:14shankarbStatusresolved => new
2012-10-17 10:14shankarbResolutionfixed => open
2012-10-17 10:14shankarbStatusnew => scheduled
2012-10-17 10:14shankarbfix_in_branch => pi
2012-10-17 10:15shankarbReview Assigned To => dbaz
2012-10-17 10:15shankarbWeb browserGoogle Chrome => Google Chrome
2012-10-17 10:15shankarbfix_in_branchpi =>
2012-10-17 10:15shankarbStatusscheduled => resolved
2012-10-17 10:15shankarbResolutionopen => fixed
2012-10-22 13:27hudsonbotCheckin
2012-10-22 13:27hudsonbotNote Added: 0053510
2012-10-23 13:41dbazNote Added: 0053573
2012-10-23 13:41dbazStatusresolved => closed
2012-10-23 13:41dbazFixed in Version => 3.0MP17

Notes
(0052633)
AugustoMauch   
2012-09-26 16:08   
This is not a defect, because the first focused field property is only considered when creating a new record, not when the tab is focused.

It has to be discussed if it makes sense to use the first focused field property to set the focus on a particular field when the tab gets the focus.
(0052634)
AugustoMauch   
2012-09-26 16:08   
Effort: 1
Impact: mid
Plan: short
(0053374)
shankarb   
2012-10-16 16:08   
Test plan:
1. Modify first focussed field from 'customer' to 'Price List' in the Customer tab under Business Partner.
2. Log out and login into the client admin role.

Before the fix:
1. When we open a record of Business Partner from grid, it will open in form view and the customer tab's record will also open in form view.
2. Left click on the Customer tab.
3. The Customer field will be highlighted even though price list is the first focused field.

After the fix:
1. When we open a record of Business Partner from grid, it will open in form view and the customer tab's record will also open in form view.
2. Left click on the Customer tab.
3. The Price List field will be highlighted (the field that was set as First Focused field)

The rule that is applied is if the last focused field is available, set the focus to that. If not, set the focus to the field that First Focused field property set. If that is a non accessible field, the control will be transferred to the next available field.
(0053409)
hgbot   
2012-10-17 10:10   
Repository: erp/devel/pi
Changeset: 20bb7c237b8afba8f9e21b46798c6d0042cac6b9
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Oct 16 16:13:22 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/20bb7c237b8afba8f9e21b46798c6d0042cac6b9 [^]

Fixes Issue 0021760: First Focused Field is not working in tab Customer

The First Focussed field property is used when creating a new row or while editing in grid. But in few tabs, on tab focus, if the lastFocusedItem is null, it picks up the first field in the form. Modified it take the First Focussed field property into account.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0053410)
shankarb   
2012-10-17 10:14   
Reopened to enter Review Assigned to.
(0053510)
hudsonbot   
2012-10-22 13:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/483f2e6dc1af [^]

Maturity status: Test
(0053573)
dbaz   
2012-10-23 13:41   
Reviewed @ changeset: 18265 - 021d7e0895a3