Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021709Openbravo ERPA. Platformpublic2012-09-21 09:562012-09-28 14:38
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP16Fixed in Version3.0MP15 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2012-08-29
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/d500176d7771e75ea21f5fbe34c90e296110b8ab [^]
Triggers an Emergency PackNo
Summary0021709: After saving a change in the grid, the tab title do not remove the '*' until another row is selected
DescriptionWhen there are unsaved changes in a view, the tab title shows an '*', that is removed when the changes are saved or canceled.

Currently, after saving the changes done in a row in the grid, the '*' is not removed until another row is selected. This does not happen in the form view, or when the changes are canceled in the grid or in the form view.
Steps To ReproduceIn any window:
- Open a row in edit mode.
- Make a change. Notice that the '*' appears in the tab title.
- Save the record with the toolbar button, with the row button or with the shortcut.
- Notice that the '*' is still in the title.
- Move to another row. The '*' dissapears
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00213523.0MP15 closed mtaal Enter key duplicates the line number in sales order line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-09-21 09:56AugustoMauchNew Issue
2012-09-21 09:56AugustoMauchAssigned To => AugustoMauch
2012-09-21 09:56AugustoMauchModules => Core
2012-09-21 10:35AugustoMauchRegression level => Packaging and release
2012-09-21 11:17AugustoMauchRegression levelPackaging and release => Pre packaging ( pi )
2012-09-21 12:29AugustoMauchRegression date => 2012-08-29
2012-09-21 12:29AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/d500176d7771e75ea21f5fbe34c90e296110b8ab [^]
2012-09-21 12:29AugustoMauchRelationship addedrelated to 0021352
2012-09-21 12:34AugustoMauchIssue Monitored: dbaz
2012-09-21 12:34AugustoMauchClosed by => dbaz
2012-09-21 12:35AugustoMauchNote Added: 0052278
2012-09-21 12:36hgbotCheckin
2012-09-21 12:36hgbotNote Added: 0052280
2012-09-21 12:36hgbotStatusnew => resolved
2012-09-21 12:36hgbotResolutionopen => fixed
2012-09-21 12:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4457b10d26e6686d742c609407d3cb2c3740760e [^]
2012-09-21 14:00dbazNote Added: 0052284
2012-09-21 14:00dbazStatusresolved => closed
2012-09-21 14:00dbazFixed in Version => 3.0MP15
2012-09-24 18:48dbazIssue End Monitor: dbaz
2012-09-26 17:16hgbotCheckin
2012-09-26 17:16hgbotNote Added: 0052665
2012-09-26 17:16hgbotStatusclosed => resolved
2012-09-26 17:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4457b10d26e6686d742c609407d3cb2c3740760e [^] => http://code.openbravo.com/erp/devel/pi/rev/a975007ee08356357dc2737b24e59c1a2e544ce0 [^]
2012-09-26 17:34gorka_gilStatusresolved => closed
2012-09-28 14:38hudsonbotCheckin
2012-09-28 14:38hudsonbotNote Added: 0052877

Notes
(0052278)
AugustoMauch   
2012-09-21 12:35   
This regression was caused by this line: https://code.openbravo.com/erp/devel/pi/rev/d500176d7771e75ea21f5fbe34c90e296110b8ab#l2.10. [^] It caused the call to updateTabTitle to be executed while the grid was still in edit mode.
(0052280)
hgbot   
2012-09-21 12:36   
Repository: erp/devel/pi
Changeset: 4457b10d26e6686d742c609407d3cb2c3740760e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 21 12:33:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4457b10d26e6686d742c609407d3cb2c3740760e [^]

Fixes issue 21709: Tab title is updated when a record is saved in the grid view

The fix of the issue 21352 caused the updateTabTitle function to be executed when the grid was still in edit mode, so the '*' in the tab title remained. Removing the code that caused this issue was not possible, because then the original issue was reproducible. Instead, an extra call to updateTabTitle is done when the records exists the edit mode.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0052284)
dbaz   
2012-09-21 14:00   
Reviewed @ changeset: 17994 - 4457b10d26e6
(0052665)
hgbot   
2012-09-26 17:16   
Repository: erp/devel/pi
Changeset: a975007ee08356357dc2737b24e59c1a2e544ce0
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 21 12:33:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a975007ee08356357dc2737b24e59c1a2e544ce0 [^]

Fixes issue 21709: Tab title is updated when a record is saved in the grid view

The fix of the issue 21352 caused the updateTabTitle function to be executed when the grid was still in edit mode, so the '*' in the tab title remained. Removing the code that caused this issue was not possible, because then the original issue was reproducible. Instead, an extra call to updateTabTitle is done when the records exists the edit mode.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0052877)
hudsonbot   
2012-09-28 14:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test