Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021665Openbravo ERP09. Financial managementpublic2012-09-17 10:172012-10-01 18:35
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021665: Bank format redesign
DescriptionThere are currently two windows where we can enter bank account information: the Business Partner | Bank Account, and the Financial Account window.

The fields, structure and the way to enter the account info is totally different and we should unify it. Apart from that, the structure of the Financial Accounts fields doesn't allow to enter some bank formats, like US format.



Current status Financial Account (see screenshot):
We have several fields into the Financial Account that belong to Spanish format:
* Bank code
* Branch code
* Bank control digit
* Account control digit
* Partial Account No.
The concatenation of all of them should automatically generate the Account No., which is the "real account number" used in the application (not working right now)
Apart from them, we also have IBAN and Swift code
Current status Business Partner Bank (see screenshot):
Two fields for entering the account number: Account No. and IBAN
Two checkboxes for selecting which of the previous fields is used: Show Generic and Show IBAN
Depending on the checbox selected, a field called Displayed Account No. is automatically generated from the correspondent value. This field is readonly and it is the "real account number" used in the application
Steps To ReproduceSee bank_account.jpg attachment with a capture of the current situation
Proposed SolutionNew design proposal:
Unify Financial Account and Business Partner bank fields
The logic should be the same as the Business Partner window.
The checkboxes logic will be replaced by a list with all the possible bank formats. This list can be extended by modularity, and it will be used for generating the Displayed Account No.
This Displayed Account No. will be the one used in the application.

Changes for Business Partner | Bank Account:
Account No. renamed to Generic Account No.
Increase Account No. size to 100 and Displayed Account No size. to 120
Show Generic and Show IBAN hidden and deprecated.
Added Swift Code field.
New Bank Account Format list [Mandatory] includes: Use Generic Account No, Use IBAN and Use SWIFT.
New fields order (see screenshot)
The Displayed Account No. will be automatically generate when saving the record.

Changes for Financial Account:
Account No. renamed to Displayed Account No. Make it read only (automatically calculated). Increase size to 120.
The following fields related to Spanish format are moved to the field group "Other bank formats":
* Bank code
* Branch code
* Bank control digit
* Account control digit
* Partial Account No.
Added Country field. In case Country=Spain, we show the Spanish fields.
Create two new fields: Generic Account No. and SWIFT code
New Bank Account Format list [NOT Mandatory] includes: Use Generic Account No., Use IBAN, Use SWIFT and use Spanish.
New fields order (see screenshot)
The Displayed Account No. will be automatically generate when saving the record based on the Bank Format selected

Other changes:
Move IBAN validator to a function and use it in both Financial Account and Business Partner windows


Updates from previous MP:
To ensure previous clients are able to update to this changes, the following code has been included:
+ C_BP_BANKACCOUNT table: The Mandatory Bank Format list will be populated to Use Generic or Use IBAN based on the status of the Show Generic and Show IBAN using the oncreatedefault for this column
+ FIN_FINANCIAL_ACCOUNT table: The generic account no. will be automatically populated to the value of the displayed account no. (which is the previous account no.) using the oncreatedefault. In case the financial account type is a bank, then the Bank Format will be automatically populated to 'Generic'.
+ A new EntityPersistenceEventObserver has been declared over the Bank Account for Business Partner to ensure old code that doesn't use the new mandatory Bank Format list keeps on working.
Additional Information
TagsCoworking
Relationships
Attached Filesjpg bank_account.jpg (69,765) 2012-09-17 10:17
https://issues.openbravo.com/file_download.php?file_id=5574&type=bug
jpg

png new_financialaccount.png (67,976) 2012-09-25 08:51
https://issues.openbravo.com/file_download.php?file_id=5595&type=bug
png

png new_bp_account.png (32,974) 2012-09-25 08:52
https://issues.openbravo.com/file_download.php?file_id=5596&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-09-17 10:17vmromanosNew Issue
2012-09-17 10:17vmromanosAssigned To => vmromanos
2012-09-17 10:17vmromanosFile Added: bank_account.jpg
2012-09-17 10:17vmromanosModules => Core
2012-09-17 10:18vmromanosFile Added: new_financial_account.jpg
2012-09-17 10:18vmromanosFile Added: new_bp_bank.jpg
2012-09-17 10:18vmromanosTag Attached: Coworking
2012-09-17 10:18vmromanosStatusnew => scheduled
2012-09-17 10:18vmromanosfix_in_branch => pi
2012-09-25 08:31hgbotCheckin
2012-09-25 08:31hgbotNote Added: 0052517
2012-09-25 08:31hgbotStatusscheduled => resolved
2012-09-25 08:31hgbotResolutionopen => fixed
2012-09-25 08:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/06932c2df6caeb7740c86b37a96e6d9f51cd7433 [^]
2012-09-25 08:31hgbotCheckin
2012-09-25 08:31hgbotNote Added: 0052518
2012-09-25 08:31hgbotCheckin
2012-09-25 08:31hgbotNote Added: 0052519
2012-09-25 08:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/06932c2df6caeb7740c86b37a96e6d9f51cd7433 [^] => http://code.openbravo.com/erp/devel/pi/rev/e4335bcdfc62f2edbb66d507bb178dbaf727054f [^]
2012-09-25 08:31hgbotCheckin
2012-09-25 08:31hgbotNote Added: 0052520
2012-09-25 08:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e4335bcdfc62f2edbb66d507bb178dbaf727054f [^] => http://code.openbravo.com/erp/devel/pi/rev/84a0b15c82c5a6d357cd6abf502e5986a69554b9 [^]
2012-09-25 08:34vmromanosNote Added: 0052521
2012-09-25 08:34vmromanosStatusresolved => new
2012-09-25 08:34vmromanosResolutionfixed => open
2012-09-25 08:48vmromanosfix_in_branchpi =>
2012-09-25 08:48vmromanosProposed Solution updated
2012-09-25 08:48vmromanosFile Deleted: new_bp_bank.jpg
2012-09-25 08:48vmromanosFile Deleted: new_financial_account.jpg
2012-09-25 08:51vmromanosFile Added: new_financialaccount.png
2012-09-25 08:52vmromanosFile Added: new_bp_account.png
2012-09-25 08:52vmromanosStatusnew => scheduled
2012-09-25 08:52vmromanosfix_in_branch => pi
2012-09-25 09:18vmromanosNote Added: 0052524
2012-09-25 09:24vmromanosNote Added: 0052525
2012-09-25 09:29vmromanosNote Added: 0052529
2012-09-25 09:30vmromanosStatusscheduled => resolved
2012-09-25 09:30vmromanosResolutionopen => fixed
2012-09-25 11:16hgbotCheckin
2012-09-25 11:16hgbotNote Added: 0052543
2012-09-25 11:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/84a0b15c82c5a6d357cd6abf502e5986a69554b9 [^] => http://code.openbravo.com/erp/devel/pi/rev/29e0d401e2b27d251c545bd18facd84441bd45fa [^]
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052891
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052892
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052893
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052894
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052896
2012-10-01 18:35dmiguelezReview Assigned To => dmiguelez
2012-10-01 18:35dmiguelezNote Added: 0052971
2012-10-01 18:35dmiguelezStatusresolved => closed

Notes
(0052517)
hgbot   
2012-09-25 08:31   
Repository: erp/devel/pi
Changeset: 06932c2df6caeb7740c86b37a96e6d9f51cd7433
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Sep 25 08:26:44 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/06932c2df6caeb7740c86b37a96e6d9f51cd7433 [^]

Fixed bug 21665: Bank Account Format redesign
The Financial Account window and Business Partner | Bank tab have the same structure
Show * checkboxes hidden and deprecated. We use a list instead that can be easily extended
by modularity.
Added retrocompatibility for modules that use the checkboxes logic
Included oncreatedefault clauses to ensure old clients are properly migrated
Extracted IBAN validator to a db function
Included IBAN validation in Financial Account

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.v3/src-db/database/configScript.xml
M src-db/database/model/tables/C_BP_BANKACCOUNT.xml
M src-db/database/model/tables/FIN_FINANCIAL_ACCOUNT.xml
M src-db/database/model/triggers/C_BP_BANKACCOUNTIBAN_TRG.xml
M src-db/database/model/triggers/FIN_FINANCIAL_ACCOUNT_TRG2.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_FIELDGROUP.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
A modules/org.openbravo.client.application/src/org/openbravo/client/application/event/BusinessPartnerBankAccountHandler.java
A src-db/database/model/functions/C_GET_IBAN_DISPLAYED_ACCOUNT.xml
---
(0052518)
hgbot   
2012-09-25 08:31   
Repository: erp/devel/pi
Changeset: f80e308e31777a981246fc7189a61467e0cfd4a1
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Sep 24 13:48:56 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f80e308e31777a981246fc7189a61467e0cfd4a1 [^]

Related to bug 21665: Exported sampledata before including the new changes

---
M referencedata/sampledata/F_B_International_Group.xml
M referencedata/sampledata/QA_Testing.xml
---
(0052519)
hgbot   
2012-09-25 08:31   
Repository: erp/devel/pi
Changeset: e4335bcdfc62f2edbb66d507bb178dbaf727054f
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Sep 24 14:03:19 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e4335bcdfc62f2edbb66d507bb178dbaf727054f [^]

Fixed issue 21665: Sampledata includes new changes related to banks

---
M referencedata/sampledata/F_B_International_Group.xml
M referencedata/sampledata/QA_Testing.xml
---
(0052520)
hgbot   
2012-09-25 08:31   
Repository: erp/devel/pi
Changeset: 84a0b15c82c5a6d357cd6abf502e5986a69554b9
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Sep 25 08:29:41 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/84a0b15c82c5a6d357cd6abf502e5986a69554b9 [^]

Fixed bug 21665: fixed dbcons due to manual merge

---
M src-db/database/sourcedata/AD_REFERENCE.xml
---
(0052521)
vmromanos   
2012-09-25 08:34   
Reopened to update bug information
(0052524)
vmromanos   
2012-09-25 09:18   
Test Plan I:
1. Go to Financial Account window
2. Create a new record. Select type = cash
3. No Bank related fields should be displayed

Test Plan II:
1. Go to Financial Account window
2. Create a new record. Select type = bank
3. Bank related field should be displayed
4. Enter a name
5. Save. No errors displayed

Test Plan III:
1. Go to Financial Account window
2. Create a new record. Select type = bank
3. Bank related field should be displayed
4. Enter a name
5. Set Bank Account Format = Use generic Account No.
6. Try to save. An error should be displayed
7. Enter any Generic Account No.
8. Try to save. No errors are displayed

Test Plan IV:
1. Go to Financial Account window
2. Create a new record. Select type = bank
3. Bank related field should be displayed
4. Enter a name
5. Set Bank Account Format = Use SWIFT + Generic Account No
6. Try to save. An error is displayed
7. Enter any generic account no.
8. Try to save. An error is displayed
9. Removed generic account no. and enter any swift code
10. Try to save. An error is displayed
11. Enter again the generic account no.
12. Try to save. No errors are displayed

Test Plan V:
13. Remove country selector
14. Select IBAN
15. Try to save. An error is displayed
16. Enter an invalid IBAN
17. Try to save. An error is displayed
18. Enter Spain in country field
19. Try to save. An error is displayed
20. Enter a valid Spanish IBAN
21. Try to save. No errors are displayed

Test Plan VI:
22. In the moment you have selected Spain as country a new Bank Format is available (Use Spanish)
23. Select any other country and ensure Use Spanish is not shown
24. Select again Spain and Use Spanish format.
25. Spanish related fields are displayed
26. Try to save. An error is displayed
27. Enter the required data
28. Save. No errors are displayed
(0052525)
vmromanos   
2012-09-25 09:24   
Test Plan VII:
1. Go to Business Partner window and select any record
2. Go to Bank tab
3. Enter a new record. Select Use Generic Account No.
4. Try to save. An error is displayed
5. Enter a generic Account No
6. No errors are displayed

Test Plan VIII:
7. Set Bank Account Format = Use SWIFT + Generic Account No
8. Try to save. An error is displayed
9. Removed generic account no. and enter any swift code
10. Try to save. An error is displayed
11. Enter again the generic account no.
12. Try to save. No errors are displayed

Test Plan IX:
13. Remove country selector
14. Select IBAN
15. Try to save. An error is displayed
16. Enter an invalid IBAN
17. Try to save. An error is displayed
18. Enter Spain in country field
19. Try to save. An error is displayed
20. Enter a valid Spanish IBAN
21. Try to save. No errors are displayed
(0052529)
vmromanos   
2012-09-25 09:29   
Test Plan X (update process):
1. From a MP15 (or older), enter several records in Financial Account (bank and cash)
2. Fill some fields and leave empty others. For example, in a record enter only an IBAN and leave the rest empty. In other record fill the Account No and leave the rest empty, etc.
3. In the same instance, create several Business Partners | Bank Account records, with show generic and show iban combinations
4. Update to PI (including the fix) and run: ant smartbuild -Dlocal=no
5. The update process should be run fine without warnings/errors
6. Check the records have been properly updated
(0052543)
hgbot   
2012-09-25 11:16   
Repository: erp/devel/pi
Changeset: 29e0d401e2b27d251c545bd18facd84441bd45fa
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Sep 25 11:13:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/29e0d401e2b27d251c545bd18facd84441bd45fa [^]

Fixed bug 21665: related to API change
fixed C_PROJECT_WON process

---
M src-db/database/model/functions/C_PROJECT_WON.xml
---
(0052891)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test
(0052892)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test
(0052893)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test
(0052894)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test
(0052896)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test
(0052971)
dmiguelez   
2012-10-01 18:35   
Code Review + Testing OK