Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021580Openbravo ERPA. Platformpublic2012-09-07 14:092012-09-27 20:12
Reporteregoitz 
Assigned Toshuehner 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP12 
Target Version3.0MP16Fixed in Version3.0MP16 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2012-05-07
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b97198212bc308c1433d9d025c65a25637a031be [^]
Triggers an Emergency PackNo
Summary0021580: Error compilation the application on 3.0mp12
DescriptionWhen updating from mp11 to mp12 on windows the compilation fails with message:

error runing compiler javac.exe

Steps To Reproduce-On a windows environmet with several modules update from mp11 to mp12 or higher.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0020416 closed marvintm Improve compilation task so that it doesn't always compile java files inside the modules folder 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-09-07 14:09egoitzNew Issue
2012-09-07 14:09egoitzAssigned To => shuehner
2012-09-07 14:09egoitzModules => Core
2012-09-07 15:35shuehnerRelationship addedrelated to 0020416
2012-09-11 16:44shuehnerRelationship addedrelated to 0021604
2012-09-11 16:56shuehnerRegression level => Production - QA Approved
2012-09-11 16:56shuehnerRegression date => 2012-05-07
2012-09-11 16:56shuehnerRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b97198212bc308c1433d9d025c65a25637a031be [^]
2012-09-11 17:09hgbotCheckin
2012-09-11 17:09hgbotNote Added: 0051998
2012-09-11 17:09hgbotStatusnew => resolved
2012-09-11 17:09hgbotResolutionopen => fixed
2012-09-11 17:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d6111f597f9c1b0aab263145956849f62cd3c680 [^]
2012-09-11 17:09shuehnerClosed by => alostale
2012-09-11 17:14shuehnerNote Added: 0051999
2012-09-11 17:35caristuRelationship deletedrelated to 0021604
2012-09-19 16:57egoitzNote Added: 0052237
2012-09-26 17:18hudsonbotCheckin
2012-09-26 17:18hudsonbotNote Added: 0052726
2012-09-27 20:12AugustoMauchClosed byalostale => AugustoMauch
2012-09-27 20:12AugustoMauchNote Added: 0052850
2012-09-27 20:12AugustoMauchStatusresolved => closed
2012-09-27 20:12AugustoMauchFixed in Version => 3.0MP16

Notes
(0051998)
hgbot   
2012-09-11 17:09   
Repository: erp/devel/pi
Changeset: d6111f597f9c1b0aab263145956849f62cd3c680
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Sep 11 17:07:03 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d6111f597f9c1b0aab263145956849f62cd3c680 [^]

Fixed 21580: Fix compiling on windows with many modules instaleld.
When fixing issue 20416 this changed the javac sourcepath definition to
include each subfolder of each module folder which may contain .java files
individually when calling javac. However it did consider any possible subfolder
below a module folder including i.e. web, src-db, referencedata.
However none of those folder should ever contain any .java file.
The only folder which should contain .java files are: src & src-test
This excludes the following two special folders (src-wad, src-util), but those
are never used in any normal compilation.

This building of a combined sourcepath with too many folders seems to overflow
some windows only sourcepath length restriction causing the compile to fail.

This commit changes behavior of the compile process to being the following:

A normal compile will only look into the following two subfolders below
a modules' folder:
a.) src
b.) src-test
Any .java file not in one of those folders will be ignored and not compiled
anymore.

This complies with unwritten openbravo practice since 2.50.
Also a search in all (380) published modules in status QA Approved in the CR
for 3.0 did only find a single module having a java file in a non-standard
location. And examining this case shows that is clearly a (harmless) bug and
not compiling that one file will not be a problem at all.

---
M src/build.xml
---
(0051999)
shuehner   
2012-09-11 17:14   
Notes for testing.
The only known way to reproduce this bug (before applying the fix) is to have the system compiled on windows + having many modules installed.
I can provides a testcase (zip files of 106 modules) which do trigger the problem when being used in a virtual machine with windows xp.

Steps done already for testing:
a.) Reproduce that the compilation problem does not happen anymore in test-environment described above
b.) try run with the patch applied also passes fine
c.) grep of content of all (380) published modules for 3.0 in status qa approved does only show a single openbravo managed module which does have a .java file in a module but outside of src & src-db. However that is a harmless mistake in that module and will be corrected on the next upload.

c.) confirms that the behavior change implemented in this issue is not a problem for any of those 380 publishes modules.
(0052237)
egoitz   
2012-09-19 16:57   
The partner has confirm that the solution works on the environment where the problem was happening.
(0052726)
hudsonbot   
2012-09-26 17:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0052850)
AugustoMauch   
2012-09-27 20:12   
Code reviewed and verified in pi@35d251a9e659