Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021553Openbravo ERPA. Platformpublic2012-09-05 13:412012-09-26 17:18
Reporterpsanjuan 
Assigned ToAugustoMauch 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version3.0MP16 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021553: GenerateInvoice column is pointing to a wrong process named "Create Invoice".
DescriptionThe field "Create Invoice" which can be found in the tab "Volume Dicount" of the "Business Partner" window is pointing to a column named "GenerateInvoice" linked to a process named "Create Invoice".
That process is not the right one the second time you search for it.

this error happens in Google Chrome, Livebuilds (Postgres and Oracle)
Steps To ReproduceAs system admin navigate to the Windows, Tabs and Fields window.

Find the "Business Partner" window.

In that window find the tab "Volumen Discount"

In that tab find the field "Create Invoice". That field is linked to a column named "GenerateInvoice"

In the column "GenerateInvoice" navigate to the process "Create Invoice".

That action opens the "Report and Process" window which shows the process "M_Rappel_Invoice_Create". That is correct.

Do not close any window.

Go once again to the Tables and Columns window and navigate once more to the Process "Create Invoice".

This time the Report and Process window shows the process C_CommissionRun_Process

if you do it once more C_CommissionRun_Process is shown once more.

Proposed Solutionthe correct process should be shown.

This is working in Firefox.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00200683.0MP10 closed alostale Products with different search key but same name are considered the same 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-09-05 13:41psanjuanNew Issue
2012-09-05 13:41psanjuanAssigned To => AugustoMauch
2012-09-05 13:41psanjuanWeb browser => Google Chrome
2012-09-05 13:41psanjuanModules => Core
2012-09-05 13:51psanjuanWeb browserGoogle Chrome => Google Chrome
2012-09-05 13:51psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3796#r3796
2012-09-05 13:56psanjuanWeb browserGoogle Chrome => Google Chrome
2012-09-05 13:56psanjuanDescription Updatedbug_revision_view_page.php?rev_id=3798#r3798
2012-09-05 13:56psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3799#r3799
2012-09-05 14:00psanjuanWeb browserGoogle Chrome => Google Chrome
2012-09-05 14:00psanjuanDescription Updatedbug_revision_view_page.php?rev_id=3800#r3800
2012-09-05 14:00psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3801#r3801
2012-09-05 14:00psanjuanProposed Solution updated
2012-09-05 15:42AugustoMauchNote Added: 0051878
2012-09-05 16:58AugustoMauchNote Added: 0051879
2012-09-06 18:14AugustoMauchRelationship addedrelated to 0020068
2012-09-07 11:04hgbotCheckin
2012-09-07 11:04hgbotNote Added: 0051909
2012-09-07 11:04hgbotStatusnew => resolved
2012-09-07 11:04hgbotResolutionopen => fixed
2012-09-07 11:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/37976c35e0cb9d3da668aa346140e780adb89f06 [^]
2012-09-07 11:04AugustoMauchNote Added: 0051910
2012-09-07 11:04AugustoMauchStatusresolved => new
2012-09-07 11:04AugustoMauchResolutionfixed => open
2012-09-07 11:05AugustoMauchClosed by => mtaal
2012-09-07 11:05AugustoMauchWeb browserGoogle Chrome => Google Chrome
2012-09-07 11:07AugustoMauchStatusnew => scheduled
2012-09-07 11:07AugustoMauchfix_in_branch => pi
2012-09-07 11:07AugustoMauchStatusscheduled => resolved
2012-09-07 11:07AugustoMauchResolutionopen => fixed
2012-09-14 11:34mtaalNote Added: 0052122
2012-09-14 11:34mtaalStatusresolved => closed
2012-09-14 11:34mtaalFixed in Version => 3.0MP16
2012-09-26 17:18hudsonbotCheckin
2012-09-26 17:18hudsonbotNote Added: 0052697

Notes
(0051878)
AugustoMauch   
2012-09-05 15:42   
This is quite dangerous, because the process of the GenerateInvoice column is changed from M_Rappel_Invoice_Create to C_CommissionRun_Process when the Process title is pressed. See that the save toolbar buttons are enabled, and that if the Cancel Changes buttons is pressed and the the Process title is pressed again, the correct process will be opened.
(0051879)
AugustoMauch   
2012-09-05 16:58   
This happens because of this Smartclient code, that is executed when opening the new window when the process title is clicked:

    _updateValue : function (newValue) {
         
        // avoid spurious changes with auto-completion
        if (this._pendingCompletion) {
            newValue = this._handleChangeWithCompletion(newValue);
        }
            
        // unmap the value if necessary
        newValue = this.mapDisplayToValue(newValue);
        
        return this.storeValue(newValue);
    },

this.mapDisplayToValue is not going to work if there are more than one options with the same display value.

The value column of ad_process is going to be added as an identifier to guarantee that it is unique
(0051909)
hgbot   
2012-09-07 11:04   
Repository: erp/devel/pi
Changeset: 37976c35e0cb9d3da668aa346140e780adb89f06
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 07 11:03:34 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/37976c35e0cb9d3da668aa346140e780adb89f06 [^]

Fixes issue 21553: mapDisplayToValue supports valuemap with non-unique values

If mapDisplayValue is called with the currently displayed value (i.e. name) , the currently selected value (id) will be returned.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
---
(0051910)
AugustoMauch   
2012-09-07 11:04   
Reopened to enter Closed By field
(0052122)
mtaal   
2012-09-14 11:34   
Reviewed
(0052697)
hudsonbot   
2012-09-26 17:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test