0021533: ShowIf computation incorrect for showIf values which are a boolean

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0021533

Openbravo ERP

A. Platform

public

2012-09-03 13:08

2012-09-26 17:18

Reporter

mtaal

Assigned To

AugustoMauch

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0MP16

Merge Request Status

Review Assigned To

mtaal

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0021533: ShowIf computation incorrect for showIf values which are a boolean

Description

In the ob-main-view.js the showIf property is replaced with a function, see this line:
fld.showIf = function (item, value, form, values) {

then the original value of showIf is stored in the originalShowIf property. And it is then called in the function above:
          originalShowIfValue = this.originalShowIf(item, value, form, currentValues, context);

But this fails if the original show If value is not a function but a string (for example: "false").

For fields initially not displayed in the grid the showIf has the value "false", see this snippet in the view field ftl:
            <#if !field.showInitiallyInGrid>
                , showIf: '${field.showInitiallyInGrid?string}'
            </#if>
and this is not a function, so treating it as a function call in the ob-view-main.js is wrong. The function definition in ob-view-main.js should be changed to take into account string values.

Steps To Reproduce

See for example the net list price in the sales order line tab.

Proposed Solution

Additional Information