Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021437Openbravo ERPB. User interfacepublic2012-08-23 13:442012-09-28 14:39
Reporterdbaz 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP16 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021437: The second/third/... lines of sales order do not appear when creating them by process buttons, if the grid is filtered by BP
DescriptionThe second/third/... lines of sales order do not appear when creating them by process buttons, if the grid is filtered by BP
Steps To ReproduceAs a Group Admin Role:
   Go to the Sales Order screen
   Filter the grid by Business Partner
   Create in grid a Sales Order for a different Business Partner
   Click on the "Copy from Order" button
   Select an order and click OK
Notice that you see the previous filtered Business Partners lines plus the new one
This is ok. Then:
   Create in grid again a new Sales Order for a different Business Partner
   Click on the "Copy from Order" button
   Select an order and click OK

Notice that just the last new added line is shown (plus the previous filtered Business Partners lines). It should show also the line created before.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00207223.0MP15 closed AugustoMauch Lines of purchase/sales order/invoice do not appear when creating them by process buttons, if the grid is filtered by BP 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-23 13:44dbazNew Issue
2012-08-23 13:44dbazAssigned To => AugustoMauch
2012-08-23 13:44dbazModules => Core
2012-08-23 13:45dbazRelationship addedrelated to 0020722
2012-08-23 13:46dbazNote Added: 0051502
2012-09-11 11:30AugustoMauchClosed by => dbaz
2012-09-11 11:33AugustoMauchNote Added: 0051985
2012-09-11 11:39hgbotCheckin
2012-09-11 11:39hgbotNote Added: 0051986
2012-09-11 11:39hgbotStatusnew => resolved
2012-09-11 11:39hgbotResolutionopen => fixed
2012-09-11 11:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b629f7cbfe32c335da14d978b46253380c7254d [^]
2012-09-13 00:09dbazNote Added: 0052045
2012-09-13 00:10dbazStatusresolved => new
2012-09-13 00:10dbazResolutionfixed => open
2012-09-13 00:10dbazStatusnew => scheduled
2012-09-13 00:10dbazfix_in_branch => pi
2012-09-13 12:39hgbotCheckin
2012-09-13 12:39hgbotNote Added: 0052054
2012-09-13 12:39hgbotStatusscheduled => resolved
2012-09-13 12:39hgbotResolutionopen => fixed
2012-09-13 12:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7b629f7cbfe32c335da14d978b46253380c7254d [^] => http://code.openbravo.com/erp/devel/pi/rev/e4be9ce5c5fad16eeb25a9b238989c4c153c1c52 [^]
2012-09-13 20:55dbazNote Added: 0052093
2012-09-13 20:55dbazStatusresolved => new
2012-09-13 20:55dbazResolutionfixed => open
2012-09-19 14:08dbazStatusnew => scheduled
2012-09-19 14:08dbazStatusscheduled => resolved
2012-09-19 14:08dbazResolutionopen => fixed
2012-09-19 14:10dbazNote Added: 0052227
2012-09-19 14:10dbazStatusresolved => closed
2012-09-19 14:11dbazFixed in Version => 3.0MP16
2012-09-26 14:16hgbotCheckin
2012-09-26 14:16hgbotNote Added: 0052630
2012-09-26 17:18hudsonbotCheckin
2012-09-26 17:18hudsonbotNote Added: 0052724
2012-09-26 17:19hudsonbotCheckin
2012-09-26 17:19hudsonbotNote Added: 0052740
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052911

Notes
(0051502)
dbaz   
2012-08-23 13:46   
Comment by RGO in issue 20722: In grid mode it works as intended. When the user inserts a new row, and saves it, it should be visible, even though the column filter would exclude it. A refresh is an deliberate action and will re-apply the filter.

In form mode however, no grid filters should be applied at all. The form mode does not need or want to know about underlying grid filters. So after having saved a new form, no filters are applied. When the form view is closed, filters will be applied to the grid.

For processes (regardless whether they are invoked from grid or form view, and this is the initial issue mentioned by ngarcia) the behavior should be as such that the newly created record is visible until a user-initiated refresh is done. So, it should behave as if a new row was inserted into the grid regularly.

Generic statement: any new or modified record (either by the user or by a process) must be visible after having saved, regardless of filters.
(0051985)
AugustoMauch   
2012-09-11 11:33   
Test plan:
- Open the Sales Order window
- Filter its header tab so that only a few rows remain
- Add some rows to the header
- Add one more row, and push the Copy from Order button to fill its lines.
- After the process returns, check in the grid that the current visible records are the ones that comply with the filter plus the ones that have been added after the last explicit refresh.
- Refresh the grid clicking the Refresh toolbar button. Only the rows that comply with the filter should be visible
(0051986)
hgbot   
2012-09-11 11:39   
Repository: erp/devel/pi
Changeset: 7b629f7cbfe32c335da14d978b46253380c7254d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Sep 11 11:37:19 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7b629f7cbfe32c335da14d978b46253380c7254d [^]

Fixes issue 21437: Recently added rows are visible after implicit refresh

Now, after returning from a process, not only the current record will be shown in the grid, but also all the records that have been added in that view after th
e last explicit refresh.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0052045)
dbaz   
2012-09-13 00:09   
I can still reproduce it following this flow:

* Filter "Organization" by "Norte"
* Create a new line setting "Organization": "F&B España - Region Sur" and "Business Partner": "Alimentos y Supermercados, S.A."
* Press SAVE toolbar button
* The created line is shown (everything is ok)
* Create a new line setting "Organization": "F&B España - Region Sur" and "Business Partner": "Alimentos y Supermercados, S.A."
* Press SAVE toolbar button
* The created line is shown (everything is ok)
* Press "Copy From Order" button
* Open the selector popup
* Search 1000009 (Doc No.)
* Select the one belongs to "Alimentos y Supermercados, S.A." and accept both popups (selector one and process one)
* The whole grid is refreshed and both recent created lines are not shown
(0052054)
hgbot   
2012-09-13 12:39   
Repository: erp/devel/pi
Changeset: e4be9ce5c5fad16eeb25a9b238989c4c153c1c52
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Sep 13 12:38:10 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e4be9ce5c5fad16eeb25a9b238989c4c153c1c52 [^]

Fixes issue 21437: Recently added rows are visible after implicit refresh

The part of the fix where the ids of the rows that were added after the last refresh was missing, now it has been included, and works both while saving in the form as with saving in the grid view.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0052093)
dbaz   
2012-09-13 20:55   
If you start adding records to the grid (with no one initially selected), all of them state at the end of the grid.

After doing the "Process" process, the previous added records remain, but they become reordered. Since the "Process" should be transparent, the previous added records should remain in the same position they were before.
(0052227)
dbaz   
2012-09-19 14:10   
Although the previous mentioned problem persists, issue closed since it is not critical.

Reviewed @ changeset: 17978 - 571b10dd474d
(0052630)
hgbot   
2012-09-26 14:16   
Repository: erp/devel/pi
Changeset: 22cb1b467fde7b0037ab26d75287fa30dbe68074
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Sep 26 14:15:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/22cb1b467fde7b0037ab26d75287fa30dbe68074 [^]

Fixes issue 21764: Only the proper records are shown after completing an order

The problem was caused by the fix of the issue 21437. Some logic was added to ensure that the recently created records were shown after completing a process, even if the do not comply with the filters. The problem was that this was done on a tab level, without taking into account that their parent record might not be the same.

This has been fixed, and only the child records of the current parent record are shown.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0052724)
hudsonbot   
2012-09-26 17:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0052740)
hudsonbot   
2012-09-26 17:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0052911)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test