Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021420Openbravo ERPB. User interfacepublic2012-08-22 20:512016-10-24 09:18
Reporterpjuvara 
Assigned Todbaz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP12.1 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2011-09-27
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc [^]
Triggers an Emergency PackNo
Summary0021420: [KS] CTRL+O does not consistently work
DescriptionCTRL+O is supposed to open the launcher.

It does not consistently work in the application. It seems that when you perform some actions, you loose focus and when you do CTRL+O opens the browser Open File dialog instead.
Steps To ReproduceAn example of when this happens.

Environment: Ubuntu 12.04 + Chrome 21.
In any window, edit an existing record in grid mode. Press CTRL+S to save.
Now press CTRL+O.

The save action "lost" the focus.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034057 closed NaroaIriarte Wrong Tabulation Order in form fields in Organization window 
has duplicate defect 0021381 closed dbaz Focus is lost after a record is saved in form view, resulting in incorrect operation of keyboards 
related to defect 0021546 closed AugustoMauch Regression in Form view when saving a record 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-22 20:51pjuvaraNew Issue
2012-08-22 20:51pjuvaraAssigned To => dbaz
2012-08-22 20:51pjuvaraWeb browser => Google Chrome
2012-08-22 20:51pjuvaraModules => Core
2012-08-30 02:43dbazNote Added: 0051660
2012-08-31 22:24dbazClosed by => mtaal
2012-08-31 22:24dbazWeb browserGoogle Chrome => Google Chrome
2012-08-31 22:24dbazRegression level => Production - Confirmed Stable
2012-08-31 22:24dbazRegression date => 2011-09-27
2012-08-31 22:24dbazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc [^]
2012-08-31 22:24dbazNote Added: 0051717
2012-08-31 22:27hgbotCheckin
2012-08-31 22:27hgbotNote Added: 0051718
2012-08-31 22:27hgbotStatusnew => resolved
2012-08-31 22:27hgbotResolutionopen => fixed
2012-08-31 22:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2e55c0d0da0d133a538c77b6380340f7b4de53c8 [^]
2012-09-03 07:05mtaalNote Added: 0051755
2012-09-03 07:05mtaalStatusresolved => closed
2012-09-03 07:05mtaalFixed in Version => 3.0MP15
2012-09-04 06:57mtaalNote Added: 0051793
2012-09-04 06:57mtaalStatusclosed => new
2012-09-04 06:57mtaalResolutionfixed => open
2012-09-04 06:57mtaalFixed in Version3.0MP15 =>
2012-09-04 13:10hgbotCheckin
2012-09-04 13:10hgbotNote Added: 0051814
2012-09-04 13:21dbazStatusnew => scheduled
2012-09-04 13:21dbazfix_in_branch => pi
2012-09-04 13:21dbazStatusscheduled => resolved
2012-09-04 13:21dbazResolutionopen => fixed
2012-09-04 13:23dbazNote Added: 0051816
2012-09-04 15:14AugustoMauchRelationship addedrelated to 0021546
2012-09-04 15:37mtaalNote Added: 0051819
2012-09-04 15:37mtaalStatusresolved => closed
2012-09-04 15:37mtaalFixed in Version => 3.0MP15
2012-09-05 11:11dbazRelationship addedhas duplicate 0021381
2012-09-26 17:14hgbotCheckin
2012-09-26 17:14hgbotNote Added: 0052646
2012-09-26 17:14hgbotStatusclosed => resolved
2012-09-26 17:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/2e55c0d0da0d133a538c77b6380340f7b4de53c8 [^] => http://code.openbravo.com/erp/devel/pi/rev/b7143de1a15ca6eabe66ee61d27695cec62df17b [^]
2012-09-26 17:14hgbotCheckin
2012-09-26 17:14hgbotNote Added: 0052647
2012-09-26 17:17hudsonbotCheckin
2012-09-26 17:17hudsonbotNote Added: 0052667
2012-09-26 17:18hudsonbotCheckin
2012-09-26 17:18hudsonbotNote Added: 0052676
2012-09-26 17:27gorka_gilStatusresolved => closed
2016-10-24 09:18NaroaIriarteRelationship addedrelated to 0034057

Notes
(0051660)
dbaz   
2012-08-30 02:43   
The problem root is that the focus is lost once the "Save" button action is done (it can be reproduced using the mouse or the keyboard)
(0051717)
dbaz   
2012-08-31 22:24   
The problem is that before the regression commit, the previous focused item was stored:

https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.201 [^]

and then in the save callback it was restored

https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.210 [^]

This logic was using "storeFocusItem" and "restoreFocusItem" that also don't exist anymore:

https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.263 [^]


In the fix a simplified version of this code is going to be introduced in order to recover the logic.

The fix risk is medium, and should be supervised by Martin Taal
(0051718)
hgbot   
2012-08-31 22:27   
Repository: erp/devel/pi
Changeset: 2e55c0d0da0d133a538c77b6380340f7b4de53c8
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Aug 31 22:27:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2e55c0d0da0d133a538c77b6380340f7b4de53c8 [^]

Fixed issue 21420: focus is set back in the form view after save action

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0051755)
mtaal   
2012-09-03 07:05   
Reviewed
(0051793)
mtaal   
2012-09-04 06:57   
I have seen the following behavior:

Go to message window
Do new in form
Enter a search key
Enter a value in the message text
Do ctrl-S

The record gets saved but the value in the message text is cleared. Note that pressing the save button works, so only the shortcut seems to give the problem.
(0051814)
hgbot   
2012-09-04 13:10   
Repository: erp/devel/pi
Changeset: 5492d5749d01b2fc25ba399063be8f3e78abf5c4
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Sep 04 13:09:31 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5492d5749d01b2fc25ba399063be8f3e78abf5c4 [^]

Related to issue 21420: 'saveRow' focus logic is now more solid

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0051816)
dbaz   
2012-09-04 13:23   
I cannot reproduce the test case provided by mtaal. Anyway, I have pushed an improvement to the fix, but it has nothing to see with the behavior that mtaal points.
(0051819)
mtaal   
2012-09-04 15:37   
Reviewed
(0052646)
hgbot   
2012-09-26 17:14   
Repository: erp/devel/pi
Changeset: b7143de1a15ca6eabe66ee61d27695cec62df17b
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Aug 31 22:27:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b7143de1a15ca6eabe66ee61d27695cec62df17b [^]

Fixed issue 21420: focus is set back in the form view after save action

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0052647)
hgbot   
2012-09-26 17:14   
Repository: erp/devel/pi
Changeset: 271836623f04a24d26dd6669d77813aba88e51b7
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Sep 04 13:09:31 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/271836623f04a24d26dd6669d77813aba88e51b7 [^]

Related to issue 21420: 'saveRow' focus logic is now more solid

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0052667)
hudsonbot   
2012-09-26 17:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0052676)
hudsonbot   
2012-09-26 17:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test