Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021415Openbravo ERP09. Financial managementpublic2012-08-22 13:252012-09-26 17:19
psarobe 
Sandrahuguet 
urgentmajoralways
closedfixed 
5
pi 
 
dmiguelez
Core
No
0021415: Ability to define a write-off limit by amount per financial account
Ability to define a write-off limit per financial account. To enable this feature there will be a preference that when it is defined (per user or role or org, etc) the user won't be able to write off certain amount above the limit defined.

For example if you defined a limit of 1€ and the invoice is 29.80 € and the customer pays you 29.50 you won't be able to select the option of write off.

Things to do:

* Window Financial account|| transactions tab:
- New field: Type write-off: Values (Percentage; Amount). The percentage value must be disabled since it's not going to be implemented
- New fields: write-off limit:
Both fields will have a display logic and will be shown after the preference is defined
*Create a new preference: Write-off limit

* Expected behaviour:
When the preference is defined:
- In all windows where the write-off can be performed if the user exceeds the limit defined the option to write-off will be shown but disabled with a new Label "Write off the difference (Above limit)"
- If the currency of the invoice/payment is different than the currency of the financial account then the system needs to take this into account and convert the amount into the currency of the FA and check the limit
- If the user select several invoices the limit to check will be the sum of all differences
N/A
No tags attached.
has duplicate feature request 0020012 closed mirurita Let the user configure the "Write off the difference" maximum amount 
related to defect 0021891 closed pramakrishnan Not needed section (Bank) in the Financial Account window 
Issue History
2012-08-22 13:25psarobeNew Issue
2012-08-22 13:25psarobeAssigned To => Sandrahuguet
2012-08-22 13:25psarobeModules => Core
2012-08-22 13:32psarobeSummaryAbility to define a write-off limit per financial account by amount => Ability to define a write-off limit by amount per financial account
2012-08-22 13:32psarobeDescription Updatedbug_revision_view_page.php?rev_id=3744#r3744
2012-08-22 13:44psarobeDescription Updatedbug_revision_view_page.php?rev_id=3745#r3745
2012-08-22 13:51psarobeDescription Updatedbug_revision_view_page.php?rev_id=3746#r3746
2012-08-29 10:31SandrahuguetStatusnew => scheduled
2012-08-29 10:31Sandrahuguetfix_in_branch => pi
2012-09-06 13:02SandrahuguetNote Added: 0051901
2012-09-06 13:19SandrahuguetNote Edited: 0051901bug_revision_view_page.php?bugnote_id=0051901#r3809
2012-09-06 13:28SandrahuguetNote Edited: 0051901bug_revision_view_page.php?bugnote_id=0051901#r3810
2012-09-06 13:34SandrahuguetNote Edited: 0051901bug_revision_view_page.php?bugnote_id=0051901#r3811
2012-09-06 13:38SandrahuguetNote Edited: 0051901bug_revision_view_page.php?bugnote_id=0051901#r3812
2012-09-06 13:42SandrahuguetNote Edited: 0051901bug_revision_view_page.php?bugnote_id=0051901#r3813
2012-09-14 20:22hgbotCheckin
2012-09-14 20:22hgbotNote Added: 0052147
2012-09-14 20:22hgbotStatusscheduled => resolved
2012-09-14 20:22hgbotResolutionopen => fixed
2012-09-14 20:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f7657cc77788d3a38c4c245736bfc87d746a79ce [^]
2012-09-14 20:22hgbotCheckin
2012-09-14 20:22hgbotNote Added: 0052148
2012-09-25 14:47thirumalaikRelationship addedrelated to 0020012
2012-09-25 15:57miruritaRelationship replacedhas duplicate 0020012
2012-09-26 10:39dmiguelezClosed by => dmiguelez
2012-09-26 10:39dmiguelezNote Added: 0052614
2012-09-26 10:39dmiguelezStatusresolved => closed
2012-09-26 17:19hudsonbotCheckin
2012-09-26 17:19hudsonbotNote Added: 0052765
2012-09-26 17:19hudsonbotCheckin
2012-09-26 17:19hudsonbotNote Added: 0052766
2012-10-09 16:10vmromanosRelationship addedrelated to 0021891

Notes
(0051901)
Sandrahuguet   
2012-09-06 13:02   
(edited on: 2012-09-06 13:42)
Test Plan:
As F&B Group admin
-Go to preference, create new preference
   ·Client: F&B International Group
   ·Organization: *
   ·Property: Not allow to change exchange rate and amount
   ·Value: Y
   ·Visible at client: F&B International Group
   ·Visible at organization: blank
   ·Visible at user: blank
   ·Visible at role: blank
   ·Window: blank
- Logout and login

-Go to Financial Account, select bank -account 1
  ·Tyoe write-off: Amount
  ·Write-off limit: 1

- Go to sales invoice, and create one:
   ·Organization: F&B US, Inc.
   ·Payment Method: Wire transfer
   ·Create line product: lager beer, quantity:100 and complete
   ·Click in Add Payment
   .Payment 263.5
   ·Notice that you can write off
   ·Payment 262.5
   ·Notice that you can not write off
- Go to purchase invoice
   ·Organization: F&B US, Inc.
   ·Business Partner: Be Soft Drinker, Inc.
   ·Payment Method: Wire transfer
   ·Create line product: plain water, quantity:1000 and complete
   ·Click in Add Payment
   .Payment 1019.5
   ·Notice that you can write off
   ·Payment 1018
   ·Notice that you can not write off
- Go to paymet in, and create one:
   ·Organization: F&B US, Inc.
   ·Payment Method: Wire transfer
   ·Paying from: USD - Bank - Account 1
   ·Select two payments, enter an amount to be paid and the difference must be greater than 1
   ·Notice that you can not write off
   ·Select two payments, enter an amount to be paid and the difference should be less or equal 1
   ·Notice that you can write off

- Go to paymet out, and create one:
   ·Organization: F&B US, Inc.
   ·Payment Method: Wire transfer
   ·Paying from: USD - Bank - Account 1
   ·Select two payments, enter an amount to be paid and the difference must be greater than 1
   ·Notice that you can not write off
   ·Select two payments, enter an amount to be paid and the difference should be less or equal 1
   ·Notice that you can write off
- Go to financial account: USD - Bank - Account 1 /payment method, select wire transfer
   ·Receive payments in multiple currencies=yes
   ·Make payments in multiple currencies=yes
   ·Add transaction/Add payment
   ·Currency:EUR
    ·Select one, enter an amount to be paid and the difference converted to USD must be greater than 1
   ·Notice that you can not write off
   ·Select one, enter an amount to be paid and the difference converted to USD should be less or equal 1
   ·Notice that you can write off
Wire Transfer
-Go to payment proposal
  ·Organization: F&B US, Inc.
  ·Paying from: USD - Bank - Account 1
  ·Payment method: Wire Transfer
  ·Click Select Expected payments
  ·Select one, enter an amount to be paid and the difference must be greater than 1 and check writeoff
  ·click in submit
  .The system shows: It is not allow to write off because you have exceeded the write off limit

As QA Admin
- Go to sales invoice, and create one:
   ·Organization: USA
   ·Business Partner: Customer A
   ·Payment Method: 1(USA)
   ·Create line product: tennis ball, quantity:100 and complete
   ·Click in Add Payment
   .Payment 449.30
   ·Notice that you can write off
   ·Payment 400.00
   ·Notice that you can write off

(0052147)
hgbot   
2012-09-14 20:22   
Repository: erp/devel/pi
Changeset: f7657cc77788d3a38c4c245736bfc87d746a79ce
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri Sep 14 20:14:05 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f7657cc77788d3a38c4c245736bfc87d746a79ce [^]

Fixed issue 21415 Ability to define a write-off limit

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.xml
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js
M src-db/database/model/tables/FIN_FINANCIAL_ACCOUNT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_MultiCurrency.java
---
(0052148)
hgbot   
2012-09-14 20:22   
Repository: erp/devel/pi
Changeset: 1922c7ff8ac1efb2cffd515cecab61da22a16e58
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Sep 14 13:52:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1922c7ff8ac1efb2cffd515cecab61da22a16e58 [^]

Related to issue 21415 Ability to define a write-off limit
Ability to define a write-off limit by amount per financial account
Commit Payment Proposal

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0052614)
dmiguelez   
2012-09-26 10:39   
Code Review + Testing OK
(0052765)
hudsonbot   
2012-09-26 17:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0052766)
hudsonbot   
2012-09-26 17:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test