Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0021382 | Openbravo ERP | B. User interface | public | 2012-08-19 01:10 | 2012-09-01 01:02 |
|
| Reporter | pjuvara | |
| Assigned To | dbaz | |
| Priority | normal | Severity | major | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 3.0MP12.1 | |
| Target Version | | Fixed in Version | 3.0MP15 | |
| Merge Request Status | |
| Review Assigned To | guilleaer |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | Production - QA Approved |
| Regression date | 2012-05-26 |
| Regression introduced in release | |
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/f060d41ab218 [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0021382: [KS] ESC key shortcut does not cancel edit in grid mode |
| Description | The ESC key is supposed to cancel edit in grid mode.
It does not work anymore (I am pretty sure it used to work).
It still works in form mode. |
| Steps To Reproduce | In any window, start editing in grid view and press esc. |
| Proposed Solution | |
| Additional Information | |
| Tags | Coworking |
| Relationships | | has duplicate | defect | 0020435 | | closed | dbaz | Escape key press does not cancel line edit |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-08-19 01:10 | pjuvara | New Issue | |
| 2012-08-19 01:10 | pjuvara | Assigned To | => dbaz |
| 2012-08-19 01:10 | pjuvara | Modules | => Core |
| 2012-08-19 01:10 | pjuvara | Tag Attached: Coworking | |
| 2012-08-19 02:11 | pjuvara | Closed by | => pjuvara |
| 2012-08-19 02:11 | pjuvara | Note Added: 0051346 | |
| 2012-08-19 02:11 | pjuvara | Status | new => closed |
| 2012-08-19 02:11 | pjuvara | Resolution | open => unable to reproduce |
| 2012-08-22 20:00 | pjuvara | Severity | critical => major |
| 2012-08-22 20:00 | pjuvara | Summary | ESC key shortcut does not cancel edit in grid mode => [KS] ESC key shortcut does not cancel edit in grid mode |
| 2012-08-22 20:02 | pjuvara | Note Added: 0051475 | |
| 2012-08-22 20:02 | pjuvara | Status | closed => new |
| 2012-08-22 20:02 | pjuvara | Resolution | unable to reproduce => open |
| 2012-08-22 20:03 | pjuvara | Reproducibility | always => sometimes |
| 2012-08-28 18:36 | dbaz | Closed by | pjuvara => guilleaer |
| 2012-08-28 18:36 | dbaz | Regression level | => Production - QA Approved |
| 2012-08-28 18:36 | dbaz | Regression date | => 2012-05-26 |
| 2012-08-28 18:36 | dbaz | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/f060d41ab218 [^] |
| 2012-08-28 18:37 | dbaz | Note Added: 0051605 | |
| 2012-08-28 18:41 | hgbot | Checkin | |
| 2012-08-28 18:41 | hgbot | Note Added: 0051606 | |
| 2012-08-28 18:41 | hgbot | Status | new => resolved |
| 2012-08-28 18:41 | hgbot | Resolution | open => fixed |
| 2012-08-28 18:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/155025bf029e2968a65b23686c5db9b02766a599 [^] |
| 2012-08-29 18:31 | guilleaer | Note Added: 0051652 | |
| 2012-08-29 18:31 | guilleaer | Status | resolved => closed |
| 2012-08-29 18:31 | guilleaer | Fixed in Version | => 3.0MP15 |
| 2012-08-30 00:43 | dbaz | Relationship added | has duplicate 0020435 |
| 2012-09-01 01:02 | hudsonbot | Checkin | |
| 2012-09-01 01:02 | hudsonbot | Note Added: 0051721 | |
|
Notes |
|
|
|
|
|
|
|
It now started reproducing again.
Envrionment: Ubuntu 12.10 + Chrome 21
Window: Account Tree
To reproduce:
1) Navigate to Account Tree window
2) Select a chart of account in the header
3) Navigate to Element tab
4) Edit in grid
5) Press ESC - nothing happens |
|
|
|
(0051605)
|
|
dbaz
|
|
2012-08-28 18:37
|
|
|
The fix is medium risk. A keyboard shortcuts complete test is needed (Pablo Lujan is working on it) |
|
|
|
(0051606)
|
|
hgbot
|
|
2012-08-28 18:41
|
|
Repository: erp/devel/pi
Changeset: 155025bf029e2968a65b23686c5db9b02766a599
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Aug 28 18:40:44 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/155025bf029e2968a65b23686c5db9b02766a599 [^]
Fixed issue 21382: [KS] 'ESC' key now works ok in grid view
(it cancels the row edit)
---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_PREFERENCE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
|
|
|
|
|
|
Code reviewed and tested in pi@19952d22eb0a |
|
|
|
|
|