Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021379Openbravo ERP09. Financial managementpublic2012-08-18 18:332012-08-30 13:05
Reporterpjuvara 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP12.1 
Target Version3.0MP15Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021379: Business partner selector on G/L journal lines should not restrict to customers only
DescriptionOn a G/L Journal line you can specify a business partner as a dimension.

Since this is a manual accounting entry, typically done to create an adjustment, it is not legitimate to restrict which business partners are selected.

There are many cases where a supplier or an employee (which are not customers) can be used as references in a manual G/L journal
Steps To ReproduceCreate manual G/L Journal batch, header and line.

On line, try to pick a business partner that has customer flag unchecked.
Proposed SolutionAllow all business partners
Additional Information
TagsCoworking
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-18 18:33pjuvaraNew Issue
2012-08-18 18:33pjuvaraAssigned To => mirurita
2012-08-18 18:33pjuvaraModules => Core
2012-08-18 18:33pjuvaraTag Attached: cow
2012-08-18 18:33pjuvaraTag Detached: cow
2012-08-18 18:33pjuvaraTag Attached: Coworking
2012-08-20 11:35jonalegriaesarteAssigned Tomirurita => ioritzCia
2012-08-20 11:35jonalegriaesarteTarget Version => 3.0MP15
2012-08-20 13:12vmromanosStatusnew => scheduled
2012-08-20 13:12vmromanosAssigned ToioritzCia => vmromanos
2012-08-20 13:12vmromanosfix_in_branch => pi
2012-08-20 14:01vmromanosNote Added: 0051378
2012-08-21 09:52hgbotCheckin
2012-08-21 09:52hgbotNote Added: 0051417
2012-08-21 09:52hgbotStatusscheduled => resolved
2012-08-21 09:52hgbotResolutionopen => fixed
2012-08-21 09:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6431b810b73f95aa96d012bd08d19a289a9705a2 [^]
2012-08-30 13:05SandrahuguetNote Added: 0051680
2012-08-30 13:05SandrahuguetStatusresolved => closed

Notes
(0051378)
vmromanos   
2012-08-20 14:01   
Test plan I:
1. Go to G/L Journal window
2. Create a new batch, header and line
3. Inside the line tab, open the business partner selector and ensure all the business partners are displayed, i.e., no default filter is set for neither Customer nor Vendor columns.

Test plan II:
1. Go to the Purchase Invoice window (example of purchase window) and create a new record
2. Open the business partner selector.
3. Ensure the Vendor flag is set to Yes by default
4. Ensure the Customer flag is set to No by default

Test plan III:
1. Go to the Sales Invoice window (example of sales window) and create a new record
2. Open the business partner selector.
3. Ensure the Customer flag is set to Yes by default
4. Ensure the Vendor flag is set to No by default
(0051417)
hgbot   
2012-08-21 09:52   
Repository: erp/devel/pi
Changeset: 6431b810b73f95aa96d012bd08d19a289a9705a2
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Aug 21 09:50:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6431b810b73f95aa96d012bd08d19a289a9705a2 [^]

Fixed bug 21379: Business partner selector on G/L journal lines

The G/L journal window is now declared as Sales Transaction='N'
Inside the Business Partner selector, the vendor default expression
takes into account the special scenario for the G/L Journal window

---
M src-db/database/sourcedata/AD_WINDOW.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
---
(0051680)
Sandrahuguet   
2012-08-30 13:05   
Code review + testing OK