Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021375Openbravo ERPA. Platformpublic2012-08-17 13:492012-08-27 07:59
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP15Fixed in Version3.0MP15 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket16605
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021375: The line gross amount of a SO is not correctly calculated if it is not shown in grid view
DescriptionThe line gross amount of a SO is not correctly calculated if it is not shown in grid view and the price list includes tax.
Steps To ReproduceAs group admin role:
   Go to Price List window and select the Price includes Tax checkbox for "Tarifa de ventas"
   Create a new Sales Order with that Price List
   Check that the "Line Gross Amount" is not shown in grid view
   Add a line in grid mode and save it after including the Ordered Quantity (without changing the focus from it).
   Notice that the Line Gross Amount value is incorrect and therefore, the total gross amount, tax amount (tax tab)...

   Note: if the field is shown or you change the focus from the quantity field it works properly.
   
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-17 13:49ngarciaNew Issue
2012-08-17 13:49ngarciaAssigned To => marvintm
2012-08-17 13:49ngarciaModules => Core
2012-08-17 13:49ngarciaOBNetwork customer => Yes
2012-08-17 13:49ngarciaSupport ticket => 16605
2012-08-17 13:49ngarciaResolution time => 1348178400
2012-08-17 13:50ngarciaIssue Monitored: networkb
2012-08-18 15:21heccamIssue Monitored: heccam
2012-08-20 11:23AugustoMauchAssigned Tomarvintm => AugustoMauch
2012-08-20 12:04hgbotCheckin
2012-08-20 12:04hgbotNote Added: 0051362
2012-08-20 12:04hgbotStatusnew => resolved
2012-08-20 12:04hgbotResolutionopen => fixed
2012-08-20 12:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/de48663576d7a94a8e8d581f070d83b83859309b [^]
2012-08-20 12:04AugustoMauchNote Added: 0051363
2012-08-20 12:04AugustoMauchStatusresolved => new
2012-08-20 12:04AugustoMauchResolutionfixed => open
2012-08-20 12:05AugustoMauchClosed by => marvintm
2012-08-20 12:05AugustoMauchStatusnew => scheduled
2012-08-20 12:05AugustoMauchfix_in_branch => pi
2012-08-20 12:05AugustoMauchStatusscheduled => resolved
2012-08-20 12:05AugustoMauchResolutionopen => fixed
2012-08-24 08:18marvintmNote Added: 0051519
2012-08-24 08:18marvintmStatusresolved => new
2012-08-24 08:18marvintmResolutionfixed => open
2012-08-26 23:52hgbotCheckin
2012-08-26 23:52hgbotNote Added: 0051551
2012-08-26 23:52hgbotStatusnew => resolved
2012-08-26 23:52hgbotResolutionopen => fixed
2012-08-26 23:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/de48663576d7a94a8e8d581f070d83b83859309b [^] => http://code.openbravo.com/erp/devel/pi/rev/818b602af1d99f3b762228aea4db1a915edeec50 [^]
2012-08-27 07:59marvintmStatusresolved => closed
2012-08-27 07:59marvintmFixed in Version => 3.0MP15

Notes
(0051362)
hgbot   
2012-08-20 12:04   
Repository: erp/devel/pi
Changeset: de48663576d7a94a8e8d581f070d83b83859309b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Aug 20 12:02:56 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/de48663576d7a94a8e8d581f070d83b83859309b [^]

Fixes issue 21375: Field is updated even if not visible in grid

When a row is being edited in the grid, if there is a callout and the changed column is not displayed in the grid, its value was not being updated.

This has been fixed by modifying the setItemValue function of ob-view-form, so that it now takes into account that a field not being shown in the grid might be updated.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0051363)
AugustoMauch   
2012-08-20 12:04   
Issue reopened to set Closed by field
(0051519)
marvintm   
2012-08-24 08:18   
I can still partially reproduce the problem, if I do the following:

- Verify that the Line Gross Amount column is not shown in grid
- Create a line in grid editing view.
- Pick a product
- Tab to the quantity field.
- Type a different quantity, and without moving the focus out of the field, press CTRL+S

The Line Net Amount field will be correctly calculated, but the Line Gross Amount will still be wrong (this can be verified by viewing the record in form view).
(0051551)
hgbot   
2012-08-26 23:52   
Repository: erp/devel/pi
Changeset: 818b602af1d99f3b762228aea4db1a915edeec50
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Sun Aug 26 23:51:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/818b602af1d99f3b762228aea4db1a915edeec50 [^]

Fixes issue 21375: Line Net Amount saved properly

When saving in the grid a record just after modifying a dynamic column, the hidden columns were not being properly saved. Now when the results of the callbacks are applied, the hidden fields are also considered.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---