|
Notes |
|
|
|
|
I have not been able to reproduce the issue neigher in pi, nor in main nor in demo. |
|
|
|
|
|
Steps to reproduce updated. Notice that the problem appears if the user shows a new column in the grid, after create a new line in the grid. |
|
|
|
|
|
This issue is only reproducible when the user adds or removes a column while editing a new record. If the record has been saved and it is being edited again, the error will not happen. |
|
|
|
(0051505)
|
|
hgbot
|
|
2012-08-23 14:28
|
|
Repository: erp/devel/pi
Changeset: b71a7f9c8a25584de7f67f7300de135ad9a954eb
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 23 14:24:46 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b71a7f9c8a25584de7f67f7300de135ad9a954eb [^]
Fixes issue 21352: Changing the shown fields while editing the grid is possible
Due to a change in smartclient, it was not possible to hide or show a field in the grid while editing a row. This happened because when a field was shown or hided, the edit values of the record were being deleted. This edit values were being used to retrieve all the record values in order to send them the the FIC. This deleted values were not being restored ever.
Now, to fix this, the edit values of the grid are saved when hiding or showing fields. If there is call to doChangeFICCall caused by this, the saved edit values will be used:
record = isc.addProperties({}, this.viewGrid.getRecord(rowNum), this.viewGrid.getEditValues(rowNum), this.viewGrid._savedEditValues);
This was only reproducible while editing new rows because saved rows had all the properties in the own record (this.viewGrid.getRecord()), so it did not matter that they were being deleted from the edit values.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
|
New case to reproduce the issue:
Case 3: the line number is duplicated
- Create a new sales order
- Create a new line in grid view
- Lines: show the "net list price" column in grid view
- Select a product.
- Use tab key to go to "Net list price" field
- Change it
- Enter key
- The sequence number in the new line is duplicated
Notice that the issue always appears when the user changes the value in the column showed dynamically. |
|
|
|
|
This happens when a line is created and the enter key is pressed after modifying a field that launches a callout, while the focus is still in that field.
The line number of the new line is not initialized properly because the call to the FIC in new mode is done before saving the current record. |
|
|
|
|
If instead of pressing the Enter key the Insert Row toolbar button is pressed, the line number is properly initialized. This is the order in which the events occur in this case:
- The FIC is called in CHANGE mode
- The current line is saved
- The FIC is called in NEW mode. |
|
|
|
(0051620)
|
|
mtaal
|
|
2012-08-29 11:52
|
|
The solution is that opening the new line (and calling the FIC for that line) should be done after the save of the current line returns.
Smartclient has a property for this: waitForSave on the listgrid but this will make grid editing slower in other cases as the next row can't be edited before the save of the previous one has been done.
See the smartclient ListGrid._saveAndStartEditing method for more information. |
|
|
|
(0051628)
|
|
hgbot
|
|
2012-08-29 13:05
|
|
Repository: erp/devel/pi
Changeset: d500176d7771e75ea21f5fbe34c90e296110b8ab
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Aug 29 13:05:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d500176d7771e75ea21f5fbe34c90e296110b8ab [^]
Fixes issue 21352: Enter key duplicates the line number in sales order line
Enable waitForSave so that save is done before initial FIC of next edit line. Make sure that the validation of number items sets the correct value.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
|
|
|
|
|
I don't think it is working correctly yet.
I do the following:
- I create a sales order line
- I select a product
- I add a column to the grid (net list price)
- I tab to the Net List Price field, and change its value.
- I press enter
In this case, the record is saved, and a new record is created. However, when I go to the saved record, I see that the value for the Net List Price is null, so it seems this value is not saved for some reason. |
|
|
|
|
|
|
|
(0051765)
|
|
mtaal
|
|
2012-09-03 13:15
|
|
|
|
|
(0051766)
|
|
mtaal
|
|
2012-09-03 13:16
|
|
|
|
|
|
|
|
|
(0052279)
|
|
hgbot
|
|
2012-09-21 12:36
|
|
Repository: erp/devel/pi
Changeset: 4457b10d26e6686d742c609407d3cb2c3740760e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 21 12:33:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4457b10d26e6686d742c609407d3cb2c3740760e [^]
Fixes issue 21709: Tab title is updated when a record is saved in the grid view
The fix of the issue 21352 caused the updateTabTitle function to be executed when the grid was still in edit mode, so the '*' in the tab title remained. Removing the code that caused this issue was not possible, because then the original issue was reproducible. Instead, an extra call to updateTabTitle is done when the records exists the edit mode.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
|
|
|
|
(0052664)
|
|
hgbot
|
|
2012-09-26 17:16
|
|
Repository: erp/devel/pi
Changeset: a975007ee08356357dc2737b24e59c1a2e544ce0
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 21 12:33:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a975007ee08356357dc2737b24e59c1a2e544ce0 [^]
Fixes issue 21709: Tab title is updated when a record is saved in the grid view
The fix of the issue 21352 caused the updateTabTitle function to be executed when the grid was still in edit mode, so the '*' in the tab title remained. Removing the code that caused this issue was not possible, because then the original issue was reproducible. Instead, an extra call to updateTabTitle is done when the records exists the edit mode.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
|
|
|
|
|
|