Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021352Openbravo ERPA. Platformpublic2012-08-13 10:362012-09-28 14:38
Reporterjonalegriaesarte 
Assigned Tomtaal 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP13 
Target Version3.0MP15Fixed in Version3.0MP15 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket16541
Regression levelProduction - Confirmed Stable
Regression date2012-05-13
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8f6f2842e1f0 [^]
Triggers an Emergency PackNo
Summary0021352: Enter key duplicates the line number in sales order line
DescriptionEnter key duplicates the line number in sales order line
Steps To ReproduceCase 1: the product selector does not show products
- Create a new sales order
- Create a new line in grid view
- Lines: show the "net list price" column in grid view
- Select a product. The list is empty

Case 2: the line number is duplicated
- Create a new sales order
- Create a new line in grid view
- Select a product.
- Lines: show the "net list price" column in grid view
- Use tab key to go to "Net list price" field
- Enter key
- The sequence number in the new line is duplicated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0021530 closed shankarb Grid editing: columns with displaylogic do not work correctly 
related to defect 00217093.0MP16 closed AugustoMauch After saving a change in the grid, the tab title do not remove the '*' until another row is selected 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-13 10:36jonalegriaesarteNew Issue
2012-08-13 10:36jonalegriaesarteAssigned To => alostale
2012-08-13 10:36jonalegriaesarteModules => Core
2012-08-13 10:36jonalegriaesarteOBNetwork customer => Yes
2012-08-13 10:36jonalegriaesarteSupport ticket => 16541
2012-08-13 10:36jonalegriaesarteRegression level => Production - QA Approved
2012-08-13 13:04AugustoMauchNote Added: 0051255
2012-08-13 13:04AugustoMauchStatusnew => feedback
2012-08-14 10:16jonalegriaesarteNote Added: 0051276
2012-08-14 10:16jonalegriaesarteStatusfeedback => new
2012-08-14 10:16jonalegriaesarteSummaryEnter key duplicates the sequence number in sales order line => Enter key duplicates the line number in sales order line
2012-08-14 10:16jonalegriaesarteDescription Updatedbug_revision_view_page.php?rev_id=3717#r3717
2012-08-14 10:16jonalegriaesarteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3719#r3719
2012-08-14 10:53AugustoMauchRegression levelProduction - QA Approved => Production - Confirmed Stable
2012-08-14 10:53AugustoMauchRegression date => 2012-02-09
2012-08-14 10:53AugustoMauchRegression introduced by commit => https://issues.openbravo.com/view.php?id=19165 [^]
2012-08-14 11:51AugustoMauchRegression introduced by commithttps://issues.openbravo.com/view.php?id=19165 [^] => https://code.openbravo.com/erp/devel/pi/rev/634e843d6f22049c10eb8a7fc62661668e3c7669 [^]
2012-08-14 13:11AugustoMauchRelationship addedrelated to 0020722
2012-08-14 13:13AugustoMauchRelationship deletedrelated to 0020722
2012-08-14 14:45AugustoMauchStatusnew => scheduled
2012-08-14 14:45AugustoMauchfix_in_branch => pi
2012-08-14 14:45AugustoMauchAssigned Toalostale => AugustoMauch
2012-08-21 09:38heccamIssue Monitored: heccam
2012-08-22 17:36AugustoMauchNote Added: 0051474
2012-08-23 14:27AugustoMauchClosed by => marvintm
2012-08-23 14:27AugustoMauchfix_in_branchpi =>
2012-08-23 14:28hgbotCheckin
2012-08-23 14:28hgbotNote Added: 0051505
2012-08-23 14:28hgbotStatusscheduled => resolved
2012-08-23 14:28hgbotResolutionopen => fixed
2012-08-23 14:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b71a7f9c8a25584de7f67f7300de135ad9a954eb [^]
2012-08-23 14:30AugustoMauchStatusresolved => new
2012-08-23 14:30AugustoMauchResolutionfixed => open
2012-08-23 14:33AugustoMauchRegression date2012-02-09 => 2012-04-16
2012-08-23 14:33AugustoMauchRegression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/634e843d6f22049c10eb8a7fc62661668e3c7669 [^] => https://code.openbravo.com/erp/devel/pi/rev/54d4694d51fc [^]
2012-08-23 14:33AugustoMauchStatusnew => scheduled
2012-08-23 14:33AugustoMauchfix_in_branch => pi
2012-08-23 14:33AugustoMauchStatusscheduled => resolved
2012-08-23 14:33AugustoMauchResolutionopen => fixed
2012-08-24 08:09marvintmStatusresolved => closed
2012-08-24 08:09marvintmFixed in Version => 3.0MP15
2012-08-24 17:54jonalegriaesarteNote Added: 0051547
2012-08-24 17:54jonalegriaesarteStatusclosed => new
2012-08-24 17:54jonalegriaesarteResolutionfixed => open
2012-08-24 17:54jonalegriaesarteFixed in Version3.0MP15 =>
2012-08-24 19:50AugustoMauchNote Added: 0051549
2012-08-24 19:56AugustoMauchNote Added: 0051550
2012-08-26 20:13AugustoMauchAssigned ToAugustoMauch => marvintm
2012-08-26 20:14AugustoMauchRegression date2012-04-16 => 2012-05-13
2012-08-26 20:14AugustoMauchRegression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/54d4694d51fc [^] => https://code.openbravo.com/erp/devel/pi/rev/8f6f2842e1f0 [^]
2012-08-26 20:14AugustoMauchfix_in_branchpi =>
2012-08-29 11:16marvintmAssigned Tomarvintm => mtaal
2012-08-29 11:52mtaalNote Added: 0051620
2012-08-29 13:05hgbotCheckin
2012-08-29 13:05hgbotNote Added: 0051628
2012-08-29 13:05hgbotStatusnew => resolved
2012-08-29 13:05hgbotResolutionopen => fixed
2012-08-29 13:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b71a7f9c8a25584de7f67f7300de135ad9a954eb [^] => http://code.openbravo.com/erp/devel/pi/rev/d500176d7771e75ea21f5fbe34c90e296110b8ab [^]
2012-08-29 16:33marvintmNote Added: 0051638
2012-08-29 16:33marvintmStatusresolved => new
2012-08-29 16:33marvintmResolutionfixed => open
2012-09-01 01:02hudsonbotCheckin
2012-09-01 01:02hudsonbotNote Added: 0051734
2012-09-03 13:10mtaalRelationship addedrelated to 0021530
2012-09-03 13:15mtaalStatusnew => scheduled
2012-09-03 13:15mtaalNote Added: 0051765
2012-09-03 13:15mtaalfix_in_branch => pi
2012-09-03 13:16mtaalNote Added: 0051766
2012-09-03 13:16mtaalStatusscheduled => resolved
2012-09-03 13:16mtaalFixed in Version => 3.0MP15
2012-09-03 13:16mtaalResolutionopen => fixed
2012-09-03 13:19marvintmNote Added: 0051767
2012-09-03 13:19marvintmStatusresolved => closed
2012-09-21 12:29AugustoMauchRelationship addedrelated to 0021709
2012-09-21 12:36hgbotCheckin
2012-09-21 12:36hgbotNote Added: 0052279
2012-09-26 17:16hgbotCheckin
2012-09-26 17:16hgbotNote Added: 0052664
2012-09-28 14:38hudsonbotCheckin
2012-09-28 14:38hudsonbotNote Added: 0052878

Notes
(0051255)
AugustoMauch   
2012-08-13 13:04   
I have not been able to reproduce the issue neigher in pi, nor in main nor in demo.
(0051276)
jonalegriaesarte   
2012-08-14 10:16   
Steps to reproduce updated. Notice that the problem appears if the user shows a new column in the grid, after create a new line in the grid.
(0051474)
AugustoMauch   
2012-08-22 17:36   
This issue is only reproducible when the user adds or removes a column while editing a new record. If the record has been saved and it is being edited again, the error will not happen.
(0051505)
hgbot   
2012-08-23 14:28   
Repository: erp/devel/pi
Changeset: b71a7f9c8a25584de7f67f7300de135ad9a954eb
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 23 14:24:46 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b71a7f9c8a25584de7f67f7300de135ad9a954eb [^]

Fixes issue 21352: Changing the shown fields while editing the grid is possible

Due to a change in smartclient, it was not possible to hide or show a field in the grid while editing a row. This happened because when a field was shown or hided, the edit values of the record were being deleted. This edit values were being used to retrieve all the record values in order to send them the the FIC. This deleted values were not being restored ever.

Now, to fix this, the edit values of the grid are saved when hiding or showing fields. If there is call to doChangeFICCall caused by this, the saved edit values will be used:

record = isc.addProperties({}, this.viewGrid.getRecord(rowNum), this.viewGrid.getEditValues(rowNum), this.viewGrid._savedEditValues);

This was only reproducible while editing new rows because saved rows had all the properties in the own record (this.viewGrid.getRecord()), so it did not matter that they were being deleted from the edit values.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0051547)
jonalegriaesarte   
2012-08-24 17:54   
New case to reproduce the issue:
Case 3: the line number is duplicated
- Create a new sales order
- Create a new line in grid view
- Lines: show the "net list price" column in grid view
- Select a product.
- Use tab key to go to "Net list price" field
- Change it
- Enter key
- The sequence number in the new line is duplicated

Notice that the issue always appears when the user changes the value in the column showed dynamically.
(0051549)
AugustoMauch   
2012-08-24 19:50   
This happens when a line is created and the enter key is pressed after modifying a field that launches a callout, while the focus is still in that field.

The line number of the new line is not initialized properly because the call to the FIC in new mode is done before saving the current record.
(0051550)
AugustoMauch   
2012-08-24 19:56   
If instead of pressing the Enter key the Insert Row toolbar button is pressed, the line number is properly initialized. This is the order in which the events occur in this case:
- The FIC is called in CHANGE mode
- The current line is saved
- The FIC is called in NEW mode.
(0051620)
mtaal   
2012-08-29 11:52   
The solution is that opening the new line (and calling the FIC for that line) should be done after the save of the current line returns.
Smartclient has a property for this: waitForSave on the listgrid but this will make grid editing slower in other cases as the next row can't be edited before the save of the previous one has been done.
See the smartclient ListGrid._saveAndStartEditing method for more information.
(0051628)
hgbot   
2012-08-29 13:05   
Repository: erp/devel/pi
Changeset: d500176d7771e75ea21f5fbe34c90e296110b8ab
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Aug 29 13:05:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d500176d7771e75ea21f5fbe34c90e296110b8ab [^]

Fixes issue 21352: Enter key duplicates the line number in sales order line
Enable waitForSave so that save is done before initial FIC of next edit line. Make sure that the validation of number items sets the correct value.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0051638)
marvintm   
2012-08-29 16:33   
I don't think it is working correctly yet.

I do the following:
- I create a sales order line
- I select a product
- I add a column to the grid (net list price)
- I tab to the Net List Price field, and change its value.
- I press enter

In this case, the record is saved, and a new record is created. However, when I go to the saved record, I see that the value for the Net List Price is null, so it seems this value is not saved for some reason.
(0051734)
hudsonbot   
2012-09-01 01:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05b3ea484705 [^]

Maturity status: Test
(0051765)
mtaal   
2012-09-03 13:15   
scheduled...
(0051766)
mtaal   
2012-09-03 13:16   
Resolved
(0051767)
marvintm   
2012-09-03 13:19   
There is a separate issue, related to how the non-initially displayed fields in the grid, but the initial problem reported in this issue has been fixed:

https://issues.openbravo.com/view.php?id=21533 [^]
https://issues.openbravo.com/view.php?id=21530 [^]
(0052279)
hgbot   
2012-09-21 12:36   
Repository: erp/devel/pi
Changeset: 4457b10d26e6686d742c609407d3cb2c3740760e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 21 12:33:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4457b10d26e6686d742c609407d3cb2c3740760e [^]

Fixes issue 21709: Tab title is updated when a record is saved in the grid view

The fix of the issue 21352 caused the updateTabTitle function to be executed when the grid was still in edit mode, so the '*' in the tab title remained. Removing the code that caused this issue was not possible, because then the original issue was reproducible. Instead, an extra call to updateTabTitle is done when the records exists the edit mode.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0052664)
hgbot   
2012-09-26 17:16   
Repository: erp/devel/pi
Changeset: a975007ee08356357dc2737b24e59c1a2e544ce0
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 21 12:33:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a975007ee08356357dc2737b24e59c1a2e544ce0 [^]

Fixes issue 21709: Tab title is updated when a record is saved in the grid view

The fix of the issue 21352 caused the updateTabTitle function to be executed when the grid was still in edit mode, so the '*' in the tab title remained. Removing the code that caused this issue was not possible, because then the original issue was reproducible. Instead, an extra call to updateTabTitle is done when the records exists the edit mode.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0052878)
hudsonbot   
2012-09-28 14:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test