Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021344Openbravo ERP00. Application dictionarypublic2012-08-10 09:302012-08-17 10:36
Reportergorkaion 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionGentoo
Product Versionpi 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021344: Fields shown in status bar should be read only in the grid
DescriptionWhen a field is shown in the status bar it is not editable in the form view. If this field is shown in the grid it should also be read only.

These fields are always read only in the form view, but when they are shown in the grid this property has to be set manually using the read only flag.

The fields that are shown in the status do not need to have the is displayed flag set to true.

The problem is that the read only flag has a display logic so it is hidden when the is displayed flag is set to false.
Steps To ReproduceAs System Administrator
Go to Windows, Tabs and Fields window.
Edit the fields of 'Financial Account' window, 'Reconciliation' tab.

check that 'Starting Balance', 'Ending Balance' and 'Status' are:
* shown in status bar
* shown in relation
* displayed false

The read only flag is hidden.

As admin role.
Go to Financial Account window. Select 'Bank Account 1'
Go to Reconciliations tab. Try to edit the record in the grid. The fields mentioned are editable. Open the record in form view and notice that those fields are in status bar and therefore not editable.
Proposed SolutionPreferred solution. Consider fields shown in status bar as Read Only. So even in the grid are not editable.

Alternate solution. Show the read only flag also when the show in relation flag is true. Make a callout to automatically set to read only a field when the show in status bar is set to true.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00213453.0MP14 closed gorkaion Validated property of a costing rule editable in grid view. 
related to defect 0021346 closed mirurita Some fields shown in status bar are editable in grid view 
related to defect 0021377 closed naiaramartinez Current balance is not saved when a new Financial Account is defined 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-10 09:30gorkaionNew Issue
2012-08-10 09:30gorkaionAssigned To => alostale
2012-08-10 09:30gorkaionModules => Core
2012-08-10 09:34gorkaionRelationship addedrelated to 0021345
2012-08-10 09:39gorkaionRelationship addedrelated to 0021346
2012-08-10 10:38gorkaionSummaryRead only flag hidden for fields that are shown in relation => Fields shown in status bar should be read only in the grid
2012-08-10 10:38gorkaionDescription Updatedbug_revision_view_page.php?rev_id=3713#r3713
2012-08-10 10:38gorkaionProposed Solution updated
2012-08-13 14:55AugustoMauchAssigned Toalostale => AugustoMauch
2012-08-16 09:30hgbotCheckin
2012-08-16 09:30hgbotNote Added: 0051313
2012-08-16 09:30hgbotStatusnew => resolved
2012-08-16 09:30hgbotResolutionopen => fixed
2012-08-16 09:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/54ee31faa732d094c7062630ce4d0d0b0b3792b0 [^]
2012-08-17 10:36AugustoMauchClosed by => AugustoMauch
2012-08-17 10:36AugustoMauchNote Added: 0051336
2012-08-17 10:36AugustoMauchStatusresolved => closed
2012-08-17 10:36AugustoMauchFixed in Version => 3.0MP15
2012-08-24 13:31naiaramartinezRelationship addedrelated to 0021377

Notes
(0051313)
hgbot   
2012-08-16 09:30   
Repository: erp/devel/pi
Changeset: 54ee31faa732d094c7062630ce4d0d0b0b3792b0
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Aug 14 17:12:30 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/54ee31faa732d094c7062630ce4d0d0b0b3792b0 [^]

Fixes Issue 21344 : Defaulting Read-Only for Status Bar fields.

Set 'Read-Only' flag as 'Y' when 'Show in Status Bar' flag is checked.
Removed display logic from 'Read-Only' field

---
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
A src/org/openbravo/erpCommon/ad_callouts/SL_StatusFieldDefaults.java
---
(0051336)
AugustoMauch   
2012-08-17 10:36   
Code reviewed and verified in pi@28081bd3f4d0