Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021334Openbravo ERP01. General setuppublic2012-08-09 10:412012-08-28 12:12
Reportergorkaion 
Assigned Tonaiaramartinez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionGentoo
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021334: Improve error message in Initial Client setup when no source.path is defined
DescriptionThe initial client setup fails in the import datasets phase when the source path is not defined in the Openbravo.properties file.

Current error message is null.
Steps To ReproduceOn any instance remove the source path configuration of Openbravo.properties file.

Try to run the Initial Client Setup process importing core's dataset.
Proposed SolutionThe InitialSetupUtility.insertReferenceData() method returns null when the xml file is not found. This should be changed to throw an exception with a proper message.

The InitialClientSetup class is not checking if the previous method returns null, causing a null pointer access error in the line 660.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-09 10:41gorkaionNew Issue
2012-08-09 10:41gorkaionAssigned To => mirurita
2012-08-09 10:41gorkaionModules => Core
2012-08-24 10:14naiaramartinezAssigned Tomirurita => naiaramartinez
2012-08-24 10:18naiaramartinezStatusnew => scheduled
2012-08-24 10:18naiaramartinezfix_in_branch => pi
2012-08-24 10:23naiaramartinezNote Added: 0051528
2012-08-28 12:11hgbotCheckin
2012-08-28 12:11hgbotNote Added: 0051589
2012-08-28 12:11hgbotStatusscheduled => resolved
2012-08-28 12:11hgbotResolutionopen => fixed
2012-08-28 12:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dae6fd3d154a89d197f0687e3d4e3289f2b2c24a [^]
2012-08-28 12:12dmiguelezClosed by => dmiguelez
2012-08-28 12:12dmiguelezNote Added: 0051590
2012-08-28 12:12dmiguelezStatusresolved => closed

Notes
(0051528)
naiaramartinez   
2012-08-24 10:23   
On any instance remove the source path configuration of Openbravo.properties file.

Run the Initial Client Setup process importing core's dataset.

Notice that the following message is shown: 'Source path not defined in Openbravo.properties'
(0051589)
hgbot   
2012-08-28 12:11   
Repository: erp/devel/pi
Changeset: dae6fd3d154a89d197f0687e3d4e3289f2b2c24a
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Fri Aug 24 10:21:30 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dae6fd3d154a89d197f0687e3d4e3289f2b2c24a [^]

fixed bug 21334 Initial Client Setup:Improve error message when no source.path is defined

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0051590)
dmiguelez   
2012-08-28 12:12   
Code Review + Testing OK