Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021316Openbravo ERP01. General setuppublic2012-08-06 13:012012-08-10 08:09
vmromanos 
vmromanos 
normalmajorhave not tried
closedfixed 
20Debian 5.0
pi 
2.50MP452.50MP45 
Core
No
0021316: Update available icon in Enterprise Module Management
The Update available icon in the Enterprise Module Management window is always shown in the whole instance when there is just one organization that really has an update available for a dataset.

Imagine that the Organization "A" of client "C" has an update for the module "M" (because we applied in the past a dataset for that organization and we have updated the module to a new version).
If we move to another client, this module will show an update icon to all the available organizations, even in the case this dataset hasn't been applied before to these organizations!

The same scenario is also reproducible in the same client.
1. Install an old version of any module, for example the Spanish Taxes Module 1.2.44
2. Create a new client. Don't select any dataset
3. Log into that client and run an Initial Org Setup and select the Taxes dataset
4. Create another organization inside the same client, but this time don't select the Taxes dataset
5. Update to the Taxes module
6. Inside the F&B Client, go to the Enterprise Module Management and select any organization.
7. Check the update icon is always shown for the Taxes module, even we have never applied it before. WRONG
8. Change to the new client
9. Inside the F&B Client, go to the Enterprise Module Management and select the organization where we haven't applied the dataset.
10. Check the update icon is shown for the taxes module, even we have never applied it before. WRONG
In the Enterprise Module Management window, the update available icon should ONLY be displayed when there is an update for the selected organization.
No tags attached.
related to backport 00212942.50MP45 closed vmromanos Spanish taxes dataset update for new taxes applying from 01/09/2012 cannot be applied at Org level 
blocks defect 00213153.0MP15 closed vmromanos Update available icon in Enterprise Module Management 
Issue History
2012-08-06 13:01vmromanosTypedefect => backport
2012-08-06 13:01vmromanosfix_in_branch => 2.50
2012-08-06 13:02vmromanosTarget Version3.0MP15 => 2.50MP45
2012-08-06 13:02vmromanosRelationship addedrelated to 0021294
2012-08-06 13:53vmromanosNote Added: 0051121
2012-08-06 14:40hgbotCheckin
2012-08-06 14:40hgbotNote Added: 0051126
2012-08-06 14:40hgbotStatusscheduled => resolved
2012-08-06 14:40hgbotResolutionopen => fixed
2012-08-06 14:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/df7c1358b96ae51386472bf9ca563db1589fe656 [^]
2012-08-08 10:15miruritaNote Added: 0051160
2012-08-08 10:15miruritaStatusresolved => closed
2012-08-08 10:15miruritaFixed in Version => 2.50MP45
2012-08-08 21:45hgbotCheckin
2012-08-08 21:45hgbotNote Added: 0051182
2012-08-08 21:45hgbotStatusclosed => resolved
2012-08-08 21:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.50/rev/df7c1358b96ae51386472bf9ca563db1589fe656 [^] => http://code.openbravo.com/erp/stable/2.50/rev/032a689b7aa2be47055687202e915848ece7c799 [^]
2012-08-09 09:17vmromanosNote Added: 0051186
2012-08-09 09:17vmromanosStatusresolved => closed
2012-08-09 20:50hgbotCheckin
2012-08-09 20:50hgbotNote Added: 0051224
2012-08-09 20:50hgbotStatusclosed => resolved
2012-08-09 20:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.50/rev/032a689b7aa2be47055687202e915848ece7c799 [^] => http://code.openbravo.com/erp/stable/2.50/rev/cab2322adf42a6ff995418ffe6848799a962b70b [^]
2012-08-10 08:09vmromanosNote Added: 0051229
2012-08-10 08:09vmromanosStatusresolved => closed

Notes
(0051121)
vmromanos   
2012-08-06 13:53   
Test Plan I:
1. Install an old version of any module, for example the Spanish Taxes Module 1.2.14
2. Create a new client. Don't select any dataset
3. Log into that client and run an Initial Org Setup and select the Taxes dataset. Org name = YES, parent *
4. Create another organization inside the same client, but this time don't select the Taxes dataset. Org name = NO, parent *
5. Update the Taxes module
6. Inside the previously created client, go to the Enterprise Module Management window
7. Select Org "YES". The dataset update should be shown
8. Select Org "NO". The dataset should be shown without update icon
9. Select Org "*". Ensure the dataset is not shown.

Test Plan II:
1. Now, inside the Smallbazaar client, go to the Enterprise module management
2. Ensure the taxes dataset is available for all the organizations without the update icon
(0051126)
hgbot   
2012-08-06 14:40   
Repository: erp/stable/2.50
Changeset: df7c1358b96ae51386472bf9ca563db1589fe656
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 06 14:38:55 2012 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/df7c1358b96ae51386472bf9ca563db1589fe656 [^]

Fixed bug 21294, Fixed bug 21316: Enterprise Module Management

+ Client/Org modules are now properly displayed
+ An already applied dataset is not shown anymore for ancestor/child orgs
+ Checksum is now taken into account in case of updates. We also use the versions for
those scenarios where the dataset has been created without checksum (old 2.50 modules)
+ ISACTIVE column is taken into account

+ The LEFT JOIN is now filtering by the selected organization. The client is also
included into the join clause to avoid swapping the client and org parameters into
the generated sqlc method.

---
M src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
---
(0051160)
mirurita   
2012-08-08 10:15   
code review + testing OK
(0051182)
hgbot   
2012-08-08 21:45   
Repository: erp/stable/2.50
Changeset: 032a689b7aa2be47055687202e915848ece7c799
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 06 14:38:55 2012 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/032a689b7aa2be47055687202e915848ece7c799 [^]

Fixed bug 21294, Fixed bug 21316: Enterprise Module Management

+ Client/Org modules are now properly displayed
+ An already applied dataset is not shown anymore for ancestor/child orgs
+ Checksum is now taken into account in case of updates. We also use the versions for
those scenarios where the dataset has been created without checksum (old 2.50 modules)
+ ISACTIVE column is taken into account

+ The LEFT JOIN is now filtering by the selected organization. The client is also
included into the join clause to avoid swapping the client and org parameters into
the generated sqlc method.

---
M src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
---
(0051186)
vmromanos   
2012-08-09 09:17   
Closed again (it was reopened by the bot)
(0051224)
hgbot   
2012-08-09 20:50   
Repository: erp/stable/2.50
Changeset: cab2322adf42a6ff995418ffe6848799a962b70b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 06 14:38:55 2012 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/cab2322adf42a6ff995418ffe6848799a962b70b [^]

Fixed bug 21294, Fixed bug 21316: Enterprise Module Management

+ Client/Org modules are now properly displayed
+ An already applied dataset is not shown anymore for ancestor/child orgs
+ Checksum is now taken into account in case of updates. We also use the versions for
those scenarios where the dataset has been created without checksum (old 2.50 modules)
+ ISACTIVE column is taken into account

+ The LEFT JOIN is now filtering by the selected organization. The client is also
included into the join clause to avoid swapping the client and org parameters into
the generated sqlc method.

---
M src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
---
(0051229)
vmromanos   
2012-08-10 08:09   
Closed again (it was reopened by the bot)