Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021315Openbravo ERP01. General setuppublic2012-08-06 13:012012-08-09 13:46
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Versionpi 
Target Version3.0MP15Fixed in Version3.0MP15 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021315: Update available icon in Enterprise Module Management
DescriptionThe Update available icon in the Enterprise Module Management window is always shown in the whole instance when there is just one organization that really has an update available for a dataset.

Imagine that the Organization "A" of client "C" has an update for the module "M" (because we applied in the past a dataset for that organization and we have updated the module to a new version).
If we move to another client, this module will show an update icon to all the available organizations, even in the case this dataset hasn't been applied before to these organizations!

The same scenario is also reproducible in the same client.
Steps To Reproduce1. Install an old version of any module, for example the Spanish Taxes Module 1.2.44
2. Create a new client. Don't select any dataset
3. Log into that client and run an Initial Org Setup and select the Taxes dataset
4. Create another organization inside the same client, but this time don't select the Taxes dataset
5. Update to the Taxes module
6. Inside the F&B Client, go to the Enterprise Module Management and select any organization.
7. Check the update icon is always shown for the Taxes module, even we have never applied it before. WRONG
8. Change to the new client
9. Inside the F&B Client, go to the Enterprise Module Management and select the organization where we haven't applied the dataset.
10. Check the update icon is shown for the taxes module, even we have never applied it before. WRONG
Proposed SolutionIn the Enterprise Module Management window, the update available icon should ONLY be displayed when there is an update for the selected organization.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00213162.50MP45 closed vmromanos Update available icon in Enterprise Module Management 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-06 13:01vmromanosNew Issue
2012-08-06 13:01vmromanosAssigned To => vmromanos
2012-08-06 13:01vmromanosModules => Core
2012-08-06 13:01vmromanosStatusnew => scheduled
2012-08-06 13:01vmromanosfix_in_branch => pi
2012-08-06 13:53vmromanosNote Added: 0051120
2012-08-07 08:09hgbotCheckin
2012-08-07 08:09hgbotNote Added: 0051136
2012-08-07 08:09hgbotStatusscheduled => resolved
2012-08-07 08:09hgbotResolutionopen => fixed
2012-08-07 08:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/336f5e2a9e8f58754645954d23047c481bcb29fc [^]
2012-08-09 13:46miruritaNote Added: 0051213
2012-08-09 13:46miruritaStatusresolved => closed
2012-08-09 13:46miruritaFixed in Version => 3.0MP15

Notes
(0051120)
vmromanos   
2012-08-06 13:53   
Test Plan I:
1. Install an old version of any module, for example the Spanish Taxes Module 1.2.14
2. Create a new client. Don't select any dataset
3. Log into that client and run an Initial Org Setup and select the Taxes dataset. Org name = YES, parent *
4. Create another organization inside the same client, but this time don't select the Taxes dataset. Org name = NO, parent *
5. Update the Taxes module
6. Inside the previously created client, go to the Enterprise Module Management window
7. Select Org "YES". The dataset update should be shown
8. Select Org "NO". The dataset should be shown without update icon
9. Select Org "*". Ensure the dataset is not shown.

Test Plan II:
1. Now, inside the F&B Client client, go to the Enterprise module management
2. Ensure the taxes dataset is available for all the organizations without the update icon
(0051136)
hgbot   
2012-08-07 08:09   
Repository: erp/devel/pi
Changeset: 336f5e2a9e8f58754645954d23047c481bcb29fc
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 06 14:06:06 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/336f5e2a9e8f58754645954d23047c481bcb29fc [^]

Fixed bug 21315: Update available icon in Enterprise Module Management

The LEFT JOIN is now filtering by the selected organization. The client is also
included into the join clause to avoid swapping the client and org parameters into
the generated sqlc method.

---
M src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
---
(0051213)
mirurita   
2012-08-09 13:46   
code review + testing OK