Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021313Openbravo ERPA. Platformpublic2012-08-06 09:262012-08-22 12:59
AugustoMauch 
AugustoMauch 
normalminorhave not tried
closedinvalid 
30Professional Appliance
 
 
AugustoMauch
Core
No
0021313: Wrong message shown in log after unsuccessful login
In the login window, if an invalid username and password pair are entered, the following message will appear in the log after pressing the Log In button:

[http-8080-3] ERROR org.openbravo.authentication.AuthenticationException - IDENTIFICATION_FAILURE_TITLE
org.openbravo.authentication.AuthenticationException: IDENTIFICATION_FAILURE_TITLE at org.openbravo.authentication.basic.DefaultAuthenticationManager.doAuthenticate(DefaultAuthenticationManager.java:95)

IDENTIFICATION_FAILURE_TITLE is the title of a message. Instead of showing the title, the text of the message should be shown.
- Open Openbravo login window
- Enter an invalid username-password pair
- Push the Log In button
- Check the log
Use the Utility.messageBD method to show the message properly
No tags attached.
Issue History
2012-08-06 09:26AugustoMauchNew Issue
2012-08-06 09:26AugustoMauchAssigned To => AugustoMauch
2012-08-06 09:26AugustoMauchModules => Core
2012-08-07 14:53hgbotCheckin
2012-08-07 14:53hgbotNote Added: 0051144
2012-08-07 14:53hgbotStatusnew => resolved
2012-08-07 14:53hgbotResolutionopen => fixed
2012-08-07 14:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/64bd1fa3cf1fd7f414b0b7c986f3e6682ecd1ced [^]
2012-08-07 14:56hgbotCheckin
2012-08-07 14:56hgbotNote Added: 0051145
2012-08-14 14:19AugustoMauchNote Added: 0051284
2012-08-14 14:19AugustoMauchStatusresolved => new
2012-08-14 14:19AugustoMauchResolutionfixed => open
2012-08-14 14:19AugustoMauchClosed by => marvintm
2012-08-14 14:20AugustoMauchStatusnew => scheduled
2012-08-14 14:20AugustoMauchfix_in_branch => pi
2012-08-14 14:20AugustoMauchStatusscheduled => resolved
2012-08-14 14:20AugustoMauchResolutionopen => fixed
2012-08-22 12:53AugustoMauchNote Added: 0051464
2012-08-22 12:53AugustoMauchStatusresolved => new
2012-08-22 12:53AugustoMauchResolutionfixed => open
2012-08-22 12:58hgbotCheckin
2012-08-22 12:58hgbotNote Added: 0051465
2012-08-22 12:59AugustoMauchClosed bymarvintm => AugustoMauch
2012-08-22 12:59AugustoMauchNote Added: 0051466
2012-08-22 12:59AugustoMauchStatusnew => closed
2012-08-22 12:59AugustoMauchResolutionopen => invalid

Notes
(0051144)
hgbot   
2012-08-07 14:53   
Repository: erp/devel/pi
Changeset: 64bd1fa3cf1fd7f414b0b7c986f3e6682ecd1ced
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Aug 06 16:21:39 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/64bd1fa3cf1fd7f414b0b7c986f3e6682ecd1ced [^]

Fixes issue 21313 : Wrong message shown in log after unsuccessful login

---
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
---
(0051145)
hgbot   
2012-08-07 14:56   
Repository: erp/devel/pi
Changeset: cac29d3b353eb7943e9d816ddfa5682dafea698d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Aug 07 14:56:07 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cac29d3b353eb7943e9d816ddfa5682dafea698d [^]

Related to issue 21313: Utility.messageBD used in some hardcoded messages

---
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
---
(0051284)
AugustoMauch   
2012-08-14 14:19   
Issue reopened to enter Closed by field
(0051464)
AugustoMauch   
2012-08-22 12:53   
Issue reopened because current fix makes impossible to translate the login authentication error messages
(0051465)
hgbot   
2012-08-22 12:58   
Repository: erp/devel/pi
Changeset: ebbe01a04123790304daa060253e91e395bdb1a2
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Aug 22 12:57:26 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ebbe01a04123790304daa060253e91e395bdb1a2 [^]

Related to issue 21313: Backs out changesets

Changesets of iffue 21313 has been reverted because it made impossible to see in the login window the authentication error messages translated.

---
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
---
(0051466)
AugustoMauch   
2012-08-22 12:59   
It is not possible to see in the log the translated message, because it is a particular case in which at that point the content of the error is the message title, and not the message itself.