Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021294Openbravo ERP01. General setuppublic2012-08-02 15:582012-08-10 08:08
Reporterjmon 
Assigned Tovmromanos 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.50MP45Fixed in Version2.50MP45 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2011-08-22
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/stable/2.50/rev/c1a592b54b9d909ca70781e008c605fd12b09b61 [^]
Triggers an Emergency PackNo
Summary0021294: Spanish taxes dataset update for new taxes applying from 01/09/2012 cannot be applied at Org level
DescriptionHaving a client with the spanish taxes dataset (Taxes: configuration for Spain (Impuestos para España) 1.2.39) applied at org level, when you update to the last version of that module in order to load the new taxes you cannot apply the new dataset version (1.2.45) at Org level (same as the original dataset was applied).

This has been reproduced in a 2.50 mp44 instance.
Steps To Reproduce* Customer with previous version of Taxes module installed and applied at org level as they have other orgs with other localizations.
To get new taxes:
* Module Management window. Customer scans for updates, receives update for Taxes module and installs it.
* Enterprise Module Management window. Customer selects Org at which previous version of Taxes module was installed. Information that update available for Taxes module appears does not appear. Customer selects Org * (client level), information that update available for Taxes module appears and installs the update resulting in new taxes at * level and duplicated for the rest.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to backport 00213162.50MP45 closed vmromanos Update available icon in Enterprise Module Management 
Attached Filesxlsx AD_ORGMODULE.xlsx (11,390) 2012-08-03 08:18
https://issues.openbravo.com/file_download.php?file_id=5487&type=bug
png TestingPlan_ok.png (60,902) 2012-08-08 10:13
https://issues.openbravo.com/file_download.php?file_id=5491&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-08-02 15:58jmonNew Issue
2012-08-02 15:58jmonAssigned To => jonalegriaesarte
2012-08-03 08:18jmonFile Added: AD_ORGMODULE.xlsx
2012-08-03 08:18jmonNote Added: 0051092
2012-08-03 09:52vmromanosAssigned Tojonalegriaesarte => vmromanos
2012-08-03 09:52vmromanosCategorySpanish Tax Module Improvements => Taxes
2012-08-06 12:35vmromanosProjectLocalization Pack: Spain => Openbravo ERP
2012-08-06 12:41vmromanosModules => Core
2012-08-06 12:41vmromanosNote Added: 0051114
2012-08-06 12:41vmromanosCategoryTaxes => 01. General setup
2012-08-06 12:41vmromanosTypedefect => backport
2012-08-06 12:41vmromanosFixed in Version => 2.50MP45
2012-08-06 12:41vmromanosfix_in_branch => 2.50
2012-08-06 12:41vmromanosStatusnew => scheduled
2012-08-06 12:41vmromanosfix_in_branch2.50 => pi
2012-08-06 12:43vmromanosFixed in Version2.50MP45 =>
2012-08-06 12:43vmromanosTarget Version => 2.50MP45
2012-08-06 12:43vmromanosfix_in_branchpi => 2.50
2012-08-06 12:46vmromanosNote Edited: 0051114bug_revision_view_page.php?bugnote_id=0051114#r3708
2012-08-06 13:02vmromanosRelationship addedrelated to 0021316
2012-08-06 13:50vmromanosNote Added: 0051119
2012-08-06 14:40hgbotCheckin
2012-08-06 14:40hgbotNote Added: 0051125
2012-08-06 14:40hgbotStatusscheduled => resolved
2012-08-06 14:40hgbotResolutionopen => fixed
2012-08-06 14:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/df7c1358b96ae51386472bf9ca563db1589fe656 [^]
2012-08-07 18:20dmitry_mezentsevNote Added: 0051151
2012-08-07 20:43gorka_gilIssue Monitored: gorka_gil
2012-08-08 08:34vmromanosNote Added: 0051153
2012-08-08 08:34vmromanosStatusresolved => new
2012-08-08 08:34vmromanosResolutionfixed => open
2012-08-08 08:35vmromanosRegression level => Production - Confirmed Stable
2012-08-08 08:35vmromanosRegression date => 2011-08-22
2012-08-08 08:35vmromanosRegression introduced by commit => https://code.openbravo.com/erp/stable/2.50/rev/c1a592b54b9d909ca70781e008c605fd12b09b61 [^]
2012-08-08 08:35vmromanosStatusnew => scheduled
2012-08-08 08:35vmromanosfix_in_branch2.50 => pi
2012-08-08 08:36vmromanosStatusscheduled => resolved
2012-08-08 08:36vmromanosResolutionopen => fixed
2012-08-08 10:12miruritaStatusresolved => new
2012-08-08 10:12miruritaResolutionfixed => open
2012-08-08 10:13miruritaFile Added: TestingPlan_ok.png
2012-08-08 10:13miruritaStatusnew => scheduled
2012-08-08 10:13miruritaStatusscheduled => resolved
2012-08-08 10:13miruritaResolutionopen => fixed
2012-08-08 10:14miruritaNote Added: 0051159
2012-08-08 10:14miruritaStatusresolved => closed
2012-08-08 10:14miruritaFixed in Version => 2.50MP45
2012-08-08 21:45hgbotCheckin
2012-08-08 21:45hgbotNote Added: 0051181
2012-08-08 21:45hgbotStatusclosed => resolved
2012-08-08 21:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.50/rev/df7c1358b96ae51386472bf9ca563db1589fe656 [^] => http://code.openbravo.com/erp/stable/2.50/rev/032a689b7aa2be47055687202e915848ece7c799 [^]
2012-08-09 09:16vmromanosNote Added: 0051185
2012-08-09 09:16vmromanosStatusresolved => closed
2012-08-09 20:50hgbotCheckin
2012-08-09 20:50hgbotNote Added: 0051223
2012-08-09 20:50hgbotStatusclosed => resolved
2012-08-09 20:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.50/rev/032a689b7aa2be47055687202e915848ece7c799 [^] => http://code.openbravo.com/erp/stable/2.50/rev/cab2322adf42a6ff995418ffe6848799a962b70b [^]
2012-08-10 08:08vmromanosNote Added: 0051228
2012-08-10 08:08vmromanosStatusresolved => closed

Notes
(0051092)
jmon   
2012-08-03 08:18   
Attaching data in ad_orgmodule after the update.
(0051114)
vmromanos   
2012-08-06 12:41   
(edited on: 2012-08-06 12:46)
When a dataset is applied to an organization, it has no sense to apply it to any organization above or below that organization. In this case of scenario, the Enterprise Module Management window must NOT display that module when an ancestor or a child organization (of any level) is selected.

Apart from that, the Taxes module should have been obviously displayed in the Enterprise Module Management for that organization in order to be able to update it.

This bug is only reproducible on 2.50 version (not 3.0)
(0051119)
vmromanos   
2012-08-06 13:50   
Test Plan I:
1. Install an old version of any module, for example the Spanish Taxes Module 1.2.14
2. Create a new client. Don't select any dataset
3. Log into that client and run an Initial Org Setup and select the Taxes dataset. Org name = YES, parent *
4. Create another organization inside the same client, but this time don't select the Taxes dataset. Org name = NO, parent *
5. Update the Taxes module
6. Inside the previously created client, go to the Enterprise Module Management window
7. Select Org "YES". The dataset update should be shown
8. Select Org "NO". The dataset should be shown (without update icon)
9. Select Org "*". Ensure the dataset is not shown.

Test Plan II:
1. Now, inside the Smallbazaar client, go to the Enterprise module management
2. Ensure the taxes dataset is available for all the organizations (without the update icon)
3. Apply it to the A organization.
4. Ensure the Taxes dataset is not available anymore neither for the "A" ancestors nor for its children.
5. Ensure the Taxes dataset is available for the B organization and any of its children.
(0051125)
hgbot   
2012-08-06 14:40   
Repository: erp/stable/2.50
Changeset: df7c1358b96ae51386472bf9ca563db1589fe656
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 06 14:38:55 2012 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/df7c1358b96ae51386472bf9ca563db1589fe656 [^]

Fixed bug 21294, Fixed bug 21316: Enterprise Module Management

+ Client/Org modules are now properly displayed
+ An already applied dataset is not shown anymore for ancestor/child orgs
+ Checksum is now taken into account in case of updates. We also use the versions for
those scenarios where the dataset has been created without checksum (old 2.50 modules)
+ ISACTIVE column is taken into account

+ The LEFT JOIN is now filtering by the selected organization. The client is also
included into the join clause to avoid swapping the client and org parameters into
the generated sqlc method.

---
M src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
---
(0051151)
dmitry_mezentsev   
2012-08-07 18:20   
Please review and close this issue ASAP.
(0051153)
vmromanos   
2012-08-08 08:34   
Reopened to fill Regression fields
(0051159)
mirurita   
2012-08-08 10:14   
code review + testing OK.

see attached screenshot with the result.
(0051181)
hgbot   
2012-08-08 21:45   
Repository: erp/stable/2.50
Changeset: 032a689b7aa2be47055687202e915848ece7c799
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 06 14:38:55 2012 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/032a689b7aa2be47055687202e915848ece7c799 [^]

Fixed bug 21294, Fixed bug 21316: Enterprise Module Management

+ Client/Org modules are now properly displayed
+ An already applied dataset is not shown anymore for ancestor/child orgs
+ Checksum is now taken into account in case of updates. We also use the versions for
those scenarios where the dataset has been created without checksum (old 2.50 modules)
+ ISACTIVE column is taken into account

+ The LEFT JOIN is now filtering by the selected organization. The client is also
included into the join clause to avoid swapping the client and org parameters into
the generated sqlc method.

---
M src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
---
(0051185)
vmromanos   
2012-08-09 09:16   
Closed again (it was reopened by the bot)
(0051223)
hgbot   
2012-08-09 20:50   
Repository: erp/stable/2.50
Changeset: cab2322adf42a6ff995418ffe6848799a962b70b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 06 14:38:55 2012 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/cab2322adf42a6ff995418ffe6848799a962b70b [^]

Fixed bug 21294, Fixed bug 21316: Enterprise Module Management

+ Client/Org modules are now properly displayed
+ An already applied dataset is not shown anymore for ancestor/child orgs
+ Checksum is now taken into account in case of updates. We also use the versions for
those scenarios where the dataset has been created without checksum (old 2.50 modules)
+ ISACTIVE column is taken into account

+ The LEFT JOIN is now filtering by the selected organization. The client is also
included into the join clause to avoid swapping the client and org parameters into
the generated sqlc method.

---
M src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
---
(0051228)
vmromanos   
2012-08-10 08:08   
Closed again (it was reopened by the bot)