Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021279Openbravo ERPY. DBSourceManagerpublic2012-08-01 16:092012-08-24 09:40
Reportershuehner 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021279: API-check check, db model part does not defect deletion of a view
DescriptionIn this try push:
https://code.openbravo.com/erp/devel/try/rev/c8f8fc23ae0b [^]

two views were deleted (compared to mp13). The data part did notice the deletion of all the ad_column etc entries,

but the structure part did not raise the two views as being missing at all.
Steps To Reproducetake clean clone of pi + api-checks
run model part of api-check
ant run.api.test.model -DstableDBdir=<api-checks-clone>/model
check that it runs fine
delete some xml view under src-db/database/model/views/
run api-test again
notice that no error is raised.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-01 16:09shuehnerNew Issue
2012-08-01 16:09shuehnerAssigned To => marvintm
2012-08-01 16:09shuehnerModules => Core
2012-08-01 16:09shuehnerOBNetwork customer => No
2012-08-21 10:21AugustoMauchAssigned Tomarvintm => AugustoMauch
2012-08-21 15:30AugustoMauchClosed by => marvintm
2012-08-21 15:39hgbotCheckin
2012-08-21 15:39hgbotNote Added: 0051430
2012-08-21 15:39hgbotStatusnew => resolved
2012-08-21 15:39hgbotResolutionopen => fixed
2012-08-21 15:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bb9463a6854bd94b791478ee6d39c3880af5ff08 [^]
2012-08-21 16:24hgbotCheckin
2012-08-21 16:24hgbotNote Added: 0051435
2012-08-21 16:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/bb9463a6854bd94b791478ee6d39c3880af5ff08 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/07b5efcbca14d6bca671a56d155ce85e1db68795 [^]
2012-08-24 09:40marvintmStatusresolved => closed
2012-08-24 09:40marvintmFixed in Version => 3.0MP15

Notes
(0051430)
hgbot   
2012-08-21 15:39   
Repository: erp/devel/pi
Changeset: bb9463a6854bd94b791478ee6d39c3880af5ff08
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Aug 21 15:38:22 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bb9463a6854bd94b791478ee6d39c3880af5ff08 [^]

Fixes issue 21279: API checks detects deletion of views

The deletion of views is being detected again in the API check. The retrieveal of the RemoveViewChanges is not included in ModelComparator because it has to be done only in the API check.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0051435)
hgbot   
2012-08-21 16:24   
Repository: erp/devel/dbsm-main
Changeset: 07b5efcbca14d6bca671a56d155ce85e1db68795
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Aug 21 16:24:01 2012 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/07b5efcbca14d6bca671a56d155ce85e1db68795 [^]

Fixes issue 21279: API checks detects deletion of views

---
M src/org/apache/ddlutils/alteration/ModelComparator.java
M src/org/openbravo/ddlutils/util/ValidateAPIModel.java
---