Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021273Openbravo ERP07. Sales managementpublic2012-08-01 02:162012-08-01 15:11
Reporterplujan 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelAutomated tests
Regression date2012-07-30
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f2a6e4598a05b0877b79700b659bdf2bbc2aeb27#l3.16 [^]
Triggers an Emergency PackNo
Summary0021273: Invoice Line tab does not show the Product combo in Form mode
DescriptionUsing Oracle database, after completing an invoice, the Product selector in Form mode is blank. It works fine when using Postgres.
See steps.
Steps To Reproduce1. Log in as QAAdmin
2. Go to Sales Invoice
3. Create a New record for Customer A
4. Create a Line for Final Goods A
5. Complete the Invoice
6. Check that the Product field shows the correct value
7. Change record to Form mode. Check that the Product field is blank (see screenshot)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Openbravo Sales Invoice I 47 01 08 2....png (88,412) 2012-08-01 02:16
https://issues.openbravo.com/file_download.php?file_id=5484&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-08-01 02:16plujanNew Issue
2012-08-01 02:16plujanAssigned To => mirurita
2012-08-01 02:16plujanFile Added: Openbravo Sales Invoice I 47 01 08 2....png
2012-08-01 02:16plujanModules => Core
2012-08-01 02:16plujanRegression level => Automated tests
2012-08-01 02:29plujanDescription Updatedbug_revision_view_page.php?rev_id=3680#r3680
2012-08-01 14:02dmiguelezAssigned Tomirurita => marvintm
2012-08-01 14:03dmiguelezNote Added: 0051061
2012-08-01 14:04dmiguelezNote Added: 0051062
2012-08-01 14:09dmiguelezAssigned Tomarvintm => caristu
2012-08-01 14:19plujanRegression date => 2012-07-30
2012-08-01 14:19plujanRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f2a6e4598a05b0877b79700b659bdf2bbc2aeb27#l3.16 [^]
2012-08-01 14:19plujanNote Added: 0051064
2012-08-01 14:46caristuStatusnew => scheduled
2012-08-01 14:46caristufix_in_branch => pi
2012-08-01 14:47caristuStatusscheduled => resolved
2012-08-01 14:47caristuFixed in SCM revision => a3f4acecdb1b
2012-08-01 14:47caristuResolutionopen => fixed
2012-08-01 14:48caristuNote Added: 0051068
2012-08-01 15:11dmiguelezNote Added: 0051070
2012-08-01 15:11dmiguelezStatusresolved => closed
2012-08-01 15:11dmiguelezFixed in Version => pi

Notes
(0051061)
dmiguelez   
2012-08-01 14:03   
The Issue is related to the sql for gl item combo:

: c988d094 74421410 [http-8080-4] ERROR org.openbravo.erpCommon.utility.ComboTableData - Error of SQL in query: SELECT td0.C_Glitem_ID AS ID, (COALESCE(TO_CHAR(COALESCE(TO_CHAR(td0.Name),'')),'')) AS NAME, '' AS DESCRIPTION
FROM C_Glitem td0
WHERE td0.AD_Client_ID IN ('0','23C59575B9CF467C9620760EB255B389')
AND td0.AD_Org_ID IN ('E443A31992CB4635AFCAEABE7183CE85','B843C30461EA4501935CB1D125C9C25A','19404EAD144C49A0AF37D54377CF452D','0')
AND EnableInFinInvoices = 'Y'
AND (td0.isActive = 'Y' OR td0.C_Glitem_ID = (?) )
ORDER BY AD_Org_ID = ? DESCException:java.sql.SQLSyntaxErrorException: ORA-00933: SQL command not properly ended

c988d094 74421453 [http-8080-4] ERROR org.openbravo.base.exception.OBException - Error while computing combo data
java.lang.Exception: @CODE=933@ORA-00933: SQL command not properly ended

    at org.openbravo.erpCommon.utility.ComboTableData.select(ComboTableData.java:1102)
    at org.openbravo.client.kernel.reference.UIDefinition.getValueInComboReference(UIDefinition.java:443)
    at org.openbravo.client.kernel.reference.FKComboUIDefinition.getFieldProperties(FKComboUIDefinition.java:49)
    at org.openbravo.client.application.window.FormInitializationComponent.computeColumnValues(FormInitializationComponent.java:551)
    at org.openbravo.client.application.window.FormInitializationComponent.execute(FormInitializationComponent.java:227)
    at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:71)
    at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:193)
    at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:104)
    at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:177)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:428)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:63)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849)
    at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454)
    at java.lang.Thread.run(Thread.java:662)
c988d094 74421461 [http-8080-4] ERROR org.openbravo.base.exception.OBException - Couldn't get data for column Account_ID
org.openbravo.base.exception.OBException: Error while computing combo data
    at org.openbravo.client.kernel.reference.UIDefinition.getValueInComboReference(UIDefinition.java:493)
    at org.openbravo.client.kernel.reference.FKComboUIDefinition.getFieldProperties(FKComboUIDefinition.java:49)
    at org.openbravo.client.application.window.FormInitializationComponent.computeColumnValues(FormInitializationComponent.java:551)
    at org.openbravo.client.application.window.FormInitializationComponent.execute(FormInitializationComponent.java:227)
    at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:71)
    at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:193)
    at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:104)
    at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:177)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:428)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:63)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org..
(0051062)
dmiguelez   
2012-08-01 14:04   
Mind Order by clause:

ORDER BY AD_Org_ID = ? DESC
(0051064)
plujan   
2012-08-01 14:19   
The order by clause is wrong in this commit:
https://code.openbravo.com/erp/devel/pi/rev/f2a6e4598a05b0877b79700b659bdf2bbc2aeb27#l3.16 [^]
(0051068)
caristu   
2012-08-01 14:48   
This issue was fixed in SCM revision:

  https://code.openbravo.com/erp/devel/pi/rev/a3f4acecdb1b [^]
(0051070)
dmiguelez   
2012-08-01 15:11   
Code Reviewed + Testing OK