Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021246Openbravo ERPA. Platformpublic2012-07-30 12:432012-08-29 19:25
Reportershuehner 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021246: Installing a module with wrong source.path configuration now shows NPE
DescriptionTrying to install a module having wrong source.path configuration now does not show a useful error message indicating the error but does just show a NullPointerException.

Error stacktrace:

a3196480 180980 [http-8080-4] ERROR org.openbravo.erpCommon.ad_forms.ModuleManagement - Error captured:
java.lang.NullPointerException
    at org.openbravo.erpCommon.ad_forms.ModuleManagement.verifyLocalChanges(ModuleManagement.java:2638)
    at org.openbravo.erpCommon.ad_forms.ModuleManagement.printPageInstall1(ModuleManagement.java:1100)
    at org.openbravo.erpCommon.ad_forms.ModuleManagement.doPost(ModuleManagement.java:152)
Steps To Reproducecurrent pi + install.source
do not configure source.path correctly (or deliberately point it to a non-existent directory)
try to install a module
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-07-30 12:43shuehnerNew Issue
2012-07-30 12:43shuehnerAssigned To => alostale
2012-07-30 12:43shuehnerModules => Core
2012-08-08 13:53AugustoMauchAssigned Toalostale => AugustoMauch
2012-08-16 15:50hgbotCheckin
2012-08-16 15:50hgbotNote Added: 0051329
2012-08-16 16:06hgbotCheckin
2012-08-16 16:06hgbotNote Added: 0051330
2012-08-16 16:17hgbotCheckin
2012-08-16 16:17hgbotNote Added: 0051331
2012-08-16 16:33hgbotCheckin
2012-08-16 16:33hgbotNote Added: 0051332
2012-08-16 16:33hgbotStatusnew => resolved
2012-08-16 16:33hgbotResolutionopen => fixed
2012-08-16 16:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0e82e9b7585aae158a4cdc89dd38cd661a0a2822 [^]
2012-08-29 19:25migueldejuanaClosed by => migueldejuana
2012-08-29 19:25migueldejuanaNote Added: 0051653
2012-08-29 19:25migueldejuanaStatusresolved => closed

Notes
(0051329)
hgbot   
2012-08-16 15:50   
Repository: erp/devel/pi
Changeset: 43a1d064d9c43e0d6708e9a2c2a542c05d09c909
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Aug 09 17:37:00 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/43a1d064d9c43e0d6708e9a2c2a542c05d09c909 [^]

Related to issue 21246 : Null Pointer Exception while installing module

Installing a module with wrong source.path configuration now shows NPE.
Fixed that to show 'Invalid source path' when the folder does not exist.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0051330)
hgbot   
2012-08-16 16:06   
Repository: erp/devel/pi
Changeset: 54c9e821596d07f1b14714e7029667885e9d3162
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 16 16:06:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/54c9e821596d07f1b14714e7029667885e9d3162 [^]

Related to issue 21246: Added missing parenthesis

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0051331)
hgbot   
2012-08-16 16:17   
Repository: erp/devel/pi
Changeset: e62c79a1253e707ca2330a684d445b6787a8eb52
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Wed Aug 15 18:38:46 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e62c79a1253e707ca2330a684d445b6787a8eb52 [^]

Related to issue 21246 : Null Pointer Exception while installing modules

Handles the case when the folder exists but does not have the proper permissions.

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0051332)
hgbot   
2012-08-16 16:33   
Repository: erp/devel/pi
Changeset: 0e82e9b7585aae158a4cdc89dd38cd661a0a2822
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Thu Aug 16 17:58:49 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0e82e9b7585aae158a4cdc89dd38cd661a0a2822 [^]

Fixes Issue 21246: Null Pointer Exception while Installing Modules

Handled pending case, when the source path points to an existing folder with write permissions but that does not contain the Openbravo sources.

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0051653)
migueldejuana   
2012-08-29 19:25   
Tested and reviewed in pi@19952d22eb0a