Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021199Openbravo ERPZ. Otherspublic2012-07-25 10:082012-07-31 10:35
Reporterjecharri 
Assigned Tojecharri 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP14Fixed in Version3.0MP14 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-04-03
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/367f4c3538f7 [^]
Triggers an Emergency Packyes
Summary0021199: Module script DeleteInventoryLines is incomplete
DescriptionModule script DeleteInventoryLines is incomplete because it is deleting m_storage_detail records but is not taking into account that these lines can be referenced in table m_stock_aux. So it is neccesary to delete first these records, in case that the quantity or qtyorder is null or 0.

Steps To ReproduceUsing older MP than 11 import some inventory lines with product with mandatory attribute set. This will create 2 records in m_storage_detail, one with product with attribute set and another without (this lines is wrong).

Use this products in production process(in a Work Requirement and execute "create standards" process.

This operation will insert some records in m_stock_aux related to m_storage_detail lines.

Upgrade your instance to a MP13, module script "DeleteInventoryLines" will delete m_storage_detail lines but not m_stock_aux records, so the users will not be able to upgrade the instance because in MP13 the rebuild stops if a constraint is breached.
Proposed SolutionDo not delete m_storage_detail lines if it has a related m_stock_aux lines, and if the m_stock_aux lines have quantity = 0 and qtyorder = 0, delete first these records and after that m_storage_detail lines.
Additional Information
TagsRegression
Relationships
related to defect 00212643.0MP14 closed jecharri Module script DeleteInventoryLines is incomplete and the processes related 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-07-25 10:08jecharriNew Issue
2012-07-25 10:08jecharriAssigned To => jecharri
2012-07-25 10:08jecharriWeb browser => Google Chrome
2012-07-25 10:08jecharriModules => Core
2012-07-25 10:08jecharriOBNetwork customer => Yes
2012-07-25 10:10jecharriWeb browserGoogle Chrome => Google Chrome
2012-07-25 10:10jecharriResolution time => 1343426400
2012-07-25 10:10jecharriRegression level => Production - Confirmed Stable
2012-07-25 10:10jecharriRegression date => 2012-04-03
2012-07-25 10:10jecharriRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/367f4c3538f7 [^]
2012-07-25 10:11jecharriTag Attached: Regression
2012-07-25 11:46jecharriWeb browserGoogle Chrome => Google Chrome
2012-07-25 11:46jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3660#r3660
2012-07-25 12:27hgbotCheckin
2012-07-25 12:27hgbotNote Added: 0050827
2012-07-25 12:27hgbotStatusnew => resolved
2012-07-25 12:27hgbotResolutionopen => fixed
2012-07-25 12:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6ad71b9bb6c387d0ef70a90c5b0899cd5faba33d [^]
2012-07-25 12:41hgbotCheckin
2012-07-25 12:41hgbotNote Added: 0050828
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050879
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050880
2012-07-31 10:35gorkaionStatusresolved => closed
2012-07-31 10:35gorkaionFixed in Version => 3.0MP14
2012-07-31 13:28VictorVillarRelationship addedrelated to 0021264

Notes
(0050827)
hgbot   
2012-07-25 12:27   
Repository: erp/devel/pi
Changeset: 6ad71b9bb6c387d0ef70a90c5b0899cd5faba33d
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Jul 25 12:27:17 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6ad71b9bb6c387d0ef70a90c5b0899cd5faba33d [^]

Fixes issue 021199: Module script DeleteInventoryLines is incomplete

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteInventoryLines.class
M src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteInventoryLinesData.class
M src-util/modulescript/src/org/openbravo/modulescript/DeleteInventoryLines.java
M src-util/modulescript/src/org/openbravo/modulescript/DeleteInventoryLines_data.xsql
---
(0050828)
hgbot   
2012-07-25 12:41   
Repository: erp/devel/pi
Changeset: ea94fc41640ae6a776a5fdf31415a7c30d7649e2
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Jul 25 12:40:51 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ea94fc41640ae6a776a5fdf31415a7c30d7649e2 [^]

issue 021199: Module script DeleteInventoryLines is incomplete.
The character ; is not necessary and create a fail in oracle

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteInventoryLinesData.class
M src-util/modulescript/src/org/openbravo/modulescript/DeleteInventoryLines_data.xsql
---
(0050879)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050880)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test