Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021138Openbravo ERP07. Sales managementpublic2012-07-18 12:112012-07-26 02:42
mirurita 
mirurita 
highmajoralways
closedfixed 
20Community Appliance
pi 
pi 
Core
Production - Confirmed Stable
2012-03-13
https://code.openbravo.com/erp/devel/pi/rev/3ab535c40a07 [^]
yes
0021138: Copy Lines not working using comma (,) as decimal separator
Copy Lines does not work with commas as decimal separator.

If you select an existing order line and try to copy you will get an error because the "Last Price" and "Quantity" contains illegal values.

The validation for numeric values is failing with numbers using commas as decimal separator.

CopyFormOrder.html validateNumber function
var invalid = isNaN(Number(input.value));
1) Create a new Sales Order header for Alimentos y Supermercados, S.A with
2) Create a new line
  + Product: Agua sin Gas 1L
  + Quantity: 1
3) Book the order
4) Create a new Sales Order for Alimentos y Supermercados, S.A with
5) Click on "Copy Lines" button
6) Select previously created sales order line (checkbox in the left side)
7) Edit the quantity to = 2
8) Click on OK button
9) You will get an error: * The value entered is not valid.


No tags attached.
png CopyLines_comma_decimal.png (94,601) 2012-07-18 12:13
https://issues.openbravo.com/file_download.php?file_id=5453&type=bug
png
Issue History
2012-07-18 12:11miruritaNew Issue
2012-07-18 12:11miruritaAssigned To => mirurita
2012-07-18 12:11miruritaModules => Core
2012-07-18 12:12miruritaRegression level => Production - Confirmed Stable
2012-07-18 12:12miruritaRegression date => 2012-03-13
2012-07-18 12:12miruritaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/3ab535c40a07 [^]
2012-07-18 12:13miruritaFile Added: CopyLines_comma_decimal.png
2012-07-18 18:10hgbotCheckin
2012-07-18 18:10hgbotNote Added: 0050738
2012-07-18 18:10hgbotStatusnew => resolved
2012-07-18 18:10hgbotResolutionopen => fixed
2012-07-18 18:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d055a5224b9952feddd6146b4003c8631766b678 [^]
2012-07-25 18:56dmiguelezNote Added: 0050846
2012-07-25 18:56dmiguelezStatusresolved => closed
2012-07-25 18:56dmiguelezFixed in Version => pi
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050854

Notes
(0050738)
hgbot   
2012-07-18 18:10   
Repository: erp/devel/pi
Changeset: d055a5224b9952feddd6146b4003c8631766b678
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Jul 18 16:37:40 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d055a5224b9952feddd6146b4003c8631766b678 [^]

Fixes issue 21138: Copy Lines not working using comma as decimal separator

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.html
---
(0050846)
dmiguelez   
2012-07-25 18:56   
Code Review + Test OK
(0050854)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test