Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021068Openbravo ERP09. Financial managementpublic2012-07-13 12:082012-09-28 14:39
Reporterpsarobe 
Assigned Topramakrishnan 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021068: Reactivating an invoice that has discounts and price includes taxes, the tax amt sometimes is not correct
DescriptionAfter completing again de invoice everything is fine and numbers are correct

Only happens in postgres
Steps To Reproduce1. Go to sales invoice window
2. Click new and select hoteles buenas noches
3. Select the price list "Tarifa de ventas". Must be marked as "Price includes taxes"
4. Save the header
5. Add a discount in the discount tab: 10%
6. Move to lines and select "Agua sin gas 1L"
7. Complete the invoice.
8. Reactivate the invoice
9. Move to tax tab and notice the tax amount is not correct:
  9.1 The total gross is 1.53
  9.2 Tax amount is 0.23
  9.3 Taxable amount is 1.29
So tax amount must be 0.24 in order to sum 1.53

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020553 closed dmiguelez Total Gross Amount issue 
Attached Filesdiff issue21068_proposedsolution.diff (2,163) 2012-07-13 14:21
https://issues.openbravo.com/file_download.php?file_id=5429&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-07-13 12:08psarobeNew Issue
2012-07-13 12:08psarobeAssigned To => mirurita
2012-07-13 12:08psarobeModules => Core
2012-07-13 12:09psarobeRelationship addedrelated to 0020553
2012-07-13 14:21miruritaFile Added: issue21068_proposedsolution.diff
2012-07-29 06:57flerouxNote Added: 0050968
2012-08-01 12:29flerouxIssue Monitored: fleroux
2012-09-17 18:13pramakrishnanAssigned Tomirurita => pramakrishnan
2012-09-25 13:10dmiguelezNote Added: 0052564
2012-09-25 13:10hgbotCheckin
2012-09-25 13:10hgbotNote Added: 0052565
2012-09-25 13:10hgbotStatusnew => resolved
2012-09-25 13:10hgbotResolutionopen => fixed
2012-09-25 13:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bd01edf33b85b09616570957afa0662ef35996b1 [^]
2012-09-25 13:11dmiguelezClosed by => dmiguelez
2012-09-25 13:11dmiguelezNote Added: 0052566
2012-09-25 13:11dmiguelezStatusresolved => closed
2012-09-25 13:34dmiguelezNote Added: 0052571
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052897

Notes
(0050968)
fleroux   
2012-07-29 06:57   
folks have you tested this fix? if not, can i help testing this?
(0052564)
dmiguelez   
2012-09-25 13:10   
Thanks a lot for your help. We've found it really useful.
(0052565)
hgbot   
2012-09-25 13:10   
Repository: erp/devel/pi
Changeset: bd01edf33b85b09616570957afa0662ef35996b1
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 24 17:48:49 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bd01edf33b85b09616570957afa0662ef35996b1 [^]

Fixes issue 21068: Calls Invoicetax_rounding procedure for fixing
tax amount. Contribution from fleroux.

---
M src-db/database/model/triggers/C_INVOICELINETAX_TRG.xml
---
(0052566)
dmiguelez   
2012-09-25 13:11   
Code Review + Testing OK
(0052571)
dmiguelez   
2012-09-25 13:34   
Testing Plan:

1. Go to sales invoice window
2. Click new and select hoteles buenas noches
3. Select the price list "Tarifa de ventas". Must be marked as "Price includes taxes"
4. Save the header
5. Add a discount in the discount tab: 10%
6. Move to lines and select "Agua sin gas 1L"
7. Complete the invoice.
8. Reactivate the invoice
9. Move to tax tab and notice the tax amount is correct:
  9.1 The total gross is 1.53
  9.2 Tax amount is 0.24
  9.3 Taxable amount is 1.29
So 1.53 = 1.29 + 0.24
(0052897)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test