Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0021049 | Openbravo ERP | A. Platform | public | 2012-07-12 16:02 | 2012-07-30 12:40 |
|
| Reporter | jecharri | |
| Assigned To | AugustoMauch | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | 3.0MP14 | Fixed in Version | 3.0MP14 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | Google Chrome |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0021049: Callouts have different behaviour if you push enter or Tab key |
| Description | Callouts have different behaviour if you push enter or Tab key
If you need to execute js code or you want to show a message in a callout, it is imposible if you push in enter and not in Tab key
In function processFICReturn:
-when you push Tab key the code "if (calloutMessages && calloutMessages.length > 0 && calloutMessages[calloutMessages.length - 1].text !== '') {
this.view.messageBar.setMessage(isc.OBMessageBar[calloutMessages[calloutMessages.length - 1].severity], null, calloutMessages[calloutMessages.length - 1].text);
}"
OR
"if (data.jscode) {
length = data.jscode.length;
for (i = 0; i < length; i++) {
eval(data.jscode[i]);
}
}"
is executed but when you push "Enter" or "Save" this isf is "True":
if (this.grid && gridEditInformation && this.grid.getEditRow() !== gridEditInformation.editRow) {
So return is executed and not the neccesary code |
| Steps To Reproduce | Change SL_Order_amt.java by attaced code.
As it can see in lines 353 I have added next code:
msg = msg + "Muestra el mensaje";
// resultado.append("new Array('JSEXECUTE', 'isc.warn(\"" + msg + "\")')");
resultado.append("new Array('MESSAGE', '" + msg + ")')");
Now is configured to show a message when the callout is executed.
Now do the next executions:
-go to sales order and create a header and one line.
-in grid view edit the line and change the qty--> you will see the message.
-it happens the same in form view
-but now change the qty and push enter or save--> you will not see the message.
It happens the same with js Code.
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  SL_Order_Amt.java (18,572) 2012-07-13 08:47
https://issues.openbravo.com/file_download.php?file_id=5420&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-07-12 16:02 | jecharri | New Issue | |
| 2012-07-12 16:02 | jecharri | Assigned To | => alostale |
| 2012-07-12 16:02 | jecharri | Web browser | => Google Chrome |
| 2012-07-12 16:02 | jecharri | Modules | => Core |
| 2012-07-12 16:02 | jecharri | Resolution time | => 1344808800 |
| 2012-07-12 16:07 | jecharri | Web browser | Google Chrome => Google Chrome |
| 2012-07-12 16:07 | jecharri | Summary | Callouts have different behaviour in you push enter or Tab key => Callouts have different behaviour if you push enter or Tab key |
| 2012-07-12 16:07 | jecharri | Description Updated | bug_revision_view_page.php?rev_id=3628#r3628 |
| 2012-07-13 08:47 | jecharri | File Added: SL_Order_Amt.java | |
| 2012-07-16 18:47 | RafaelCruz | Issue Monitored: RafaelCruz | |
| 2012-07-20 12:59 | AugustoMauch | Assigned To | alostale => AugustoMauch |
| 2012-07-20 12:59 | AugustoMauch | Web browser | Google Chrome => Google Chrome |
| 2012-07-20 12:59 | AugustoMauch | Note Added: 0050781 | |
| 2012-07-20 12:59 | AugustoMauch | Description Updated | bug_revision_view_page.php?rev_id=3644#r3644 |
| 2012-07-20 12:59 | AugustoMauch | Proposed Solution updated | |
| 2012-07-20 13:08 | AugustoMauch | Note Added: 0050782 | |
| 2012-07-26 11:49 | hgbot | Checkin | |
| 2012-07-26 11:49 | hgbot | Note Added: 0050900 | |
| 2012-07-26 11:49 | hgbot | Status | new => resolved |
| 2012-07-26 11:49 | hgbot | Resolution | open => fixed |
| 2012-07-26 11:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/dae17862ff355c9563dfc87b62e3b5c219f8dfbd [^] |
| 2012-07-26 12:11 | hgbot | Checkin | |
| 2012-07-26 12:11 | hgbot | Note Added: 0050902 | |
| 2012-07-27 02:18 | hudsonbot | Checkin | |
| 2012-07-27 02:18 | hudsonbot | Note Added: 0050918 | |
| 2012-07-27 02:18 | hudsonbot | Checkin | |
| 2012-07-27 02:18 | hudsonbot | Note Added: 0050919 | |
| 2012-07-30 12:40 | guilleaer | Note Added: 0050982 | |
| 2012-07-30 12:40 | guilleaer | Status | resolved => closed |
| 2012-07-30 12:40 | guilleaer | Fixed in Version | => 3.0MP14 |
|
Notes |
|
|
|
|
Move Proposed Solution text to the Description section. |
|
|
|
|
|
There is at least one reason why not to show a callout message when the record has been saved and the focus is in another one: The callout message may refer to the record in which the callout was executed, and not make sense for the currently selected record. |
|
|
|
(0050900)
|
|
hgbot
|
|
2012-07-26 11:49
|
|
Repository: erp/devel/pi
Changeset: dae17862ff355c9563dfc87b62e3b5c219f8dfbd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jul 26 11:48:34 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dae17862ff355c9563dfc87b62e3b5c219f8dfbd [^]
Fixes issue 21049: Callout messages are shown even if saving row
Callout messages will be shown always, regardless of if the callout has been called upon tabbing out of the field, saving its row or moving to another row.
To prevent the autosave from hiding the messagebar, now it will do it only if the message bar is showing an error message (as it was supposed to work, looking at the comments).
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
|
|
|
|
(0050902)
|
|
hgbot
|
|
2012-07-26 12:11
|
|
Repository: erp/devel/pi
Changeset: 07e950437362a3313a66317521e193779563e9bd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jul 26 12:10:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/07e950437362a3313a66317521e193779563e9bd [^]
Related to issue 21049: Fixed wrong hardcoded message severity
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Code reviewed and tested in pi@b6862b1e8f54 |
|