Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020955Openbravo ERPA. Platformpublic2012-07-09 10:242012-07-31 16:31
Reporterjecharri 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP14Fixed in Version3.0MP14 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020955: Is impossible to add a selector field in pick/execute windows
DescriptionIs impossible to add a selector field in pick/execute windows
Steps To ReproduceAs "System" go to table "M_RM_Receipt_Pick_Edit"
-go to tab column and find the column "M-locator_id"
-change the reference to "Search" and as "Reference Search Key" put "Locator".

After that got to window "Return Material Receipts" and you will see that window that opens when you push in "Pick/Edit lines" does not work.

 
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0021240 closed AugustoMauch It is not possible to create a Line in Price List Schema 
related to defect 00212303.0MP14 closed mtaal Pick & Execute Windows:Change reference of read only fields to not do combo value computation by FIC 
Attached Filespng Error_Pick_Execute_Standard_Window.png (103,494) 2012-07-09 10:24
https://issues.openbravo.com/file_download.php?file_id=5367&type=bug
png

diff 20955_storage_bin_search.diff (3,279) 2012-07-18 10:10
https://issues.openbravo.com/file_download.php?file_id=5449&type=bug
diff 20955_storage_bin_selector.diff (9,028) 2012-07-18 10:10
https://issues.openbravo.com/file_download.php?file_id=5450&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-07-09 10:24jecharriNew Issue
2012-07-09 10:24jecharriAssigned To => alostale
2012-07-09 10:24jecharriFile Added: Error_Pick_Execute_Standard_Window.png
2012-07-09 10:24jecharriWeb browser => Google Chrome
2012-07-09 10:24jecharriModules => Core
2012-07-09 10:24jecharriResolution time => 1344376800
2012-07-09 11:02maria_perezIssue Monitored: maria_perez
2012-07-18 10:10mtaalFile Added: 20955_storage_bin_search.diff
2012-07-18 10:10mtaalFile Added: 20955_storage_bin_selector.diff
2012-07-18 10:12mtaalNote Added: 0050711
2012-07-18 11:42hgbotCheckin
2012-07-18 11:42hgbotNote Added: 0050715
2012-07-18 13:24RafaelCruzIssue Monitored: RafaelCruz
2012-07-21 16:44mtaalAssigned Toalostale => mtaal
2012-07-21 16:45hgbotCheckin
2012-07-21 16:45hgbotNote Added: 0050785
2012-07-21 16:45hgbotStatusnew => resolved
2012-07-21 16:45hgbotResolutionopen => fixed
2012-07-21 16:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eaa06f5b8081412b36e04f1d016aad050f091e09 [^]
2012-07-24 17:38iperdomoStatusresolved => new
2012-07-24 17:38iperdomoResolutionfixed => open
2012-07-24 17:43hgbotCheckin
2012-07-24 17:43hgbotNote Added: 0050815
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050850
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050868
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050875
2012-07-27 00:46hgbotCheckin
2012-07-27 00:46hgbotNote Added: 0050915
2012-07-27 00:46hgbotStatusnew => resolved
2012-07-27 00:46hgbotResolutionopen => fixed
2012-07-27 00:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/eaa06f5b8081412b36e04f1d016aad050f091e09 [^] => http://code.openbravo.com/erp/devel/pi/rev/47c45f7b7ef706ba92aaf0bfaca5f4ed3f5d9e72 [^]
2012-07-27 14:04AugustoMauchRelationship addedrelated to 0021240
2012-07-27 14:33hgbotCheckin
2012-07-27 14:33hgbotNote Added: 0050946
2012-07-27 14:33AugustoMauchNote Added: 0050948
2012-07-27 14:33AugustoMauchStatusresolved => new
2012-07-27 14:33AugustoMauchResolutionfixed => open
2012-07-27 15:37hgbotCheckin
2012-07-27 15:37hgbotNote Added: 0050952
2012-07-27 16:53mtaalRelationship addedrelated to 0021230
2012-07-27 16:54mtaalStatusnew => scheduled
2012-07-27 16:54mtaalNote Added: 0050955
2012-07-27 16:54mtaalfix_in_branch => pi
2012-07-27 16:54mtaalNote Added: 0050956
2012-07-27 16:54mtaalStatusscheduled => resolved
2012-07-27 16:54mtaalFixed in Version => 3.0MP14
2012-07-27 16:54mtaalResolutionopen => fixed
2012-07-28 01:23hudsonbotCheckin
2012-07-28 01:23hudsonbotNote Added: 0050959
2012-07-28 01:23hudsonbotCheckin
2012-07-28 01:23hudsonbotNote Added: 0050964
2012-07-28 01:23hudsonbotCheckin
2012-07-28 01:23hudsonbotNote Added: 0050966
2012-07-31 16:31AugustoMauchNote Added: 0051034
2012-07-31 16:31AugustoMauchStatusresolved => closed

Notes
(0050711)
mtaal   
2012-07-18 10:12   
The 2 attached files each provide a different solution for this, one diff implements using a Search reference, one diff implements the solution using a Selector reference.

The selector reference requires some more changes to correctly handle the selector and the warehouse filtering.

A choice has to be made which approach to follow. Note that it can still make sense to apply both diffs as then both search and selector references are possible in pick-and-execute windows.
(0050715)
hgbot   
2012-07-18 11:42   
Repository: erp/devel/pi
Changeset: 2f16fe6889ef593b5da9b51bd24a204f2577c2cd
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jul 18 11:41:51 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2f16fe6889ef593b5da9b51bd24a204f2577c2cd [^]

Related to issue 20955: Is impossible to add a selector field in pick/execute windows
Added selector definition and several changes to let selector work correctly with _identifier field

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-search.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0050785)
hgbot   
2012-07-21 16:45   
Repository: erp/devel/pi
Changeset: eaa06f5b8081412b36e04f1d016aad050f091e09
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Jul 21 16:45:02 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eaa06f5b8081412b36e04f1d016aad050f091e09 [^]

Fixes issue 20955: Is impossible to add a selector field in pick/execute windows
Make sure that changes are saved to local record and that the valuemap is being re-used to ensure visualizing the selected record

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
---
(0050815)
hgbot   
2012-07-24 17:43   
Repository: erp/devel/pi
Changeset: 6d9538a0098aeebb5af7d0968700bf5ccd525831
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Jul 24 17:42:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6d9538a0098aeebb5af7d0968700bf5ccd525831 [^]

Issue 20955: Rollback changeset eaa06f5b8081
This changeset breaks Editable Payment Plan

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
---
(0050850)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050868)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050875)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050915)
hgbot   
2012-07-27 00:46   
Repository: erp/devel/pi
Changeset: 47c45f7b7ef706ba92aaf0bfaca5f4ed3f5d9e72
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Jul 27 00:22:16 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/47c45f7b7ef706ba92aaf0bfaca5f4ed3f5d9e72 [^]

Fixes issue 20955: Is impossible to add a selector field in pick/execute windows
Make sure that the valuemap contains the value of the edited record, transfer the valuemap from the edit item to the grid field

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0050946)
hgbot   
2012-07-27 14:33   
Repository: erp/devel/pi
Changeset: 59becbb7d3cc0d01bf882546ecbafa271596471a
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Jul 27 14:32:30 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/59becbb7d3cc0d01bf882546ecbafa271596471a [^]

Fixes issue 21240, related to issue 20955: Changeset backout

The changeset https://code.openbravo.com/erp/devel/pi/rev/47c45f7b7ef7 [^] has been backed out, because it caused a regression.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0050948)
AugustoMauch   
2012-07-27 14:33   
The last changeset had to be backed out because it caused https://issues.openbravo.com/view.php?id=21240 [^]
(0050952)
hgbot   
2012-07-27 15:37   
Repository: erp/devel/pi
Changeset: a0496efc26eb4478fcb4056f0ec4be2ace36fb4d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Jul 27 15:37:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a0496efc26eb4478fcb4056f0ec4be2ace36fb4d [^]

Related to issue 20955: Is impossible to add a selector field in pick/execute windows
Improve valuemap handling for selector and list item for when handling empty value or when clearing the field by keyboard

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0050955)
mtaal   
2012-07-27 16:54   
Scheduled
(0050956)
mtaal   
2012-07-27 16:54   
Fixed
(0050959)
hudsonbot   
2012-07-28 01:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c6491bd9e10b [^]

Maturity status: Test
(0050964)
hudsonbot   
2012-07-28 01:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c6491bd9e10b [^]

Maturity status: Test
(0050966)
hudsonbot   
2012-07-28 01:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c6491bd9e10b [^]

Maturity status: Test
(0051034)
AugustoMauch   
2012-07-31 16:31   
Code reviewed and verified in pi@f9d149854a7f