0020921: New instances shouldn't use legacy cost engine

Openbravo Issue Tracking System - Openbravo ERP
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0020921	Openbravo ERP	04. Warehouse management	public	2012-07-03 18:35	2012-07-10 10:35

Reporter	gorkaion
Assigned To	naiaramartinez
Priority	immediate	Severity	major	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version	3.0MP13	Fixed in Version
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
Modules	Core
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0020921: New instances shouldn't use legacy cost engine
Description	When a new Openbravo instance is created without any client it shouldn't be possible to start using the legacy engine.
Steps To Reproduce	Delete F&B and QA Testing clients. Create a new client. Try to create a new costing entry for a product using the Standard Legacy cost type.
Proposed Solution	The instance should be considered as migrated when there are validated costing rules or when not exists any entry in the m_costing table. Needed changes: 1. Create a module script that creates a "Cost Migrated" preference. 2. Modify Costing Status singleton class: * To determine the status based on the existence of the preference. * Modify the setMigrated method to create the preference. 3. Remove existing isMigrated auxiliar inputs and modify related display logics and validations to use the preference. 4. Modify M_Generate_Average_Cost, MA_WorkEffort_validate and MA_Production_Cost_Generate to change the migration check to the existence of the new preference. 5. Modify the trigger on the M_Costing table to void the insertions of records using cost type 'AV', 'ST' and 'AVO' when the instance is migrated.
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2012-07-03 18:35	gorkaion	New Issue
2012-07-03 18:35	gorkaion	Assigned To	=> naiaramartinez
2012-07-03 18:35	gorkaion	Modules	=> Core
2012-07-03 21:21	dmitry_mezentsev	Note Added: 0050345
2012-07-05 13:03	naiaramartinez	Note Added: 0050371
2012-07-05 13:10	naiaramartinez	Note Edited: 0050371	bug_revision_view_page.php?bugnote_id=0050371#r3594
2012-07-05 13:30	naiaramartinez	Note Edited: 0050371	bug_revision_view_page.php?bugnote_id=0050371#r3595
2012-07-05 13:38	naiaramartinez	Note Edited: 0050371	bug_revision_view_page.php?bugnote_id=0050371#r3596
2012-07-05 13:45	naiaramartinez	Note Edited: 0050371	bug_revision_view_page.php?bugnote_id=0050371#r3597
2012-07-05 13:47	naiaramartinez	Note Edited: 0050371	bug_revision_view_page.php?bugnote_id=0050371#r3598
2012-07-05 18:27	Sandrahuguet	Note Added: 0050378
2012-07-05 18:32	hgbot	Checkin
2012-07-05 18:32	hgbot	Note Added: 0050379
2012-07-05 18:32	hgbot	Status	new => resolved
2012-07-05 18:32	hgbot	Resolution	open => fixed
2012-07-05 18:32	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/4b990d5f82bc44560200aec6ab76a1bbb876f121 [^]
2012-07-05 18:46	Sandrahuguet	Note Added: 0050380
2012-07-05 18:46	Sandrahuguet	Status	resolved => closed
2012-07-10 10:35	hudsonbot	Checkin
2012-07-10 10:35	hudsonbot	Note Added: 0050427

Notes

Test Plan1:
Having MP12 instance:
   -Execute install.source without F&B and QAAdmin
   -Update the instance to MP13
   -Check that the preference 'Cost_Eng_Ins_Migrated' has been created (Client 0 and Organization 0).

Test Plan2:
Having MP12 instance:
   -Execute install.source with F&B and QAAdmin
   -Update the instance to MP13
   -Check that the preference 'Cost_Eng_Ins_Migrated' does not exist.

Test Plan3:
Having MP13 instance(https://issues.openbravo.com/view.php?id=20898 [^] fix must be applied):
   -Execute install.source
   -Check that the preference 'Cost_Eng_Ins_Migrated' exists

Test Plan4:
  Having MP13 instance:
   -Execute install.source without F&B and QAAdmin
   -Check that the preference 'Cost_Eng_Ins_Migrated' exists

Test Plan5:
  Having the preference 'Cost_Eng_Ins_Migrated' created:
   - Go to product window and check that 'cost type' and 'Standard cost' fields are not shown.
   - Go to costing tab. Check that in 'Cost type' combo, you can only see Standard and Average options.

Test Plan6:
  Not Having the preference 'Cost_Eng_Ins_Migrated' created:
   - Go to product window and check that 'cost type' and 'Standard cost' fields are shown.
   - Go to costing tab. Check that in 'Cost type' combo, you can only see Legacy Standard and Legacy Average options.

Test Plan7:
   Having the preference 'Cost_Eng_Ins_Migrated' created:
    - Go to Generate Average Cost. You cannot execute that process.

Test Plan8:
   Not Having the preference 'Cost_Eng_Ins_Migrated' created:
    - Go to Generate Average Cost. You can execute that process.

Test Plan9:
   Having the preference 'Cost_Eng_Ins_Migrated' created:
    - Activate the professional instance
    - Go to work Effort window and fill all the setting for being able to execute it. Finally, you won't be able to execute it because you have the preference created.

Test Plan10:
   Not Having the preference 'Cost_Eng_Ins_Migrated' created:
    - Activate the professional instance
    - Go to work Effort window and fill all the setting for being able to execute it. Finally, you will be able to execute it.

Test Plan11:
   Having the preference 'Cost_Eng_Ins_Migrated' created:
     -Go to Create Production Costs. check that you can't execute that process.

Test Plan12:
   Not Having the preference 'Cost_Eng_Ins_Migrated' created:
     -Go to Create Production Costs. check that you can execute that process.