Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020886Openbravo ERP00. Application dictionarypublic2012-06-28 11:472012-08-24 08:19
Reportermarvintm 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020886: A new test in the API check should be added to test specific case when adding columns to the AD_Module table
DescriptionIn Openbravo there is a mirror table for AD_Module called AD_Module_Install (And also for AD_Module_Dependency, and AD_Module_DBprefix).

Mandatory columns in AD_Module should also exist in AD_Module_Install. This is a "hidden" rule, which currently is not explicit anywhere.

It would be very useful if the API-check checked for this rule, and failed if it our code didn't comply with it.
Steps To Reproduce- Add a mandatory column to AD_Module with an oncreatedefault. Do not add it to AD_Module_Install.
- Attempt to install a module and rebuild. The process will fail.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-28 11:47marvintmNew Issue
2012-06-28 11:47marvintmAssigned To => marvintm
2012-06-28 11:47marvintmModules => Core
2012-06-28 12:02shuehnerIssue Monitored: shuehner
2012-08-21 10:20AugustoMauchAssigned Tomarvintm => AugustoMauch
2012-08-21 12:37AugustoMauchClosed by => marvintm
2012-08-21 12:47hgbotCheckin
2012-08-21 12:47hgbotNote Added: 0051424
2012-08-21 12:47hgbotStatusnew => resolved
2012-08-21 12:47hgbotResolutionopen => fixed
2012-08-21 12:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/33ed73f020808cef2b55cc0d6075f2163f58730d [^]
2012-08-21 12:54hgbotCheckin
2012-08-21 12:54hgbotNote Added: 0051425
2012-08-21 12:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/33ed73f020808cef2b55cc0d6075f2163f58730d [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/bd6d492f6742e9cb6b6830d8cd38480b81e22d14 [^]
2012-08-24 08:19marvintmStatusresolved => closed
2012-08-24 08:19marvintmFixed in Version => 3.0MP15

Notes
(0051424)
hgbot   
2012-08-21 12:47   
Repository: erp/devel/pi
Changeset: 33ed73f020808cef2b55cc0d6075f2163f58730d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Aug 21 12:42:49 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/33ed73f020808cef2b55cc0d6075f2163f58730d [^]

Fixes issue 20886: API check updated to check missing mandatory ad_module columns

A check has been added to throw an error if a mandatory column is added to ad_module but not to ad_module_install

---
M src-db/database/lib/dbsourcemanager.jar
---
(0051425)
hgbot   
2012-08-21 12:54   
Repository: erp/devel/dbsm-main
Changeset: bd6d492f6742e9cb6b6830d8cd38480b81e22d14
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Aug 21 12:53:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/bd6d492f6742e9cb6b6830d8cd38480b81e22d14 [^]

Fixes issue 20886: API check updated to check missing mandatory ad_module columns

---
M src/org/openbravo/ddlutils/util/ValidateAPIModel.java
---