Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020850Openbravo ERP01. General setuppublic2012-06-25 11:062012-07-27 02:18
Reportercaristu 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP14Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020850: Alert Hour is not displayed correctly
DescriptionThe alert time shown in [Alert Management] window is not showing the correct hour. The date is correct, but the hour in not. Also the minutes and seconds always are equal to 0.
Steps To Reproduce1) With the group admin role, create an alert in [Alert] Window, in [Alert Recipient] tab insert a row with the group admin role as recipient.
2) As system administrator role, go to [Process Request] Window and verify that the alert process is in scheduled state.
3) Switch to group admin role again, go to the [Alert Management] window and check the time of the new generated alert.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue20850.diff (6,993) 2012-07-19 13:09
https://issues.openbravo.com/file_download.php?file_id=5457&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-06-25 11:06caristuNew Issue
2012-06-25 11:06caristuAssigned To => mirurita
2012-06-25 11:06caristuModules => Core
2012-06-25 11:06caristuResolution time => 1346968800
2012-06-25 11:09caristuIssue Monitored: networkb
2012-06-25 13:23jonalegriaesarteAssigned Tomirurita => alostale
2012-07-13 12:15AugustoMauchNote Added: 0050553
2012-07-19 13:09AugustoMauchFile Added: issue20850.diff
2012-07-19 13:18AugustoMauchAssigned Toalostale => AugustoMauch
2012-07-26 16:58hgbotCheckin
2012-07-26 16:58hgbotNote Added: 0050910
2012-07-26 16:58hgbotStatusnew => resolved
2012-07-26 16:58hgbotResolutionopen => fixed
2012-07-26 16:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eea99f760fd9c6e8aaba989e56bb3fdf8b741f58 [^]
2012-07-26 17:51caristuNote Added: 0050914
2012-07-26 17:51caristuStatusresolved => closed
2012-07-27 02:18hudsonbotCheckin
2012-07-27 02:18hudsonbotNote Added: 0050923

Notes
(0050553)
AugustoMauch   
2012-07-13 12:15   
The root of this issue is the way AlertProcessData is generated.

In the selectAlert method of AlertProcess_data, the line
TO_DATE(NULL) AS CREATED is translated into
created = UtilSql.getDateValue(result, "created", "dd-MM-yyyy");, taking the date format from the DateFormat of Openbravo.properties.
(0050910)
hgbot   
2012-07-26 16:58   
Repository: erp/devel/pi
Changeset: eea99f760fd9c6e8aaba989e56bb3fdf8b741f58
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jul 26 16:57:07 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eea99f760fd9c6e8aaba989e56bb3fdf8b741f58 [^]

Fixes issue 20850: Alert hour is displayed correctly

The alert hour was not being saved correctly because of the way sqlc.java generates processAlertData.java. Even though the column in the database is a timestamp, in the select and in the insert functions the date format was being used, instead of the date time format.

It was not possible to fix it modifying the xsql file, and it was very risky to modify Sqlc.java, so now ProcessAlerts.java use jdbc to select and insert the alerts.

---
M src-core/src/org/openbravo/data/UtilSql.java
M src/org/openbravo/erpCommon/ad_process/AlertProcess.java
---
(0050914)
caristu   
2012-07-26 17:51   
Verified
(0050923)
hudsonbot   
2012-07-27 02:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cfe6f4cd84a [^]

Maturity status: Test