Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0002084Openbravo ERPZ. Otherspublic2007-10-15 10:032008-07-02 17:17
user71 
alostale 
normalminoralways
closedfixed 
5
 
2.40beta 
No
Core
No
0002084: System.gc() should never be called
Openbravo starts a thread that explictly invokes the garbage collector and finalization functions.

This is not good practice & won't actually help clean up database connections.
In addition it means that there is a thread running that won't be shutdown properly when the app is undeployed or redeployed.

I think the PeriodicGarbageCollector class should be removed entirely.
No tags attached.
depends on backport 0004151 closed gorka_gil System.gc() should never be called 
Issue History
2008-06-24 16:47cromeroStatusclosed => new
2008-06-24 16:47cromeroResolutionfixed => open
2008-06-24 16:47cromeroFixed in Version2.40alpha-r2 =>
2008-06-24 16:47cromeroStatusnew => scheduled
2008-06-24 16:48cromeroStatusscheduled => resolved
2008-06-24 16:48cromerosvn_revision => 2033
2008-06-24 16:48cromeroResolutionopen => fixed
2008-06-24 16:48cromeroStatusresolved => closed
2008-06-24 16:51cromeroStatusclosed => new
2008-06-24 16:51cromeroResolutionfixed => open
2008-06-24 16:51cromeroStatusnew => scheduled
2008-06-24 16:51cromeroStatusscheduled => resolved
2008-06-24 16:51cromeroResolutionopen => fixed
2008-06-24 17:41cromeroStatusresolved => new
2008-06-24 17:41cromeroResolutionfixed => open
2008-06-24 17:42cromeroStatusnew => scheduled
2008-06-24 17:42cromeroStatusscheduled => resolved
2008-06-24 17:42cromeroFixed in Version => 2.40alpha-r2
2008-06-24 17:42cromeroResolutionopen => fixed
2008-07-02 17:17plujanStatusresolved => closed
2008-07-02 17:17plujanFixed in Version2.40alpha-r2 => 2.40beta

Notes
(0005673)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1813644 [^]
(0002361)
user71   
2007-10-16 08:29   
(edited on: 2008-06-12 09:22)
Logged In: YES
user_id=1737231
Originator: YES

File Added: garbage_collector.patch
(0002362)
villind   
2008-01-17 15:21   
(edited on: 2008-06-12 09:22)
Logged In: YES
user_id=61737
Originator: NO

Fixed in trunk revision 2033. Garbage collector thread removed.
(0002363)
psarobe   
2008-06-04 17:09   
(edited on: 2008-06-12 09:22)
Logged In: YES
user_id=1500703
Originator: NO

After searching for System.gc(), no results found