Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020827Openbravo ERPA. Platformpublic2012-06-21 16:332012-06-27 05:29
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP13 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2012-06-15
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/2c50e12c22aaa63d3b8660262965ff6687540713 [^]
Triggers an Emergency PackNo
Summary0020827: Not possible to add new columns to ad_column table
DescriptionWhen adding any new column to ad_column table this error is raised:

Not allowed column name "Length" is a reserved java keyword.
Steps To Reproduce-Add a new column in DB to ad_column
-In Tables and Column window execute Create columns from DB process -> error is raisen
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00203653.0MP13 closed migueldejuana 'Length' word is not included on AD_ISJAVAWORD function to avoid to use it on column names 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-21 16:33alostaleNew Issue
2012-06-21 16:33alostaleAssigned To => alostale
2012-06-21 16:33alostaleModules => Core
2012-06-21 16:33alostaleOBNetwork customer => No
2012-06-21 16:34alostaleRelationship addedrelated to 0020365
2012-06-21 16:36alostaleRegression level => Pre packaging ( pi )
2012-06-21 16:36alostaleRegression date => 2012-06-15
2012-06-21 16:36alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/2c50e12c22aaa63d3b8660262965ff6687540713 [^]
2012-06-21 16:38alostaleNote Added: 0049995
2012-06-22 09:00hgbotCheckin
2012-06-22 09:00hgbotNote Added: 0050007
2012-06-22 09:00hgbotStatusnew => resolved
2012-06-22 09:00hgbotResolutionopen => fixed
2012-06-22 09:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4152ff6e040d482c19c62666ac07433caa412079 [^]
2012-06-22 17:17AugustoMauchNote Added: 0050044
2012-06-22 17:17AugustoMauchStatusresolved => closed
2012-06-22 17:17AugustoMauchFixed in Version => 3.0MP13
2012-06-27 05:29hudsonbotCheckin
2012-06-27 05:29hudsonbotNote Added: 0050155

Notes
(0049995)
alostale   
2012-06-21 16:38   
The problem is there are already columns with name 'length'. As per issue 0020365, the only check that should be performed is ad_column.columnname, the rest of checks: ad_column.name, field, element are unneeded and cause this issue.
(0050007)
hgbot   
2012-06-22 09:00   
Repository: erp/devel/pi
Changeset: 4152ff6e040d482c19c62666ac07433caa412079
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jun 22 08:58:59 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4152ff6e040d482c19c62666ac07433caa412079 [^]

fixed bug 20827: Not possible to add new columns to ad_column table
related to bug 20365

  Partially backed out fix 0020365: field and element are not checked,
  just ad_column.columnname is checked with a different function to allow names
  that can be included for ad_colum.name.

---
M src-db/database/model/functions/AD_ISJAVAWORD.xml
M src-db/database/model/triggers/AD_COLUMN_TRG2.xml
M src-db/database/model/triggers/AD_ELEMENT_TRG.xml
M src-db/database/model/triggers/AD_FIELD_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/model/functions/AD_ISJAVASCRIPTWORD.xml
---
(0050044)
AugustoMauch   
2012-06-22 17:17   
Code reviewed and verified in pi@f06b2e72932e
(0050155)
hudsonbot   
2012-06-27 05:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test