Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0020822 | Openbravo ERP | A. Platform | public | 2012-06-21 09:51 | 2012-09-03 13:28 |
|
| Reporter | ioritzCia | |
| Assigned To | marvintm | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | Ubuntu 10.04 |
| Product Version | | |
| Target Version | 3.0MP15 | Fixed in Version | 3.0MP15 | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | |
| Web browser | Google Chrome, Mozilla Firefox |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0020822: Dataset applying process leads to an error situation. |
| Description | System/client access level entity dataset can lead to an erroneous situation concerning dataset application. |
| Steps To Reproduce | - Take a system/client access level entity dataset as regions and import it into client A. Information is inserted in ad_ref_data_loaded with generic_id = specific_id for regions.
- Take this dataset and now apply it to system level. Information is inserted in ad_ref_data_loaded with generic_id and specific_id=new_uuid.
- Now apply a client access level entity dataset which entity depends on the previous system/client access level entity for client A. For example taxes, that depend on regions. It works fine because there are regions for this client with generic_ids.
- After that, log in with client B and try to apply this second dependant dataset. This should work as the regions dataset has been applied to system level. It does not due to the dataset applying procedure.
- This procedure will try to look into ad_ref_dataloaded but in his client and it will not find them.
- Then, it will look for the generic_id into system access level data it will not find them and it will not try to look into ad_ref_data_loaded with system access level where it would find them.
- As it hasn't been able to find the regions which are referenced by the taxes, the process will fail. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  fixresolver.diff (1,233) 2012-07-04 16:01
https://issues.openbravo.com/file_download.php?file_id=5351&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-06-21 09:51 | ioritzCia | New Issue | |
| 2012-06-21 09:51 | ioritzCia | Assigned To | => alostale |
| 2012-06-21 09:51 | ioritzCia | Web browser | => Google Chrome, Mozilla Firefox |
| 2012-06-21 09:51 | ioritzCia | Modules | => Core |
| 2012-06-21 09:57 | marvintm | Web browser | Google Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox |
| 2012-06-21 09:57 | marvintm | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=3562#r3562 |
| 2012-07-04 14:33 | shuehner | Issue Monitored: shuehner | |
| 2012-07-04 14:34 | shuehner | Web browser | Google Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox |
| 2012-07-04 14:34 | shuehner | Note Added: 0050349 | |
| 2012-07-04 14:34 | shuehner | Target Version | => 3.0MP14 |
| 2012-07-04 16:01 | marvintm | File Added: fixresolver.diff | |
| 2012-07-04 16:02 | marvintm | Note Added: 0050350 | |
| 2012-08-01 12:48 | marvintm | Web browser | Google Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox |
| 2012-08-01 12:48 | marvintm | Target Version | 3.0MP14 => 3.0MP15 |
| 2012-08-20 17:25 | marvintm | Assigned To | alostale => marvintm |
| 2012-08-20 17:37 | hgbot | Checkin | |
| 2012-08-20 17:37 | hgbot | Note Added: 0051398 | |
| 2012-08-20 17:37 | hgbot | Status | new => resolved |
| 2012-08-20 17:37 | hgbot | Resolution | open => fixed |
| 2012-08-20 17:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/57f229938edf25aad9d55473eb116550d10c7c65 [^] |
| 2012-09-03 13:28 | AugustoMauch | Closed by | => AugustoMauch |
| 2012-09-03 13:28 | AugustoMauch | Note Added: 0051769 | |
| 2012-09-03 13:28 | AugustoMauch | Status | resolved => closed |
| 2012-09-03 13:28 | AugustoMauch | Fixed in Version | => 3.0MP15 |
|
Notes |
|
|
|
|
Adding target version MP14 as after discussion with AMO+DME should be done as soon as possible. |
|
|
|
|
|
I've added a diff which contains a fix for this issue. It needs to be reviewed to verify that it is correct in all cases. |
|
|
|
(0051398)
|
|
hgbot
|
|
2012-08-20 17:37
|
|
Repository: erp/devel/pi
Changeset: 57f229938edf25aad9d55473eb116550d10c7c65
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Aug 20 17:35:10 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/57f229938edf25aad9d55473eb116550d10c7c65 [^]
Fixed issue 20822. Changed slightly how reference data is applied.
- Before, for System/Client tables, it was assumed that the 'system' part should be searched just by id. This is unfortunately wrong, as it could happen that data in the same table could be loaded as 'client', and after that, as 'system'. In this situation, the data loaded as system would have different ids.
- The fix basically consists in searching the data at system level using the AD_Ref_Data_Loaded information. Retrieving the records this way will ensure that the correct ids are used, and that data at System/Client tables is correctly found.
---
M src/org/openbravo/dal/xml/EntityResolver.java
---
|
|
|
|
|
|
Code reviewed and verified in pi@288baadd3b3c |
|