Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020789Openbravo ERPI. Performancepublic2012-06-18 11:252012-06-27 05:28
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP13 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020789: TriggerHandler currently flushes the DAL connection when disabling and enabling triggers
DescriptionThis can cause performance problems if the triggers need to be disabled and enabled during a sub-process which is repeated multiple times.

Steps To ReproduceThis can cause performance problems if the triggers need to be disabled and enabled during a sub-process which is repeated multiple times.

Proposed Solution
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-18 11:25marvintmNew Issue
2012-06-18 11:25marvintmAssigned To => marvintm
2012-06-18 11:25marvintmModules => Core
2012-06-18 11:25marvintmOBNetwork customer => No
2012-06-18 11:28alostaleTag Attached: Performance
2012-06-18 11:32hgbotCheckin
2012-06-18 11:32hgbotNote Added: 0049883
2012-06-18 11:32hgbotStatusnew => resolved
2012-06-18 11:32hgbotResolutionopen => fixed
2012-06-18 11:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/70514770c8717c4984c4616285db532db7a784df [^]
2012-06-25 11:14AugustoMauchNote Added: 0050058
2012-06-25 11:17AugustoMauchNote Added: 0050059
2012-06-25 11:17AugustoMauchStatusresolved => closed
2012-06-25 11:17AugustoMauchFixed in Version => 3.0MP13
2012-06-27 05:28hudsonbotCheckin
2012-06-27 05:28hudsonbotNote Added: 0050110

Notes
(0049883)
hgbot   
2012-06-18 11:32   
Repository: erp/devel/pi
Changeset: 70514770c8717c4984c4616285db532db7a784df
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jun 18 11:32:16 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/70514770c8717c4984c4616285db532db7a784df [^]

Fixed issue 20789. Removed flushes when disabling/enabling triggers in TriggerHandler to improve performance

---
M src/org/openbravo/dal/core/TriggerHandler.java
---
(0050058)
AugustoMauch   
2012-06-25 11:14   
changeset: 16908:a95907cb54ce
tag: tip
user: Antonio Moreno <antonio.moreno@openbravo.com>
date: Mon Jun 25 10:56:21 2012 +0200
files: src/org/openbravo/dal/core/TriggerHandler.java
description:
Related to 20789. Now the setting of the ThreadLocal will happen inside the try/catch
(0050059)
AugustoMauch   
2012-06-25 11:17   
Code reviewed and verified pi@a95907cb54ce
(0050110)
hudsonbot   
2012-06-27 05:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test