Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020780Openbravo ERPA. Platformpublic2012-06-15 10:122012-07-30 11:00
Reporterjecharri 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP14Fixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020780: Bug in HBFix_data.xsql insert statement
Descriptionfollowing code:
<SqlMethod name="insert" type="preparedStatement" return="rowCount">
<Sql>
<![CDATA[
INSERT INTO ad_process_request
VALUES (get_uuid(), '0', '0', 'Y',
NOW(), '100', NOW(), '100', '1005800000',
NULL, '100', 'Y', ? ,
'SCH', NULL, NULL, NULL, 'Process Scheduler', 'S', NOW(),
NOW(), '4', NULL, NULL, NULL, 7, NULL, NULL, NULL, 'N', 'N', 'N', 'N', 'N', 'N','N', 'S', NULL, NULL, 'N', NULL, NULL, 'N', NULL, NULL, 'N', 'N', 'N', NULL)]]>
The insert statement tries to insert into ad_process_request table without specifying columns, so if a module adds a new column to the table, the
insert statement fails
Steps To Reproduce-
Proposed SolutionThe solution is to change the insert statement to:

INSERT INTO ad_process_request(ad_process_request_id, ad_client_id, ad_org_id, ... [name of all core columns] ) VALUES (get_uuid(), etc.)
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-15 10:12jecharriNew Issue
2012-06-15 10:12jecharriAssigned To => alostale
2012-06-15 10:12jecharriWeb browser => Google Chrome
2012-06-15 10:12jecharriModules => Core
2012-06-15 10:12jecharriResolution time => 1339538400
2012-07-18 13:23shuehnerIssue Monitored: shuehner
2012-07-25 15:55AugustoMauchAssigned Toalostale => AugustoMauch
2012-07-25 15:58hgbotCheckin
2012-07-25 15:58hgbotNote Added: 0050837
2012-07-25 15:58hgbotStatusnew => resolved
2012-07-25 15:58hgbotResolutionopen => fixed
2012-07-25 15:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c7f7fd1bcc69afe5349820fb3204aa99c15e0984 [^]
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050885
2012-07-30 11:00migueldejuanaNote Added: 0050978
2012-07-30 11:00migueldejuanaStatusresolved => closed
2012-07-30 11:00migueldejuanaFixed in Version => pi

Notes
(0050837)
hgbot   
2012-07-25 15:58   
Repository: erp/devel/pi
Changeset: c7f7fd1bcc69afe5349820fb3204aa99c15e0984
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 25 15:58:04 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c7f7fd1bcc69afe5349820fb3204aa99c15e0984 [^]

Fixes issue 20780: Insert statement modified in xsql

The insert statement in HBFix_data.xsql has been modified, and now specifies the columns where the values are being inserted.

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/HBFixData.class
M src-util/modulescript/src/org/openbravo/modulescript/HBFix_data.xsql
---
(0050885)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050978)
migueldejuana   
2012-07-30 11:00   
Code reviewed: b6862b1e8f54.