Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020773Openbravo ERP09. Financial managementpublic2012-06-14 17:122012-06-27 05:28
Reporterdmiguelez 
Assigned Toeduardo_Argal 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0MP13 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020773: Reverse Payment is not working
DescriptionWhen trying to make a Reverse Payment, this message is shown:

ERROR: inserción o actualización en la tabla «fin_payment» viola la llave foránea «fin_payment_reversed» Detail: La llave (fin_rev_payment_id)=(AB3F22346EAC496CB793117AD1850DE1) no está presente en la tabla «fin_payment».
Steps To ReproduceLogin as Openbravo/openbravo

Create a new Sales Invoice.
Complete it.
Add a Payment to it.

Go to Payment In window and select the previous Payment.
Click on Reverse Payment (It may be hidden)

This message is shown:ERROR: inserción o actualización en la tabla «fin_payment» viola la llave foránea «fin_payment_reversed» Detail: La llave (fin_rev_payment_id)=(AB3F22346EAC496CB793117AD1850DE1) no está presente en la tabla «fin_payment».



Proposed Solutiondiff --git a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
@@ -521,19 +521,21 @@
           OBDal.getInstance().save(reversedPayment);
 
           OBDal.getInstance().flush();
+
+ HashMap<String, Object> parameterMap = new HashMap<String, Object>();
+ parameterMap.put("Fin_Payment_ID", reversedPayment.getId());
+ parameterMap.put("action", "P");
+ parameterMap.put("isReversedPayment", "Y");
+ bundle.setParams(parameterMap);
+ execute(bundle);
+ payment.setReversedPayment(reversedPayment);
+ OBDal.getInstance().save(payment);
+ OBDal.getInstance().flush();
+ return;
+
         } finally {
           OBContext.restorePreviousMode();
         }
- HashMap<String, Object> parameterMap = new HashMap<String, Object>();
- parameterMap.put("Fin_Payment_ID", reversedPayment.getId());
- parameterMap.put("action", "P");
- parameterMap.put("isReversedPayment", "Y");
- bundle.setParams(parameterMap);
- execute(bundle);
- payment.setReversedPayment(reversedPayment);
- OBDal.getInstance().save(payment);
- OBDal.getInstance().flush();
- return;
 
         // ***********************
         // Reactivate Payment
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-14 17:12dmiguelezNew Issue
2012-06-14 17:12dmiguelezAssigned To => eduardo_Argal
2012-06-14 17:12dmiguelezModules => Core
2012-06-18 14:10hgbotCheckin
2012-06-18 14:10hgbotNote Added: 0049889
2012-06-18 14:10hgbotStatusnew => resolved
2012-06-18 14:10hgbotResolutionopen => fixed
2012-06-18 14:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0175ac5c9460c3bac64e25274db24bf018a8c296 [^]
2012-06-21 12:23miruritaNote Added: 0049980
2012-06-21 12:23miruritaStatusresolved => closed
2012-06-21 12:23miruritaFixed in Version => 3.0MP13
2012-06-27 05:28hudsonbotCheckin
2012-06-27 05:28hudsonbotNote Added: 0050112

Notes
(0049889)
hgbot   
2012-06-18 14:10   
Repository: erp/devel/pi
Changeset: 0175ac5c9460c3bac64e25274db24bf018a8c296
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Mon Jun 18 14:09:45 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0175ac5c9460c3bac64e25274db24bf018a8c296 [^]

Fixes bug 20773

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0049980)
mirurita   
2012-06-21 12:23   
code review + testing OK

Testing Plan:
1) Display "Reverse Payment" field on Payment In window
2) ant compile.development -Dtab=Payment -Dtr=no
3) Create a new sales invoice
4) Create a new payment in for previous invoice
5) Reverse the payment
(0050112)
hudsonbot   
2012-06-27 05:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test