Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020739Openbravo ERPI. Performancepublic2012-06-12 18:562012-06-28 10:16
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP13 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020739: Performance of the SavePayment and ProcessPayment processes can be improved
DescriptionThere are several changes which can be done to improve the performance of the SavePayment and ProcessPayment processes a bit.
Steps To ReproduceAlthough the SavePayment and ProcessPayment processes performance is reasonably good, it can be slightly improved in several areas. Some examples are:

- Some flushes can be removed.
- A query to find out the maximum line number can be replaced by a query with a max().
- An index can be added to improve said query.
- On if statements, expensive and cheap conditions can be switched. This improves performance in case only the first condition needs to be checked.

Proposed Solution
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-12 18:56marvintmNew Issue
2012-06-12 18:56marvintmAssigned To => marvintm
2012-06-12 18:56marvintmModules => Core
2012-06-12 18:56marvintmOBNetwork customer => No
2012-06-12 19:04hgbotCheckin
2012-06-12 19:04hgbotNote Added: 0049786
2012-06-12 19:04hgbotStatusnew => resolved
2012-06-12 19:04hgbotResolutionopen => fixed
2012-06-12 19:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b6f4ca5411d2d6364de0a2d3f2f4184fc7a6201d [^]
2012-06-13 13:45hgbotCheckin
2012-06-13 13:45hgbotNote Added: 0049812
2012-06-13 16:33hgbotCheckin
2012-06-13 16:33hgbotNote Added: 0049817
2012-06-14 09:33hgbotCheckin
2012-06-14 09:33hgbotNote Added: 0049826
2012-06-14 09:40hgbotCheckin
2012-06-14 09:40hgbotNote Added: 0049827
2012-06-18 09:20alostaleTag Attached: Performance
2012-06-18 11:57hgbotCheckin
2012-06-18 11:57hgbotNote Added: 0049886
2012-06-27 05:28hudsonbotCheckin
2012-06-27 05:28hudsonbotNote Added: 0050111
2012-06-28 10:16miruritaNote Added: 0050245
2012-06-28 10:16miruritaStatusresolved => closed
2012-06-28 10:16miruritaFixed in Version => 3.0MP13

Notes
(0049786)
hgbot   
2012-06-12 19:04   
Repository: erp/devel/pi
Changeset: b6f4ca5411d2d6364de0a2d3f2f4184fc7a6201d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jun 12 18:58:59 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b6f4ca5411d2d6364de0a2d3f2f4184fc7a6201d [^]

Fixed issue 20739. Changes done to improve the Save and Process payment processes:
- An index has been added.
- Instead of reading the organization information list from the organization, a direct query to the orginfo using the org id is done.
- Some flushes (particularly those related to 'processing' columns) have been removed.
- The description of the payment, and the method which updates the editable payment plan, have been disabled in case the order comes from the POS.
- The query to find the maximum line number in the Financial transaction table has been improved.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M src-db/database/model/tables/FIN_FINACC_TRANSACTION.xml
---
(0049812)
hgbot   
2012-06-13 13:45   
Repository: erp/devel/pi
Changeset: 5a22035bcba60ee327761577b114679a8b25566d
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Jun 13 13:45:12 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5a22035bcba60ee327761577b114679a8b25566d [^]

Related to issue 20739. Fixed issue 20749: Not able to add transactions in FA

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0049817)
hgbot   
2012-06-13 16:33   
Repository: erp/devel/pi
Changeset: 0405646fd9b670ea267afb4db50756064420756e
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Jun 13 16:32:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0405646fd9b670ea267afb4db50756064420756e [^]

Related to issue 20739: restore flush() needed

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0049826)
hgbot   
2012-06-14 09:33   
Repository: erp/devel/pi
Changeset: ad966a576648428cdfbe47cc8395169b117e4ed8
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jun 14 09:32:25 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ad966a576648428cdfbe47cc8395169b117e4ed8 [^]

Related to issue 20739. Added quicker methods to disable/enable triggers

---
M src/org/openbravo/dal/core/TriggerHandler.java
---
(0049827)
hgbot   
2012-06-14 09:40   
Repository: erp/devel/pi
Changeset: dbabdb3d37414ccf3a09763c37199556e25dc87d
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu Jun 14 09:39:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dbabdb3d37414ccf3a09763c37199556e25dc87d [^]

Related to issue 20739: max lineno query, handle no trx in FA

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
---
(0049886)
hgbot   
2012-06-18 11:57   
Repository: erp/devel/pi
Changeset: aff7a3034a459d70652923c7187a974c2a3cf97f
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jun 18 11:57:18 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/aff7a3034a459d70652923c7187a974c2a3cf97f [^]

Related to issue 20739. Removed statements instead of commenting them

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0050111)
hudsonbot   
2012-06-27 05:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test
(0050245)
mirurita   
2012-06-28 10:16   
code review + testing OK