0020711: API Change Request - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0020711

Openbravo ERP

05. Production management

public

2012-06-08 12:27

2012-07-26 09:43

Reporter

dmiguelez

Assigned To

dmiguelez

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Community Appliance

Product Version

Target Version

Fixed in Version

3.0MP14

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0020711: API Change Request

Description

In the Product Window,

For validating a BOM there is actually a Database Procedure called M_Product_BOM_Check, that is called from a button.
This procedure is not working as expected, since it can result in false positives when checking for cycles.

The solution I propose to fix it is to create a Java process to replace it, since it will be easier to maintain in the future than a Database procedure because it will reduce the complexity of the procedure.
I propose this change because this procedure is not used anywhere else.
I searched in the application, and in the modules that are in the repository, and it is only used when is called from the button in the Product window.

So, since to fix the issue this procedure must be rewritten almost from scratch, and is not used or called anywhere else, I believe that it would be better to replace it with a Java procedure, easier to maintain.

Then, we can deprecate the database procedure, but it might be better if we just eliminate it, because, as I said, it's not working as expected, and if we deprecate it we won't be supporting it.
So maybe the right call would be to delete it, and support the new Java procedure.

I have checked that this procedure is not used in diferent places. I have checked it also in all the modules of the Central Repository and in two different client's instances

Steps To Reproduce

Login as Openbravo/openbravo

Change rol to QA Testing Admin.

Go to Product Window and create a new Product:
"Organization": USA
"Search Key": PD
"Name": Product D
"Product Category": Bill of Materials
"Bill of Materials": Checked

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material B
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material C
"BOM Quantity": 1

Click on Verify BOM, thenk OK. "Process completed successfully"

Create a new Product:
"Organization": USA
"Search Key": PE
"Name": Product E
"Product Category": Bill of Materials
"Bill of Materials": Checked

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Product E
"BOM Quantity": 1

Click on Verify BOM, thenk OK.
Error "BOM Tree Contains a Cycle"

Proposed Solution

Change the Database Procedure with Java code and delete the Procedure.

Additional Information