Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020669Openbravo ERPZ. Otherspublic2012-06-04 12:042013-08-22 15:08
Reportereduardo_Argal 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP27 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020669: API Checks fails when adding a new set of parameters for a newly added process
DescriptionAPI Checks fails when adding a new set of parameters for a newly added process
Steps To ReproduceAdd a new process to dictionary with a couple of parameters and run api-checks
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-04 12:04eduardo_ArgalNew Issue
2012-06-04 12:04eduardo_ArgalAssigned To => shuehner
2012-06-04 12:04eduardo_ArgalModules => Core
2012-06-04 12:04eduardo_ArgalOBNetwork customer => No
2013-08-16 13:08shuehnerReview Assigned To => AugustoMauch
2013-08-16 13:08shuehnerTriggers an Emergency Pack => No
2013-08-16 13:19shuehnerNote Added: 0060605
2013-08-16 13:23hgbotCheckin
2013-08-16 13:23hgbotNote Added: 0060608
2013-08-16 13:25shuehnerStatusnew => scheduled
2013-08-16 13:25shuehnerfix_in_branch => pi
2013-08-16 13:26shuehnerNote Added: 0060610
2013-08-16 13:26shuehnerStatusscheduled => resolved
2013-08-16 13:26shuehnerFixed in Version => 3.0MP27
2013-08-16 13:26shuehnerFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c76f162b7ab00fa04fafe7d1fa5051133a019a4e [^]
2013-08-16 13:26shuehnerResolutionopen => fixed
2013-08-16 15:18hgbotCheckin
2013-08-16 15:18hgbotNote Added: 0060612
2013-08-16 15:18hgbotCheckin
2013-08-16 15:18hgbotNote Added: 0060613
2013-08-16 15:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c76f162b7ab00fa04fafe7d1fa5051133a019a4e [^] => http://code.openbravo.com/erp/devel/pi/rev/d25616f76844ff441a11fb559cc5a53e926aaa7f [^]
2013-08-20 01:26hudsonbotCheckin
2013-08-20 01:26hudsonbotNote Added: 0060665
2013-08-22 15:08AugustoMauchNote Added: 0060730
2013-08-22 15:08AugustoMauchStatusresolved => closed

Notes
(0060605)
shuehner   
2013-08-16 13:19   
For testing both cases related to insertion should be checked. Adding a new parameter to an existing process (one which exists in the api-checks/model folder) should still be reported as an api-change.

New ad_process_para rows related to a new ad_process entry which does not exist in the reference model should no be reported anymore.
(0060608)
hgbot   
2013-08-16 13:23   
Repository: erp/devel/dbsm-main
Changeset: a5aa6d2b12400e610d40032b8eea65fba0ed35b6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 13:17:33 2013 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/a5aa6d2b12400e610d40032b8eea65fba0ed35b6 [^]

Issue 20669: Accept ad_process_para inserts if related to newly added process
If new ad_process_para entries are added which are related to a new process
added in the same compare run that is an acceptable change as no code can
be affected (as the process is newly added as well).
So only report api-change for existing processes.

---
M src/org/openbravo/ddlutils/util/ValidateAPIData.java
---
(0060610)
shuehner   
2013-08-16 13:26   
Repository: erp/devel/pi
Changeset: c76f162b7ab00fa04fafe7d1fa5051133a019a4e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 13:21:17 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c76f162b7ab00fa04fafe7d1fa5051133a019a4e [^] [^]

Fixed 22176. Fixed 22669. Improve api-check
- Ignore ad_process_para insertions for new added processes as those
  are false positives.
- Report dropping of a not null constraint as api-check as existing
  code may rely on the column having a value.

---
M src-db/database/lib/dbsourcemanager.jar
(0060612)
hgbot   
2013-08-16 15:18   
Repository: erp/devel/dbsm-main
Changeset: adbb2dbfdf95957936ef785751e32b5d9d6525c6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 15:13:17 2013 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/adbb2dbfdf95957936ef785751e32b5d9d6525c6 [^]

Issue 20669: fix wrong logic in last commit

---
M src/org/openbravo/ddlutils/util/ValidateAPIData.java
---
(0060613)
hgbot   
2013-08-16 15:18   
Repository: erp/devel/pi
Changeset: d25616f76844ff441a11fb559cc5a53e926aaa7f
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 15:15:14 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d25616f76844ff441a11fb559cc5a53e926aaa7f [^]

Fixed 20669: fix wrong logic from last commit

---
M src-db/database/lib/dbsourcemanager.jar
---
(0060665)
hudsonbot   
2013-08-20 01:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/28c60a43e596 [^]

Maturity status: Test
(0060730)
AugustoMauch   
2013-08-22 15:08   
Code reviewed and verified in pi@d25616f76844ff441a11fb559cc5a53e926aaa7f