Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0020630Openbravo ERPA. Platformpublic2012-05-29 12:282012-05-30 18:13
marvintm 
marvintm 
normalmajorhave not tried
closedfixed 
5
 
3.0MP12 
Core
No
0020630: smartbuild should not fix the maintenance flag if update.database didn't finish successfully the last time it was run
In Openbravo, if a rebuild doesn't finish successfully, the system enters "maintenance mode", in which the user can only log as system administrator.

Smartbuild can set the flag which disables this mode. However, this currently happens always, regardless of the fact that smartbuild may or may not update (and therefore, fix) the database, depending on whether the flag -Dlocal was used or not.

This can give the user the false sensation that he is safe, whereas in reality, his database may still be broken.
- Initiate update.database, and make it fail at some point in the middle of the process.
- Do smartbuild.
- Restart tomcat.
- Log in Openbravo. Realize that you are not in maintenance mode, but the database is clearly not right.
Smartbuild will only update the maintenance flag if it can find by looking in the current status of the system that the last update.database didn't fail.
No tags attached.
Issue History
2012-05-29 12:28marvintmNew Issue
2012-05-29 12:28marvintmAssigned To => marvintm
2012-05-29 12:28marvintmModules => Core
2012-05-29 12:31hgbotCheckin
2012-05-29 12:31hgbotNote Added: 0049422
2012-05-29 12:31hgbotStatusnew => resolved
2012-05-29 12:31hgbotResolutionopen => fixed
2012-05-29 12:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b87d6a90f2dba83b7e58a8307b1bdd4eabea4d47 [^]
2012-05-29 16:52AugustoMauchNote Added: 0049434
2012-05-29 16:52AugustoMauchStatusresolved => closed
2012-05-29 16:52AugustoMauchFixed in Version => 3.0MP12
2012-05-30 18:13hudsonbotCheckin
2012-05-30 18:13hudsonbotNote Added: 0049507

Notes
(0049422)
hgbot   
2012-05-29 12:31   
Repository: erp/devel/pi
Changeset: b87d6a90f2dba83b7e58a8307b1bdd4eabea4d47
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue May 29 12:30:40 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b87d6a90f2dba83b7e58a8307b1bdd4eabea4d47 [^]

Fixed issue 20630. Maintenance flag will only be set if update.database finished correctly.

---
M build.xml
---
(0049434)
AugustoMauch   
2012-05-29 16:52   
Code reviewed and verified in pi@faec5225c28a
(0049507)
hudsonbot   
2012-05-30 18:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3752a665362c [^]

Maturity status: Test