Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0020591 | Openbravo ERP | Y. DBSourceManager | public | 2012-05-23 15:19 | 2012-05-30 18:13 |
|
| Reporter | marvintm | |
| Assigned To | marvintm | |
| Priority | urgent | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP12 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0020591: update.database should not destroy data if a problem happens when recreating a table |
| Description | Currently, if a problem happens when dbsourcemanager has to recreate a table, the process will delete the original table, and its data will be lost.
This should be clearly avoided. |
| Steps To Reproduce | - Modify a column of a table in the XML, and set it to an illegal value (for example, set the length of a varchar column to a value which is smaller than the data currently in the database).
- Do update.database. Verify that errors appear, but the process continues, and that after it has finished, the table has been deleted, along with its data. |
| Proposed Solution | The process should stop in that case, and a message explaining the problem should be shown. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-05-23 15:19 | marvintm | New Issue | |
| 2012-05-23 15:19 | marvintm | Assigned To | => marvintm |
| 2012-05-23 15:19 | marvintm | Modules | => Core |
| 2012-05-23 15:19 | marvintm | OBNetwork customer | => No |
| 2012-05-28 15:44 | hgbot | Checkin | |
| 2012-05-28 15:44 | hgbot | Note Added: 0049371 | |
| 2012-05-28 15:44 | hgbot | Status | new => resolved |
| 2012-05-28 15:44 | hgbot | Resolution | open => fixed |
| 2012-05-28 15:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/dbsm-main/rev/a6a6f4d9ea32ffea2a7301351660730781cac4c9 [^] |
| 2012-05-28 17:54 | hgbot | Checkin | |
| 2012-05-28 17:54 | hgbot | Note Added: 0049379 | |
| 2012-05-28 17:54 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/dbsm-main/rev/a6a6f4d9ea32ffea2a7301351660730781cac4c9 [^] => http://code.openbravo.com/erp/devel/pi/rev/2f1eca1d8609f493276b969c2733b49463fbc705 [^] |
| 2012-05-29 12:00 | hgbot | Checkin | |
| 2012-05-29 12:00 | hgbot | Note Added: 0049417 | |
| 2012-05-29 12:01 | hgbot | Checkin | |
| 2012-05-29 12:01 | hgbot | Note Added: 0049418 | |
| 2012-05-29 12:09 | AugustoMauch | Note Added: 0049420 | |
| 2012-05-29 12:09 | AugustoMauch | Status | resolved => closed |
| 2012-05-29 12:09 | AugustoMauch | Fixed in Version | => 3.0MP12 |
| 2012-05-30 18:13 | hudsonbot | Checkin | |
| 2012-05-30 18:13 | hudsonbot | Note Added: 0049497 | |
| 2012-05-30 18:13 | hudsonbot | Checkin | |
| 2012-05-30 18:13 | hudsonbot | Note Added: 0049506 | |
|
Notes |
|
|
(0049371)
|
|
hgbot
|
|
2012-05-28 15:44
|
|
Repository: erp/devel/dbsm-main
Changeset: a6a6f4d9ea32ffea2a7301351660730781cac4c9
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 28 15:44:10 2012 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/a6a6f4d9ea32ffea2a7301351660730781cac4c9 [^]
Fixed issue 20591. Fixed issue 20592. Several changes have been made:
- The table creation commands are now considered 'critical'. This means that the process will fail automatically, with an specific message, if one of these commands fails.
- The create fks and triggers methods now return whether there were errors or not during the execution.
- This new boolean is now used by update.database to make the process fail in the end, if some trigger or foreign key was not correctly enabled. This failure is a normal exception which will be detected by the rebuild window as an error in the process.
- Additionally (and unrelated to these issues actually) a new convenient method to load a basic database model which includes only tables has been included.
---
M src/org/apache/ddlutils/Platform.java
M src/org/apache/ddlutils/platform/PlatformImplBase.java
M src/org/apache/ddlutils/platform/SqlBuilder.java
M src/org/apache/ddlutils/platform/oracle/Oracle8Platform.java
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlPlatform.java
M src/org/openbravo/ddlutils/task/AlterDatabaseDataAll.java
M src/org/openbravo/ddlutils/util/DBSMOBUtil.java
---
|
|
|
|
(0049379)
|
|
hgbot
|
|
2012-05-28 17:54
|
|
Repository: erp/devel/pi
Changeset: 2f1eca1d8609f493276b969c2733b49463fbc705
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 28 17:31:44 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2f1eca1d8609f493276b969c2733b49463fbc705 [^]
Fixed issue 20591. Fixed issue 20592. Several changes have been made:
> - The table creation commands are now considered 'critical'. This means that the process will fail automatically, with an specific message, if one of these commands fails.
> - The create fks and triggers methods now return whether there were errors or not during the execution.
> - This new boolean is now used by update.database to make the process fail in the end, if some trigger or foreign key was not correctly enabled. This failure is a normal exception which will be detected by the rebuild window as an error in the process.
> - Additionally (and unrelated to these issues actually) a new convenient method to load a basic database model which includes only tables has been included.
---
M src-db/database/lib/dbsourcemanager.jar
---
|
|
|
|
(0049417)
|
|
hgbot
|
|
2012-05-29 12:00
|
|
|
|
|
(0049418)
|
|
hgbot
|
|
2012-05-29 12:01
|
|
|
|
|
|
|
Code reviewed and verified in pi@5e3ad075603e |
|
|
|
|
|
|
|
|
|