Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020587Openbravo ERPA. Platformpublic2012-05-23 13:002013-04-23 21:03
Reportermirurita 
Assigned Toshankarb 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0MP23 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020587: [Pick&Execute] Mandatory column validation is not working, it allows to execute the process leaving the column empty
DescriptionSee "RFC Order Pick / Edit Lines" window definition.
It has a field "Returned" linked to a mandatory column C_RM_Order_Pick_Edit_Lines.returned

The Pick and Execute window does not validate if the returned field is empty. It allows to execute the process although there are grid lines not having the returned cell filled.
Steps To Reproduce1) Go to Return to Vendor window
2) Create a new record for:
    Org: F&B US, Inc.
    Business Partner: Be Soft Drinker, Inc.
3) Save.
4) Click on Pick/Edit Lines button
5) Clear the filter.
6) Select any line and the "returned" cell gets the focus. Realize that the field is mandatory.
7) Do no enter any value on returned cell
8) Click Done button
9) You are able to process although the mandatory column returned is not filled.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020559 closed Sandrahuguet Unexpected Error in RFC after having erased a reason value 
related to defect 0021359 closed dbaz [P&E] Fill a field with an invalid data type and press 'Done' button result in no action 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-23 13:00miruritaNew Issue
2012-05-23 13:00miruritaAssigned To => alostale
2012-05-23 13:00miruritaModules => Core
2012-05-23 15:32alostaleAssigned Toalostale => guilleaer
2012-05-24 17:04miruritaRelationship addedrelated to 0020559
2012-08-14 20:46dbazRelationship addedrelated to 0021359
2012-08-29 04:32eintelauIssue Monitored: eintelau
2012-09-17 16:19AugustoMauchAssigned Toguilleaer => AugustoMauch
2013-04-11 08:25shankarbAssigned ToAugustoMauch => shankarb
2013-04-22 06:06shankarbStatusnew => scheduled
2013-04-22 06:06shankarbfix_in_branch => pi
2013-04-22 06:06shankarbReview Assigned To => AugustoMauch
2013-04-22 06:06shankarbTriggers an Emergency Pack => No
2013-04-22 06:06shankarbfix_in_branchpi =>
2013-04-22 06:06shankarbIssue Monitored: AugustoMauch
2013-04-22 06:23hgbotCheckin
2013-04-22 06:23hgbotNote Added: 0058077
2013-04-22 06:23hgbotStatusscheduled => resolved
2013-04-22 06:23hgbotResolutionopen => fixed
2013-04-22 06:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c0d4406ef0c03a4cfd6be841fdf8eb34432c5eb3 [^]
2013-04-22 07:34hgbotCheckin
2013-04-22 07:34hgbotNote Added: 0058078
2013-04-22 11:06alostaleNote Added: 0058083
2013-04-22 11:06alostaleStatusresolved => new
2013-04-22 11:06alostaleResolutionfixed => open
2013-04-22 12:48hgbotCheckin
2013-04-22 12:48hgbotNote Added: 0058084
2013-04-22 12:49shankarbStatusnew => scheduled
2013-04-22 12:49shankarbfix_in_branch => pi
2013-04-22 12:50shankarbNote Added: 0058085
2013-04-22 12:50shankarbStatusscheduled => resolved
2013-04-22 12:50shankarbFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c0d4406ef0c03a4cfd6be841fdf8eb34432c5eb3 [^] => https://code.openbravo.com/erp/devel/pi/rev/d322cce147e5 [^]
2013-04-22 12:50shankarbResolutionopen => fixed
2013-04-22 13:30hgbotCheckin
2013-04-22 13:30hgbotNote Added: 0058087
2013-04-22 16:36hudsonbotCheckin
2013-04-22 16:36hudsonbotNote Added: 0058114
2013-04-22 16:36hudsonbotCheckin
2013-04-22 16:36hudsonbotNote Added: 0058115
2013-04-23 15:38AugustoMauchNote Added: 0058133
2013-04-23 15:38AugustoMauchStatusresolved => closed
2013-04-23 15:38AugustoMauchFixed in Version => 3.0MP23
2013-04-23 21:03hudsonbotCheckin
2013-04-23 21:03hudsonbotNote Added: 0058151
2013-04-23 21:03hudsonbotCheckin
2013-04-23 21:03hudsonbotNote Added: 0058152

Notes
(0058077)
hgbot   
2013-04-22 06:23   
Repository: erp/devel/pi
Changeset: c0d4406ef0c03a4cfd6be841fdf8eb34432c5eb3
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Apr 22 09:53:02 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/c0d4406ef0c03a4cfd6be841fdf8eb34432c5eb3 [^]

Fixes Issue 0020587: [Pick&Execute] Mandatory column validation is not working

The mandatory columns of pick and execute windows are validated on cellEditEnd event and onSubmit.

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0058078)
hgbot   
2013-04-22 07:34   
Repository: erp/devel/pi
Changeset: 6f099465923b63aa06c0146a85195083aae9225f
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Apr 22 11:03:54 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6f099465923b63aa06c0146a85195083aae9225f [^]

Related to Issue 0020587 : Added missing variable

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0058083)
alostale   
2013-04-22 11:06   
After this fix, in parameter windows without grid, the following javascipt error occurs in actionClick() function when trying to execute the process:

Uncaught TypeError: Cannot read property 'viewGrid' of undefined 3517613657acf5c921e03a7540aab2e9.js:35311
actionClick

Note view.grid is undefined for parameter windows without grid (non P&E ones).
(0058084)
hgbot   
2013-04-22 12:48   
Repository: erp/devel/pi
Changeset: d322cce147e597b707c4d3da4c1f637b44d8615e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Apr 22 16:13:01 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/d322cce147e597b707c4d3da4c1f637b44d8615e [^]

Related to Issue 0020587: [Pick&Execute] Mandatory column validation is not working

Added validations to resolve error in parameter windows without grid.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0058085)
shankarb   
2013-04-22 12:50   
Fixed in pi changeset https://code.openbravo.com/erp/devel/pi/rev/d322cce147e5 [^]
(0058087)
hgbot   
2013-04-22 13:30   
Repository: erp/devel/pi
Changeset: 8b85b058240c9149d03f0c5377017f3bf6124faf
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Apr 22 16:58:39 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8b85b058240c9149d03f0c5377017f3bf6124faf [^]

Related to Issue 0020587 : Code Refactoring

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0058114)
hudsonbot   
2013-04-22 16:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058115)
hudsonbot   
2013-04-22 16:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058133)
AugustoMauch   
2013-04-23 15:38   
Code reviewed and verified in pi@c0c3d4e9feab
(0058151)
hudsonbot   
2013-04-23 21:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f6ee8c2944a0 [^]

Maturity status: Test
(0058152)
hudsonbot   
2013-04-23 21:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f6ee8c2944a0 [^]

Maturity status: Test