Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0020578Openbravo ERP03. Procurement managementpublic2012-05-22 13:492012-05-25 12:13
plujan 
Sandrahuguet 
urgentmajoralways
closedfixed 
5
main 
3.0MP12 
Google Chrome
Openbravo 3.0
No
0020578: Error message appears without any valid information in Return to vendor screen
while selecting Lines tab and selecting nothing in Pick/Edit Lines option, System throws error message without any message.
Login as:

Username: Openbravo
Password: openbravo
Change the role to QA Testing Admin

Go to Return to Vendor window

Click New and select the vendor Vendor sports and save

** Create a line **

Select the Lines tab by clicking its name

Click the button Pick/Edit lines

Select no record

Click Done

Defect: System throws error message in Return to vendor header page without any valid message
Regression
related to defect 0020562 closed Sandrahuguet Error message appears without any valid information in Return to vendor screen 
related to defect 0020559 closed Sandrahuguet Unexpected Error in RFC after having erased a reason value 
related to defect 00205853.0MP14 closed dbaz [Pick&Execute] Sending null value in the table primary column info when the focus is on other tab. 
Issue History
2012-05-22 13:49plujanNew Issue
2012-05-22 13:49plujanAssigned To => Sandrahuguet
2012-05-22 13:49plujanWeb browser => Google Chrome
2012-05-22 13:49plujanModules => Openbravo 3.0
2012-05-22 13:49plujanIssue generated from0020562
2012-05-22 13:49plujanRelationship addedrelated to 0020562
2012-05-22 13:49plujanNote Added: 0048862
2012-05-22 13:50SandrahuguetNote Added: 0048863
2012-05-22 13:51SandrahuguetNote Deleted: 0048863
2012-05-22 13:51plujanTag Attached: Regression
2012-05-22 13:57SandrahuguetStatusnew => scheduled
2012-05-22 13:57Sandrahuguetfix_in_branch => pi
2012-05-22 16:33SandrahuguetNote Added: 0048868
2012-05-22 16:50plujanRelationship addedrelated to 0020559
2012-05-23 13:31SandrahuguetNote Edited: 0048868bug_revision_view_page.php?bugnote_id=0048868#r3499
2012-05-24 17:01hgbotCheckin
2012-05-24 17:01hgbotNote Added: 0048913
2012-05-24 17:01hgbotStatusscheduled => resolved
2012-05-24 17:01hgbotResolutionopen => fixed
2012-05-24 17:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6d9ad2597c25a215cdebff616d94a413a805de1c [^]
2012-05-24 17:03miruritaNote Added: 0048917
2012-05-24 17:03miruritaStatusresolved => closed
2012-05-24 17:03miruritaFixed in Version => 3.0MP12
2012-05-24 17:03miruritaRelationship addedrelated to 0020585
2012-05-24 17:13miruritaNote Added: 0048920
2012-05-25 12:13hudsonbotCheckin
2012-05-25 12:13hudsonbotNote Added: 0049203

Notes
(0048862)
plujan   
2012-05-22 13:49   
This is what the log shows:

2012-05-21 10:12:40,342 [ajp-8009-5] ERROR org.openbravo.common.actionhandler.SRMOPickEditLines -
java.lang.NullPointerException
    at org.openbravo.common.actionhandler.SRMOPickEditLines.cleanOrderLines(SRMOPickEditLines.java:100)
    at org.openbravo.common.actionhandler.SRMOPickEditLines.doExecute(SRMOPickEditLines.java:71)
    at org.openbravo.client.application.process.BaseProcessActionHandler.execute(BaseProcessActionHandler.java:63)
    at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:71)
    at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:193)
    at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:104)
    at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:177)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:427)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:63)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
    at org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:429)
    at org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:384)
    at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1600)
    at java.lang.Thread.run(Thread.java:662)
(0048868)
Sandrahuguet   
2012-05-22 16:33   
(edited on: 2012-05-23 13:31)
Test Plan 1:
-Login as:
  Username: Openbravo
  Password: openbravo
  Change the role to QA Testing Admin
-Go to Return to Vendor window
-Click New and select the business partner Vendor sports and save
-Select the Lines tab by clicking its name
-Click the button Pick/Edit lines
-Select no record
-Click Done
-Notice that you return to the previous window

Test Plan 2:
-Login as:
  Username: Openbravo
  Password: openbravo
  Change the role to QA Testing Admin
-Go to Return from Customer window
-Click New and select the business partner Customer A and save
-Select the Lines tab by clicking its name
-Click the button Pick/Edit lines
-Select no record
-Click Done
-Notice that you return to the previous window

Test Plan 3:
-Login as:
  Username: Openbravo
  Password: openbravo
  Change the role to QA Testing Admin
-Go to Return to vendor window
-Click New and select the business partner Vendor sports and save
-Select the Lines tab by clicking its name
-Click the button Pick/Edit lines
-Clean the filters by clicking the Filter icon that it is in the right corner
-Select one record and returned=blank
-Click Done
-Notice that you return to the previous window

Test Plan 4:
-Login as:
  Username: Openbravo
  Password: openbravo
  Change the role to QA Testing Admin
-Go to Return from customer window
-Click New and select the business partner Customer A and save
-Select the Lines tab by clicking its name
-Click the button Pick/Edit lines
-Clean the filters by clicking the Filter icon that it is in the right corner
-Select one record and returned=blank
-Click Done
-Notice that you return to the previous window

Test Plan 5:
-Login as:
  Username: Openbravo
  Password: openbravo
  Change the role to QA Testing Admin
-Go to Return to vendor window
-Click New and select the business partner Vendor sports and save
-Click the button Pick/Edit lines
-Clean the filters by clicking the Filter icon that it is in the right corner
-Select one record and returned=2
-Select other record and returned=blank
-Click Done
-Notice that you return to the previous window and in the lines tab appears the correct line selected.

Test Plan 6:
-Login as:
  Username: Openbravo
  Password: openbravo
  Change the role to QA Testing Admin
-Go to Return from customer window
-Click New and select the business partner Customer A and save
-Click the button Pick/Edit lines
-Clean the filters by clicking the Filter icon that it is in the right corner
-Select one record and returned=2
-Select other record and returned=blank
-Click Done
-Notice that you return to the previous window and in the lines tab appears the correct line selected.

(0048913)
hgbot   
2012-05-24 17:01   
Repository: erp/devel/pi
Changeset: 6d9ad2597c25a215cdebff616d94a413a805de1c
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed May 23 13:10:01 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6d9ad2597c25a215cdebff616d94a413a805de1c [^]

Fixed bug 20578, Fixed bug 20559, Fixed bug 20562
Add logic to avoid NullPointerException and NumberFormatException

---
M src/org/openbravo/common/actionhandler/RMInOutPickEditLines.java
M src/org/openbravo/common/actionhandler/RMShipmentPickEditLines.java
M src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
---
(0048917)
mirurita   
2012-05-24 17:03   
code review + testing OK
(0048920)
mirurita   
2012-05-24 17:13   
The issues was reproducible before (not visible for the user, only error trace on the log) but after this changeset [1] as the exception message is handled and displayed in the application the user perceives different result.

[1] https://code.openbravo.com/erp/devel/pi/rev/0d30cd20c9f8 [^]
(0049203)
hudsonbot   
2012-05-25 12:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test