Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020412Openbravo ERPB. User interfacepublic2012-05-03 18:112012-05-29 10:19
Reporterdbaz 
Assigned Tomtaal 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP12 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020412: "Match Statement" popup doesn't show the grid
Description"Match Statement" popup doesn't show the grid.

This grid is a smartclient grid in a classic page.
Steps To ReproduceGo to "Financial Account"
Select record "Bank - Account 2"

In form mode do this change: Matching Algorithm -> Standard

Now go to its child tab "Imported Bank Statement"
Create new one and fill
Name: "test"

Now go to its child tab "Bank Statement Lines"
Create new one and fill
Reference No: Line1
Amout IN: 10

Create new one and fill
Reference No: Line2
Amout IN: 20

Click button "Process"

Click button "Match Statement"

Click the magnifier glass icon.
Notice that the grid is not shown.

NOTE: Even with the DalUtil.FIELDSEPARATOR and OB.Constants.FIELDSEPARATOR to "." modification, it still doesn't work.

I have done a manual change in order to run Smartclient unobfuscated, and it seems that there is a problem with the date field, that's why it doesn't open.
Inside DateRangeItem.js there are two things that fail:

Inside "isc.DateRangeDialog.addMethods -> initWidget"
rangeItem.canvas
doesn't exist

Inside "setValue"
this.rangeItem.setFromDate
this.rangeItem.setToDate
don't exist

If you somehow manage to run this window from unobfuscated sources, you can use attached DateRangeItem.js to open the popup, although the calendar in the filter column related to the Date won't work
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00204383.0MP12 closed mirurita Date filter in selector popup grid does not work because of invalid override in other js file 
Attached Files? DateRangeItem.js (41,180) 2012-05-03 22:36
https://issues.openbravo.com/file_download.php?file_id=5189&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-05-03 18:11dbazNew Issue
2012-05-03 18:11dbazAssigned To => mtaal
2012-05-03 18:11dbazModules => Core
2012-05-03 19:42dbazNote Added: 0048361
2012-05-03 20:53dbazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3432#r3432
2012-05-03 22:36dbazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3433#r3433
2012-05-03 22:36dbazFile Added: DateRangeItem.js
2012-05-07 23:00hgbotCheckin
2012-05-07 23:00hgbotNote Added: 0048424
2012-05-07 23:00hgbotStatusnew => resolved
2012-05-07 23:00hgbotResolutionopen => fixed
2012-05-07 23:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c7aac5ae6ada0589a7799ea1b23015dd1a01c6d6 [^]
2012-05-07 23:08mtaalRelationship addedrelated to 0020438
2012-05-25 12:10hudsonbotCheckin
2012-05-25 12:10hudsonbotNote Added: 0049044
2012-05-29 10:19alostaleNote Added: 0049412
2012-05-29 10:19alostaleStatusresolved => closed
2012-05-29 10:19alostaleFixed in Version => 3.0MP12

Notes
(0048361)
dbaz   
2012-05-03 19:42   
Maybe other new selectors in classic windows should be reviewed too (I have tested, and aparently, they work ok):

AddOrderOrInvoice.html
Go to "Payment In"
Create new and save without any other modification
Click "Add Details" button
A new "Add Payment In" popup is opened. There it is the new selector.


AddTransaction.html
Go to "Financial Account"
Select record "Bank - Account 2"
Click "Add Transaction" button
With "Transaction Type" as "GL Item"
Some new selectors are shown


AddPaymentFromTransaction.html
Go to "Financial Account"
Select record "Bank - Account 2"
Click "Add Transaction" button
With "Transaction Type" as "Payment In/Out" click "Add Payment In/Out"
"Add Payment In" is opened. There it is the new selector


SelectExpectedPayments.html
Go to "Payment Proposal"
Create new record and click "Select Expected Payments"
It seems that, although that html has new selector code (org.openbravo.client.kernel/OBCLKER_Kernel/StaticResources), it really doesn't
(0048424)
hgbot   
2012-05-07 23:00   
Repository: erp/devel/pi
Changeset: c7aac5ae6ada0589a7799ea1b23015dd1a01c6d6
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon May 07 22:59:22 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c7aac5ae6ada0589a7799ea1b23015dd1a01c6d6 [^]

Fixes issue 20412: "Match Statement" popup doesn't show the grid
With the latest SC release the filter editor type was determined
in a different way. This has now been corrected using the info
sent from the server.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js
---
(0049044)
hudsonbot   
2012-05-25 12:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049412)
alostale   
2012-05-29 10:19   
Code reviewed and verified on pi@f94acbb414d4