Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020402Openbravo ERPA. Platformpublic2012-05-03 13:002012-05-25 12:10
Reporterrgoris 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020402: Completed button is visible when document is already completed
DescriptionThis is a matter of not "refreshing" the button status I guess. The Completed button is visible when document is already completed, for sales invoices.
Steps To ReproduceCreate a new sales invoice, save it and leave it in Draft status.
Make sure that both header and line level are in grid mode.
Select a line.
Hit the Complete button and complete the invoice.
Notice that the button Complete remains.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020227 closed alostale Window with three level tabs: G/L Journal. Buttons for second level tab don't get refreshed 
related to defect 0019713 closed alostale Button's display logic isn't correctly applied for a parent's tab button 
Attached Filespng CompletedButtonMustGo.PNG (197,776) 2012-05-03 13:00
https://issues.openbravo.com/file_download.php?file_id=5185&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-05-03 13:00rgorisNew Issue
2012-05-03 13:00rgorisAssigned To => alostale
2012-05-03 13:00rgorisFile Added: CompletedButtonMustGo.PNG
2012-05-03 13:00rgorisModules => Core
2012-05-03 13:00rgorisOBNetwork customer => No
2012-05-08 12:44alostaleRelationship addedrelated to 0019713
2012-05-08 15:00alostaleRelationship addedrelated to 0020227
2012-05-08 15:06alostaleNote Added: 0048449
2012-05-08 16:55alostaleNote Added: 0048458
2012-05-08 16:58hgbotCheckin
2012-05-08 16:58hgbotNote Added: 0048459
2012-05-08 16:58hgbotStatusnew => resolved
2012-05-08 16:58hgbotResolutionopen => fixed
2012-05-08 16:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/938f2b7e11c7e0417e1b56d5ab669b15208d8bea [^]
2012-05-09 11:17rgorisNote Added: 0048495
2012-05-09 11:17rgorisStatusresolved => closed
2012-05-25 12:10hudsonbotCheckin
2012-05-25 12:10hudsonbotNote Added: 0049055

Notes
(0048449)
alostale   
2012-05-08 15:06   
This can be reproduced invoking button in header tab in case header tab is in grid view, regardless view in child tab.
(0048458)
alostale   
2012-05-08 16:55   
Fix is not risky

Test plan:
-Follow steps to reproduce described in this issue
-Follow steps to reproduce described in issue 0020227
-Follow steps to reproduce described in issue 0019713
(0048459)
hgbot   
2012-05-08 16:58   
Repository: erp/devel/pi
Changeset: 938f2b7e11c7e0417e1b56d5ab669b15208d8bea
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 08 16:57:32 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/938f2b7e11c7e0417e1b56d5ab669b15208d8bea [^]

fixed bug 20402, fixed bug 20227, fixed bug 19713

  Fixed toolbar button refresh when using a button defined in a parent tab

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0048495)
rgoris   
2012-05-09 11:17   
tested and approved
(0049055)
hudsonbot   
2012-05-25 12:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test