Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020400Openbravo ERPA. Platformpublic2012-05-03 12:392012-05-28 09:21
Reporterrgoris 
Assigned Tonaiaramartinez 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020400: Associate Modify Payment Plan button with the Payment Plan tabs
DescriptionAs it is now, the Modify Payment Plan button is always present for completed Sales Invoices (and Purchase Invoices)which takes up space and is very dominant for a feature that is little used. The idea is to only show this button when the focus is on one of the child Payment Plan or Archived Payment Plan tabs.
Steps To ReproduceComplete an invoice. Look at orange buttons.
Proposed SolutionAssociate button (process) with the aforementioned tabs.
Additional Information
TagsMIR-Reviewed
Relationships
Attached Fileswmv ModifyPPbuttonDoesNotAppear.wmv (817,252) 2012-05-14 10:33
https://issues.openbravo.com/file_download.php?file_id=5215&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-05-03 12:39rgorisNew Issue
2012-05-03 12:39rgorisAssigned To => alostale
2012-05-03 12:39rgorisModules => Core
2012-05-03 13:02alostaleAssigned Toalostale => mirurita
2012-05-03 13:13miruritaTag Attached: MIR-Reviewed
2012-05-08 09:33naiaramartinezAssigned Tomirurita => naiaramartinez
2012-05-08 09:33naiaramartinezStatusnew => scheduled
2012-05-08 09:33naiaramartinezfix_in_branch => pi
2012-05-08 15:13naiaramartinezNote Added: 0048451
2012-05-10 13:31hgbotCheckin
2012-05-10 13:31hgbotNote Added: 0048553
2012-05-10 13:31hgbotStatusscheduled => resolved
2012-05-10 13:31hgbotResolutionopen => fixed
2012-05-10 13:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e3eca21395e54770aaf7436d10db0812d4ea72ca [^]
2012-05-14 10:33rgorisNote Added: 0048607
2012-05-14 10:33rgorisStatusresolved => new
2012-05-14 10:33rgorisResolutionfixed => open
2012-05-14 10:33rgorisFile Added: ModifyPPbuttonDoesNotAppear.wmv
2012-05-23 08:48naiaramartinezNote Added: 0048877
2012-05-25 12:11hudsonbotCheckin
2012-05-25 12:11hudsonbotNote Added: 0049090
2012-05-28 09:21naiaramartinezStatusnew => closed
2012-05-28 09:21naiaramartinezResolutionopen => no change required

Notes
(0048451)
naiaramartinez   
2012-05-08 15:13   
Test Plan:
  Go to Sales Invoice window and create a new header.
  Create a new line.
  Complete the invoice.
  Go to 'Payment in Plan' tab. Notice that the 'Modify Payment In Plan' is shown when the focus is in that tab. Moreover, even though the focus is that tab you won't be able to see the button if the invoice is not completed and it is paid.

  Go to Purchase Invoice window and create a new header.
  Create a new line.
  Complete the invoice.
  Go to 'Payment Out Plan' tab. Notice that the 'Modify Payment Out Plan' is shown when the focus is in that tab. Moreover, even though the focus is that tab you won't be able to see the button if the invoice is not completed and it is paid.
(0048553)
hgbot   
2012-05-10 13:31   
Repository: erp/devel/pi
Changeset: e3eca21395e54770aaf7436d10db0812d4ea72ca
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Tue May 08 13:21:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e3eca21395e54770aaf7436d10db0812d4ea72ca [^]

fixed bug 20400 Move 'Modify Payment Plan' button to child tab
the button was in invoice Header tab and it has been moved to 'Payment Plan'

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/model/views/FIN_PAYMENT_SCHED_INV_V.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0048607)
rgoris   
2012-05-14 10:33   
Basic functionality works but there is one thing that needs to be fixed still: when completing a sales invoice while looking at the Payment Plan tab, the Modify PP button does not appear by itself. You now need to switch child tabs in order to see it. See attached video.

It should appear by itself after completion.
(0048877)
naiaramartinez   
2012-05-23 08:48   
After executing a process belonging to the header (i.e. click on Complete button) the header tab gets focussed regardless of the selected tab at the moment of executing it (in your example, Payment Plan tab). This is the current behaviour on Openbravo, any change here will require platform team review.
Once the focus is on header tab, you cannot see buttons of child tabs.

Because of previous platform limitations we cannot change the tab that will get the focus after executing a process.

Furthermore, this functionality has been recently classified as advanced functionality (Paolo's request) and so the 'Modify Payment Plan' button (and Archived Payment Plan tab) is hidden by default.

We will proceed to close the issue.
(0049090)
hudsonbot   
2012-05-25 12:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test