Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020368Openbravo ERP07. Sales managementpublic2012-04-26 18:542012-05-25 12:11
Reporterrgoris 
Assigned ToSandrahuguet 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020368: Label "Payment In/Out" is incorrect in Sales Invoice and Purchase Invoice window
DescriptionThe label "Payment In/Out" is incorrect and confusing. Is it a payment that goes both ways (in and out)? Then, after having pressed the button, you get a dialogue that shows only Payment In for a sales invoice. There is no payment out here. The title of the dialogue also says "Payment In".

The button has a label that communicates two opposite actions. It is like having a shower with one button that says "hot" and "cold".

The reason is that the same button is used for both windows and that translation is easier into Spanish ("Añadir cobro/pago") but that should not be a reason to use an incorrect label in English.
Steps To ReproduceA completed sales invoice or purchase invoice shows the button "Add Payment In/Out"
Proposed SolutionCreate separate buttons for Sales Invoices and Purchase Invoices so we can properly label the buttons as follows:

- "Add Payment In" for Sales Invoices
- "Add Payment Out" for Purchase Invoices
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020405 closed naiaramartinez Change all "Payment In Plan" and "Payment Out Plan" labels to "Payment Plan" 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-26 18:54rgorisNew Issue
2012-04-26 18:54rgorisAssigned To => eduardo_Argal
2012-04-26 18:54rgorisModules => Core
2012-04-26 18:54rgorisOBNetwork customer => No
2012-05-02 14:11eduardo_ArgalNote Added: 0048232
2012-05-02 16:10rgorisNote Added: 0048235
2012-05-02 16:10rgorisNote Edited: 0048235bug_revision_view_page.php?bugnote_id=0048235#r3424
2012-05-07 15:57SandrahuguetAssigned Toeduardo_Argal => Sandrahuguet
2012-05-07 15:57SandrahuguetStatusnew => scheduled
2012-05-07 15:57Sandrahuguetfix_in_branch => pi
2012-05-07 16:53SandrahuguetRelationship addedrelated to 0020405
2012-05-07 17:27SandrahuguetNote Added: 0048416
2012-05-10 11:56hgbotCheckin
2012-05-10 11:56hgbotNote Added: 0048550
2012-05-10 11:56hgbotStatusscheduled => resolved
2012-05-10 11:56hgbotResolutionopen => fixed
2012-05-10 11:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dc8359e908b0782b9c69e144c18bd2657d8bc9aa [^]
2012-05-10 11:57miruritaNote Added: 0048551
2012-05-10 11:57miruritaStatusresolved => closed
2012-05-25 12:11hudsonbotCheckin
2012-05-25 12:11hudsonbotNote Added: 0049089

Notes
(0048232)
eduardo_Argal   
2012-05-02 14:11   
To avoid creating two different processes and then create another column with a display logic, we have decided to change the label to "Add Payment".
This will make translation more difficult as translator will need to have a look at the context to do a proper translation. I guess this is the standard procedure for translators, so it should not include too much overhead.
(0048235)
rgoris   
2012-05-02 16:10   
Can you also change the "Modify Payment In Plan" to "Modify Payment Plan" and "Modify Payment Out Plan" to "Modify Payment Plan"?
(0048416)
Sandrahuguet   
2012-05-07 17:27   
Test Plan 1:
-Go to sales invoice window
-Select a line (complete=yes and payment complete=no)
-You can see the button Add Payment

Test Plan 2:
-Go to purchase invoice window
-Select a line (complete=yes and payment complete=no)
-You can see the button Add Payment
(0048550)
hgbot   
2012-05-10 11:56   
Repository: erp/devel/pi
Changeset: dc8359e908b0782b9c69e144c18bd2657d8bc9aa
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon May 07 17:43:03 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dc8359e908b0782b9c69e144c18bd2657d8bc9aa [^]

Fixed bug 20368 Change label "Payment In/Out"
Change label "Payment In/Out" in Sales Invoice and
Purchase Invoice window

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS.xml
---
(0048551)
mirurita   
2012-05-10 11:57   
code review + testing OK

The button label in Sales/Purchase Invoice is: "Add Payment"
(0049089)
hudsonbot   
2012-05-25 12:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test