Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020330Openbravo ERPI. Performancepublic2012-04-23 13:452012-04-24 08:43
Reporteregoitz 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP10 
Target Version3.0MP11Fixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020330: Performance problem when clicking on the checbox of the pickandexecute refernce when having a lot of rows on m_producprice table
DescriptionPerformance problem when clicking on the checbox of the pickandexecute refernce when having a lot of rows on m_producprice table
Steps To Reproduce-Define products and product prices to get arround 100.000 entries on the m_productprice table.
-Open the return shipment window
-Cick on pick&execute window
-Select a elment by clicking on the checbox
*The row is changes to editable and the cpu goes to 100%
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0020506 closed marvintm Default filter value is not shown in selector grid the first time you open it 
Attached Filespng request-product-selector.png (74,802) 2012-04-23 14:27
https://issues.openbravo.com/file_download.php?file_id=5161&type=bug
png

png no-request-product-selector.png (61,093) 2012-04-23 14:27
https://issues.openbravo.com/file_download.php?file_id=5162&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-04-23 13:45egoitzNew Issue
2012-04-23 13:45egoitzAssigned To => iperdomo
2012-04-23 13:45egoitzModules => Core
2012-04-23 13:51iperdomoStatusnew => scheduled
2012-04-23 13:51iperdomofix_in_branch => pi
2012-04-23 14:08iperdomoTag Attached: Performance
2012-04-23 14:26iperdomoNote Added: 0047879
2012-04-23 14:27iperdomoFile Added: request-product-selector.png
2012-04-23 14:27iperdomoFile Added: no-request-product-selector.png
2012-04-23 14:29hgbotCheckin
2012-04-23 14:29hgbotNote Added: 0047880
2012-04-23 14:29hgbotStatusscheduled => resolved
2012-04-23 14:29hgbotResolutionopen => fixed
2012-04-23 14:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1853df5df43d6d5efc8ab9fc8c62dfe416ca9acb [^]
2012-04-24 03:11hudsonbotCheckin
2012-04-24 03:11hudsonbotNote Added: 0047895
2012-04-24 08:43alostaleNote Added: 0047896
2012-04-24 08:43alostaleStatusresolved => closed
2012-04-24 08:43alostaleFixed in Version => 3.0MP11
2012-05-15 13:53iperdomoRelationship addedrelated to 0020506

Notes
(0047879)
iperdomo   
2012-04-23 14:26   
Due the some logic, when a FormItem has an optionDataSource, SmartClient makes a request to get the possible values.
More info at: http://www.smartclient.com/docs/8.1/a/b/c/go.html#attr..FormItem.fetchMissingValues [^]

In the case of an editable line in a grid, SmartClient makes an item for each column. The product column is disabled in this case, but a request without filters was made to get the possible values (check the
request-product-selector.png file).

The fix is to set the fetchMissingValues at FormItem level to avoid this problem in all items.

After making the change no request is made to the product selector datasource (no-request-product-selector.png)
(0047880)
hgbot   
2012-04-23 14:29   
Repository: erp/devel/pi
Changeset: 1853df5df43d6d5efc8ab9fc8c62dfe416ca9acb
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Apr 23 14:28:13 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1853df5df43d6d5efc8ab9fc8c62dfe416ca9acb [^]

Fixes issue 20330: Set the fetchMissingValues flag to false at FormItem level
- If fetchMissingValues is set to true, SmartClient makes a request on init() or
  setValue() when the FormItem has an optionDataSource

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0047895)
hudsonbot   
2012-04-24 03:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2b25ce4cc3a9 [^]

Maturity status: Test
(0047896)
alostale   
2012-04-24 08:43   
Code reviewed and verified on pi@c1950986e5af